Commit Graph
1432 Commits
Author SHA1 Message Date
dependabot[bot] e07cba15ba Bump NUnit.Console from 3.15.0 to 3.15.2 (#1860)
Bumps [NUnit.Console](https://github.com/nunit/nunit-console) from 3.15.0 to 3.15.2.
- [Release notes](https://github.com/nunit/nunit-console/releases)
- [Changelog](https://github.com/nunit/nunit-console/blob/main/CHANGES.txt)
- [Commits](https://github.com/nunit/nunit-console/compare/3.15.0...3.15.2)

---
updated-dependencies:
- dependency-name: NUnit.Console
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-30 13:51:07 +02:00
Martin Regen 10d4dbcaa9 Improve ResendData server support (#1854)
* add resend data support to sample node manager
* After WG discussion, ensure after ResendData only a single value per monitored item is sent in the next publish (sync client cache)
* Seperate resend data state from ready to publish with IsResendData property
2022-06-29 06:41:59 +02:00
Suciu Mircea Adrian c0fc029c8d Avoid deadlock on processing events. (#1853)
* Moved validation of RolePermission from MonitoredItem::Publish to MonitoredNode::OnReportEvent.
Refactor MasterNodeManager::GetManagerHandle to avoid calling other node manager's GetManagerHandle inside a lock statement
2022-06-21 11:53:47 +03:00
opcfoundation-org df71776c75 Modelcompiler 1.04.11 (#1850)
* latest nodeset without reference to servicemodel
2022-06-21 11:51:41 +03:00
Martin Regen 93e549ad4b Hide error message for BadSecurityChecksFailed (#1846) 2022-06-10 13:49:29 +02:00
Suciu Mircea Adrian 7aa7270c34 Fix monitored item role permissions.
* Fixed casting of event snapshot handler.
* Added Server Session property EndpointDescription ;
* Limited reporting and corrected the filtering of Audit events;
2022-06-10 08:53:52 +03:00
Martin Regen 6d675b8cd0 Use secure passcode for temp pfx (#1838)
- instead of random guid use a passcode generated with CPRNG.
2022-06-07 11:53:50 +02:00
KircMax 225e3557ce Provide more information to error message when throwing in CSR decode (#1835)
- add text of encoded and expected application URI
2022-06-07 09:04:46 +02:00
Suciu Mircea Adrian 57f979b559 InstanceStateSnapshot sets value of Handle when Initialize is called to "state" argument
InstanceStateSnapshot sets value of Handle when Initialize is called to "state" argument.
2022-06-06 14:25:53 +03:00
Suciu Mircea Adrian d789d8bf51 Added server method ResendData functionality
* Added ResendData functionality
2022-06-06 11:11:39 +03:00
OctaviaStan e3ac2bf4db Defer MethodId permissions validation to the point where the actual MethodState that will be executed is identified
* Defer MethodId validation to the point where the actual MethodState that shall be executed is found to avoid executing a method that does not have the right access permissions.
2022-06-02 15:28:06 +03:00
OctaviaStan 8cc18b32fc The formatter implementation from Microsoft.Extensions.Logging.LoggerExtensions class is ignoring the exception object and the exception information is not saved into log file. see the existing implemetation from below. (#1827)
Added handling for situation when the exception is not null and reused the existing code for formatting exceptions.
2022-05-31 08:31:06 +03:00
dependabot[bot] 23a8930d63 Bump Moq from 4.18.0 to 4.18.1 (#1822)
Bumps [Moq](https://github.com/moq/moq4) from 4.18.0 to 4.18.1.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.18.0...v4.18.1)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-28 09:37:52 +02:00
niveditha-sooda 0ac410b8b1 Loader for PEM private keys, Custom cert validator application error message (#1765)
-Added a loader if no PFX private key exists, the PEM private key is loaded.
-Added the support in certificate validator for custom application error messages.
2022-05-28 09:37:31 +02:00
Jörn Schlingensiepen a7cfe2f2b7 Update NodeID sample comment (#1820)
The sample included a fully named NodeId but the Format() uses the information already included in the instance. It might be easier to understand, if there is another sample and a node. Thus we can avoid confusion.
2022-05-13 13:32:28 +02:00
dependabot[bot] a16accfae6 Bump Serilog.Expressions from 3.3.0 to 3.4.0 (#1813)
Bumps [Serilog.Expressions](https://github.com/serilog/serilog-expressions) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/serilog/serilog-expressions/releases)
- [Commits](https://github.com/serilog/serilog-expressions/compare/v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: Serilog.Expressions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-13 10:31:39 +02:00
Martin Regen 4c389c1857 Merge pull request #1818 from OPCFoundation/master369
Merge release fixes in master
2022-05-13 09:18:33 +02:00
Martin Regen f345f909b6 merge master 2022-05-13 07:56:31 +02:00
dependabot[bot] 5ae4dca206 Bump Moq from 4.17.2 to 4.18.0 (#1814)
Bumps [Moq](https://github.com/moq/moq4) from 4.17.2 to 4.18.0.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.17.2...v4.18.0)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-12 21:18:19 +02:00
Martin Regen 88a96a1d97 Handle special cases for chunking. (#1816)
- Chunk count one compare is incorrect
- Instead of a static configuration calculate the chunk count limits dynamically, as changing buffer size in the negotiation was not taken into account and could lead to reduced message size.
- Remove the static chunk count calculation.
1.4.368.58
2022-05-12 20:45:25 +02:00
Martin Regen fd9a91afe7 Fix issues with reconnect handler and subscription transfer (#1802)
- set `KeepAliveTimeout` default back to 5s, was unintentionally set to 50s in 368 release
- fix a bug that duplicate subscriptions were created after reconnect when transfer succeeds.
- add a property to enable subscription transfer in reconnect, set `Session.TransferSubscriptionsOnReconnect=true` to enable, IOP issues may not allow to use it with some servers.
- add a `SessionReconnectHandler(true)` constructor to support reconnect abort, if the connection recovers before reconnect timer called. If the new constructor is used, its a breaking change: Needs check of  `Session` property in Reconnect handler callback, if aborted `Session==null`.
- Reduce warning log output if server timestamp > client time.
- Add handling when subscriptions can not be transferred, e.g. when false user credentials or no security prevent transfer.
- Improve the reconnect timer handling by using `OperationLimit` in reconnect.
- Add sample for `SessionReconnectHandler` in console client.
- Seperate session sample code from `UAClient`.
- Tested on popular demo servers of various SDK vendors.
- Fix Winforms ref client
2022-05-11 22:28:07 +02:00
dependabot[bot] a7d5865e06 Bump System.Io.Pipelines from 6.0.2 to 6.0.3 (#1806)
Bumps [System.Io.Pipelines](https://github.com/dotnet/runtime) from 6.0.2 to 6.0.3.
2022-05-11 16:56:06 +03:00
dependabot[bot] 1b573eb23e Bump Microsoft.NET.Test.Sdk from 17.1.0 to 17.2.0 (#1805)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.1.0 to 17.2.0.
2022-05-11 16:55:21 +03:00
OctaviaStan 6f2e5c80a0 Aggregate corrections for CTT 1.4.9.398 (#1797)
* Aggregate corrections for CTT 1.4.9.398

Use IsGood instead of StatusCode.IsGood to take into account the configured TreatUncertainAsBad
Handle corectly the rule: if PercentDataBad == PercentDataGood the PercentDataGood rule is used. When they both are 50 the result was calculated using the PercentDataBad
Other fixes
2022-05-11 12:01:36 +03:00
Suciu Mircea Adrian 71af2c1d15 Added default value DefaultMaxChunkCount (#1789)
* Added default values DefaultRequestMaxChunkCount and DefaultResponseMaxChunkCount
* The negotiated Request and Response MaxChunkCount values are checked when building a chunked message.
2022-05-07 20:54:09 -07:00
Suciu Mircea Adrian 1e22c4d83f Filter events against Role-based permissions (#1798)
Events can be filtered against the Role-based permissions.
2022-05-06 09:30:43 -07:00
Martin Regenandmrsuciu 51549f5ed8 Strict rules to compare X500 distinguished names (#1784)
- Certificates should compare X500DistinguishedName with binary ASN.1 compare
- Other compares should follow ordinal and not resort DN entries
- Fix all related issues to pass tests, e.g. GDS certificates accepted with reversed Subject, cert validation
- Add defensive checks in cert validation 

Co-authored-by: mrsuciu <Mircea-Adrian.Suciu@softing.com>
2022-05-06 16:11:34 +02:00
Suciu Mircea Adrian ae9bf1beef Check op limits on Variant arrays and TranslateBrowsePathsToNodeIds (#1788) 2022-05-05 11:40:19 -07:00
KircMax 5722dd56f7 Add property to get local endpoint from IMessageSocket (#1793)
Add the getter (since the System.Net.Sockets.Socket: m_socket does not implement a setter) for the LocalEndPoint so that a user can access the Information on which IP+Port the Socket is running on
2022-05-05 11:33:44 -07:00
dependabot[bot] de9d13ff8c Bump Serilog from 2.10.0 to 2.11.0 (#1782)
Bumps [Serilog](https://github.com/serilog/serilog) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/serilog/serilog/releases)
- [Changelog](https://github.com/serilog/serilog/blob/dev/CHANGES.md)
- [Commits](https://github.com/serilog/serilog/compare/v2.10.0...v2.11.0)

---
updated-dependencies:
- dependency-name: Serilog
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 21:42:59 +02:00
Martin Regen 7072fe0771 Improve ref server for use with CTT (#1775)
- Improve formatting and log strings for new alarm node managers.
- Remove the TestData Alarms as they cause issues in the CTT tests
- Add a -ctt option to start the alarms endless for testing, stop alarms in other node managers.
- Unify the way the node managers are created in the quickstarts sample.
- Bring back 'dummy' appveyor config to disable the builds.
- fix codecov build
- add a few more unrelated tests
2022-04-19 09:29:21 +02:00
Archie Miller d7e43e9ffc Implement An AlarmNodeManager (#1739)
Implement An AlarmNodeManager with a few alarms and an alarm cycle.

Designed as an example to run against the CTT Alarm conformance Units
2022-04-12 07:59:20 +02:00
Martin Regen 73533cc17f Add missing EC PEM Export, refactor test asset enumerator for generalized usage (#1774)
- Add missing PEM private key export for EC (.NET6/Netstandard2.1 only)
- Remove some duplicate code in PEMWriter class
- Refactor enumerator for Test Datapoint sources to be generic and usable for more cases
- Add some tests for NodeSet2 import (using the refactored enumerator)
- Fix some warnings and PR template typos along the way.
2022-04-11 17:53:31 +02:00
Suciu Mircea Adrian 3f04e9d370 Filter out audit events in case the ServerType_Auditing values is false or the channel is not encrypted (#1770)
* Filter out audit events in case the ServerType_Auditing values is false or the channel is not encrypted
2022-04-08 10:41:28 +03:00
niveditha-sooda fa523b905a Changed the access modifiers for a few client session members (#1737)
-change to the access modifiers for some of the members in the Session class and a method in the DataDictionary class to support custom solution.
2022-04-01 15:32:59 +02:00
Zigby cbe886dcb0 Enable client support for multiple sessions on a single channel (#1659)
* Client API changes to support multiple sessions on a single channel
* Tested against freeopcua:python:server and ProSys simulation server
2022-04-01 14:27:32 +02:00
Martin Regen 0085597be2 Bump version to 369 (#1767)
Prep master for next milestone
2022-04-01 13:28:05 +02:00
Martin Regen 586a63cc5f Merge pull request #1753 from OPCFoundation/master
Merge bug fixes in release 1.4.368 branch for Nuget update
1.4.368.53
2022-04-01 09:07:10 +02:00
Martin Regen eda38cb6c2 XmlSerializer in .NET 6 Omits Line Breaks by Default (#1760)
* fix xml output in .NET 6
* unify the way xml writer settings are generated and used, add validation tests
1.4.368.52-preview
2022-03-31 20:13:49 +02:00
Martin Regen cc09a561d1 Update Nuget license information (#1764)
The OPC Foundation Technical Control Board on March 30th decided on the following changes with regard to the license information in the published Nuget packages:

•	Replace the “Redistributables” license for OPC UA Nuget packages with the Dual License.
•	Change the dual license in the source files so that “members” are replaced with “corporate members”. (see #1763)

Effectively, 
- Nuget packages from libraries provided as samples which only build from source code which is covered by a MIT license, are the directly tagged with the MIT license.
- Nuget packages which build from source code where the headers imply the dual license applies, are tagged with the Dual License  'LICENSE.txt' found in the repository root.
2022-03-31 15:42:51 +02:00
Martin RegenandSuciu Mircea Adrian 3a378e8644 Fix dual license headers (#1763)
Headers incorrectly state that the RCL applies to members, however the OPC Source Deliverables license states RCL is applicable only to corporate members. 

The OPC Foundation Technical Control Board on March 30th decided on the following changes with regard of the license headers:

• Change the dual license in the source files so that “members” are replaced with “corporate members”. 

Co-authored-by: Suciu Mircea Adrian <Mircea-Adrian.Suciu@softing.com>
2022-03-31 13:14:17 +02:00
Martin Regen 8ddda78aff Fix for Usertokenpolicy Anonymous, security policy default should be None (#1756)
- Only an issue if the configuration does not specify the security policy uri for anonymous token
- If the config does not specify the security policy, for anonymous user token the security profile Basic256Sha256 was chosen. 
- This setting requires for the client to trust the server certificate if it tries to connect with security None, may cause IOP issues when no security is chosen and encryption is required for the anonymous user token.
2022-03-30 09:20:13 +02:00
Martin Regen 8d0eb40206 Update README.md and templates (#1749)
- fix a few badges
- add new template for issues and PR
2022-03-29 14:23:55 +02:00
Tim Jöhnk 6f9f70cd4b Expose actual network client connected states in IUaPubSubConnections (#1725)
* Expose actual network client connected states in IUaPubSubConnections
2022-03-29 12:20:17 +03:00
Martin Regen 1263881a7f Adapt logging abstractions version to target framework (#1751)
* fix the nuget versions

* revert targetframework

* avoid build warning
2022-03-28 14:01:42 +03:00
dependabot[bot] 0c707a4294 Bump NUnit from 3.13.2 to 3.13.3 (#1741)
Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.2 to 3.13.3.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.3/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.13.2...v3.13.3)

---
updated-dependencies:
- dependency-name: NUnit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-28 08:30:15 +02:00
KUNYUAN XIAO 0a838e0319 Fix session recreate TransferSubscriptions bug. (#1746)
* Fixed session recreate TransferSubscriptions bug.

1. When session is recreated and there is no subscription is needed to transfer, it will throw Exception - BadNothingToDo. After adding check the subscriptions count, it won't try to subscribe non-existing subscriptions.

2. When session is recreated and there are subscriptions are needed to transer, it transferred wrong subscriptions. It should transfer old subscriptions in old session, but current code transfer new subscriptions in new session to new session - which will always throw Exception - "A subscription can not be transferred due to missing transfer Id"

* Log update and TransferSubscriptions update.

fixes #1733 and #1734
2022-03-28 08:29:38 +02:00
Suciu Mircea Adrian 244234cdf0 Changes for testing and fixing git bug #1694 (#1747)
* Changes for testing and fixing git bug 1694

* Removed the duplicate server address differing by port number
2022-03-25 10:32:48 +02:00
Martin Regen 24931cfea0 fix SByte vs Byte collection (#1740) 2022-03-22 08:29:31 +02:00
Martin Regen 5c8cea2990 Offload .NET 6 tests and code coverage to github actions (#1730)
* add buildandtest.yml with test and coverage build
2022-03-18 15:36:40 +01:00