mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-23 18:39:26 +08:00
275c3800b5
# Description Adds supported live add, reload, and remove lifecycle operations for NodeManager instances on a running server. The change introduces a DI-backed `INodeManagerLifecycle` service with direct `StandardServer` access, generation-aware registration handles, copy-on-write routing, transactional prepare/commit/rollback, runtime NodeSet convenience APIs, append-only namespace updates, model and semantic change notifications, additive-compatible complex type priming, and complete teardown behavior. Lifecycle publication is coordinated with requests, sessions, subscriptions, monitored items, continuation points, and shutdown so retired managers cannot remain reachable or be disposed while still in use. Compatible monitored items transfer to replacement generations without a transient bad status. Removed or incompatible Nodes publish `BadNodeIdUnknown` as required by OPC UA Part 4 section 5.8.4.1, retain their MonitoredItem identity, and automatically recover when a compatible Node with the same NodeId returns. Registration is documented end to end in the new [docs/NodeManagerRegistration.md](docs/NodeManagerRegistration.md), which covers compile-time, startup, and runtime registration together with the guarantees for MonitoredItems, Browse continuation points, namespace indexes, DataTypes, and change notifications. ## Review feedback addressed Interface surface reduced, as requested: - `INodeManagerMonitoredItemTracker` folded into `ISubscriptionMonitoredItemLifecycle`. - `INodeManagerMutationCoordinator` and the asynchronous MonitoredItem recovery entry point folded into `IDynamicNodeManagerHost`. - `ISessionClosingRegistry` folded into `IServerInternal`, then replaced by `ISession.IsClosing`. - `ISubscriptionDeletionRegistry` folded into `ISubscriptionManager`, then removed entirely. - `INodeManagerContinuationPointTracker` folded into `ISession`. - The synchronous recovery entry point kept on its own `ISyncNodeManagerMonitoredItemRecovery`, because `AddPredefinedNode` cannot await; it still routes through the asynchronous `INodeManagerMonitoredItemLifecycle` that `AsyncNodeManagerAdapter` exposes. - `IMonitoredItemLifecycle` renamed to `IDetachableMonitoredItem`. Reach into the Subscription area reduced to the minimum the feature needs: - The lifecycle feature itself leaves `SubscriptionManager` almost untouched: two guards that reject a request from a Session that is closing, on `CreateSubscription` and on `TransferSubscriptions`, because it would create state that is about to be torn down. The deletion claim registry, the session closing gates, the closed-session bookkeeping and the deletion restore paths introduced by earlier revisions are gone. Transferring a subscription away from a session that is closing stays allowed, since that is the recovery path the service exists for; the race that exposed is fixed by serialising source-queue closure with the transfer rather than by rejecting it. - Queueing is disabled again for a MonitoredItem with `QueueSize <= 1`, as before this PR. Without a queue the Client is served the last sampled value, so the missing-Node notification simply becomes that value; losing values is expected for a MonitoredItem without queuing. - What remains of the notification is one `DataValue` plus one bool in `DataChangeQueueHandler`, mirroring the existing overflow pair, which stops it being the value discarded when a configured queue is full. - `MonitoredItem` keeps its original publish path, its original queue creation and restore paths, its original triggering behaviour, and no per-epoch bookkeeping. - `IStoredMonitoredItem` carries `IsDeleted` and `IsDetached`, so a restored item reports the state it was stored with rather than one inferred from the last value's StatusCode. Other feedback: - Documented `HostedNodeManagerLifecycle`, `IDynamicNodeManagerHost`, `NodeManagerRoutingTable`, and the `RequestManager` validation and request scopes. - Renamed `ValidateMonitoredItemAsync` to `CanAttachMonitoredItemAsync` and `RestoreMonitoredItemAsync` to `RecoverMonitoredItemAsync`, so the lifecycle API no longer collides with the durable Subscription `RestoreMonitoredItem` path used at server startup. - Removed the `CustomNodeManager2` dependency from the synchronous MonitoredItem recovery path. - `DataChangeQueueHandler` is back to the two constructors 1.5.378 shipped, each taking an optional `TimeProvider`. - Session closing is a one-way latch, and the Session is removed even when teardown throws. - Documented what a custom NodeManager has to implement to take part in live lifecycle operations, and which NodeManager implements `INodeManagerReloadParticipant` today. ## Fixes found during review - The guard that stops a NodeManager lifecycle operation being started from inside a service handler never fired. It was backed by an `AsyncLocal` written inside `async ValidateRequestAsync`, which is invisible to the caller that awaited it, so a lifecycle call from a NodeManager callback waited for its own request and held the lifecycle semaphore forever. The mark is now applied by the service dispatcher, and the drain is bounded so no path can wedge the lifecycle permanently. - `ValidateRequestAsync` is no longer virtual. An override that rejected a request after calling `base` left it registered forever; subclasses now use `OnRequestValidatedAsync`, whose failures complete the request. - A MonitoredItem deleted and disposed while a reload was handing it to the replacement NodeManager could be attached anyway. The item now reserves itself for the hand-over and the transition takes it back if it was disposed meanwhile. - The Overflow bit is recorded and applied when the value is published, as the surrounding design does, rather than written into the value at enqueue time. - MonitoredItem cleanup for a Subscription being deleted no longer passes null entries to `DeleteMonitoredItemsAsync`. - Browse continuation points of a retired NodeManager are persisted and disposed outside the Session lock. ## Open review discussions Three threads are open, replied to and awaiting reviewer decisions: separating service-call dispatch from NodeManager handling in `MasterNodeManager` (tracked as #4098), the request-scoping shape in `StandardServer`, and how much of the async MonitoredItem service implementation should stay in `Subscription`. Issue #4102 records a specification ambiguity found while implementing the missing-Node notification: Part 4 §5.8.4.1 makes it mandatory, but the protected over-capacity queue entry §5.13.1.5 defines applies to `EventQueueOverflowEventType` only, so the specification does not say how it survives a full queue. ## Validation - Full `Opc.Ua.Server.Tests` on net10.0: 3,768 passed, 5 skipped. - Lifecycle, MonitoredItem, Subscription and continuation point suites: 185 passed on net10.0 and 75 on net48. - Server builds complete with zero warnings or errors. - Two failures are pre-existing and unrelated: `DurableDataValueQueueVerifyReferenceBatchingAsync` (flaky `BatchPersistor` file contention, passes in isolation on net10.0 and net48) and `ConfigureApplicationBuildsSharedClientAndServerConfigurationAsync` (fails on a clean tree with these changes stashed). ## Related Issues - Fixes #3993 - Follow-up tracked in #4098
149 lines
5.9 KiB
C#
149 lines
5.9 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Opc.Ua.Server.Fluent;
|
|
using Opc.Ua.Server.RuntimeNodeSet;
|
|
using Quickstarts.ReferenceServer;
|
|
|
|
namespace Opc.Ua.Server.Tests.RuntimeNodeSet
|
|
{
|
|
/// <summary>
|
|
/// A <see cref="ReferenceServer"/> that loads the existing
|
|
/// <c>ServerComplexTypesTestModel.NodeSet2.xml</c> embedded resource through
|
|
/// <see cref="RuntimeNodeSetNodeManagerFactory"/> instead of the hand-written
|
|
/// <c>ServerComplexTypesTestNodeManager</c>. This exercises the full runtime
|
|
/// NodeSet import path including namespace registration, parent-child linking,
|
|
/// fluent configure callbacks, and the default complex-type loading sequence.
|
|
/// </summary>
|
|
internal sealed class RuntimeNodeSetTestServer : ReferenceServer
|
|
{
|
|
/// <summary>
|
|
/// The namespace URI of the runtime test model (reuses the complex types test model).
|
|
/// </summary>
|
|
public const string NamespaceUri = "http://opcfoundation.org/UA/ServerComplexTypesTest/";
|
|
|
|
/// <summary>
|
|
/// Node identifier of the container object that holds the test variables.
|
|
/// </summary>
|
|
public const uint ComplexTypesTestDataObject = 15020;
|
|
|
|
/// <summary>
|
|
/// Node identifier of the <c>PointValue</c> variable.
|
|
/// </summary>
|
|
public const uint PointValueVariable = 15021;
|
|
|
|
/// <summary>
|
|
/// Node identifier of the <c>ColorValue</c> variable.
|
|
/// </summary>
|
|
public const uint ColorValueVariable = 15022;
|
|
|
|
/// <summary>
|
|
/// Node identifier of the <c>TestPoint</c> structure DataType.
|
|
/// </summary>
|
|
public const uint TestPointDataType = 15010;
|
|
|
|
/// <summary>
|
|
/// Node identifier of the <c>TestPoint</c> Default Binary encoding node.
|
|
/// </summary>
|
|
public const uint TestPointBinaryEncoding = 15011;
|
|
|
|
/// <summary>
|
|
/// Node identifier of the <c>TestColor</c> enumeration DataType.
|
|
/// </summary>
|
|
public const uint TestColorDataType = 15001;
|
|
|
|
/// <summary>
|
|
/// Counter incremented by the <c>OnRead</c> callback wired on
|
|
/// <c>ColorValue</c>. Tests may read this to verify the callback fired.
|
|
/// </summary>
|
|
public static int ColorValueReadCallbackCount;
|
|
|
|
private const string kResourceName =
|
|
"Opc.Ua.Server.Tests.ComplexTypes.ServerComplexTypesTestModel.NodeSet2.xml";
|
|
|
|
/// <summary>
|
|
/// Initializes the server and registers the
|
|
/// <see cref="RuntimeNodeSetNodeManagerFactory"/> that loads the embedded
|
|
/// test NodeSet via a stream source.
|
|
/// </summary>
|
|
/// <param name="telemetry">
|
|
/// Telemetry context forwarded to the base server.
|
|
/// </param>
|
|
public RuntimeNodeSetTestServer(ITelemetryContext telemetry)
|
|
: base(telemetry)
|
|
{
|
|
Interlocked.Exchange(ref ColorValueReadCallbackCount, 0);
|
|
|
|
var options = new RuntimeNodeSetOptions
|
|
{
|
|
Sources = [RuntimeNodeSetSource.FromStream(
|
|
"ServerComplexTypesTestModel",
|
|
_ => new System.Threading.Tasks.ValueTask<Stream>(OpenTestStream()),
|
|
[NamespaceUri])],
|
|
DefaultNamespaceUri = NamespaceUri,
|
|
Configure = builder =>
|
|
{
|
|
// Wire an OnRead callback on ColorValue to prove the fluent
|
|
// configure path and parent-child browse resolution work.
|
|
builder
|
|
.Node("ComplexTypesTestData/ColorValue")
|
|
.OnRead(static (ISystemContext c, NodeState n, ref Variant v) =>
|
|
{
|
|
Interlocked.Increment(ref ColorValueReadCallbackCount);
|
|
return ServiceResult.Good;
|
|
});
|
|
}
|
|
};
|
|
|
|
AddNodeManager(new RuntimeNodeSetNodeManagerFactory(options));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Opens the embedded test NodeSet2 resource stream.
|
|
/// </summary>
|
|
internal static Stream OpenTestStream()
|
|
{
|
|
Stream stream = typeof(RuntimeNodeSetTestServer).Assembly
|
|
.GetManifestResourceStream(kResourceName);
|
|
|
|
if (stream is null)
|
|
{
|
|
throw new InvalidOperationException(
|
|
$"Embedded resource '{kResourceName}' was not found.");
|
|
}
|
|
|
|
return stream;
|
|
}
|
|
}
|
|
}
|