mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 08:41:51 +08:00
dc441a8b95
## Proposed changes When the source generator creates code for "instance" definitions (e.g., the `Server` object which has `ServerType` as its type definition), it currently uses the modelling rules specified on the **instance's children**, which may differ from the **type definition's children**. For example: - `ServerType` defines `UrisVersion` as `ModellingRule="Optional"` - `Server` instance overrides it to `ModellingRule="Mandatory"` This PR introduces two layers of modelling rule enforcement: ### 1. OPC UA promotion semantics (always active) Regardless of any configuration, the generator now enforces OPC UA modelling rule promotion semantics. Instances may only **promote** the type definition's rule: | Type Definition Rule | Allowed Instance Overrides | |---|---| | `Optional` | `Mandatory` | | `OptionalPlaceholder` | `Mandatory`, `MandatoryPlaceholder` | | `MandatoryPlaceholder` | `Mandatory` | Any other instance override (demotion) is silently rejected and the type definition's rule is used instead. This applies to both structural code generation decisions and the emitted runtime `ModellingRuleId`. ### 2. `UseTypeDefinitionModellingRules` option (opt-in) When enabled, the generator uses the type definition's modelling rules **unconditionally** — instance overrides are ignored entirely (even valid promotions). This is useful for stack generation where the type definition's semantics should be preserved exactly. - **Enabled by default** for stack generation (`Opc.Ua.SourceGeneration.Stack`) - **Disabled by default** for the Roslyn source generator (`Opc.Ua.SourceGeneration`), configurable via `ModelSourceGeneratorUseTypeDefinitionModellingRules` MSBuild property ### Key design decisions - A `TypeDefinitionModellingRule` property on `HierarchyNode` captures the type definition's original rule before instance overrides, updated through base→derived type-hierarchy merges but frozen once explicit instance overrides appear - A `GetEffectiveModellingRule()` helper with `IsValidPromotion()` centralizes the rule resolution logic across all structural check sites and runtime `ModellingRuleId` emission - Factory method emission (`LoadTemplate_ReplaceChild`) uses the instance's own modelling rule for mandatory/optional list classification so children the instance marks Mandatory are always created ## Related Issues - N/A ### Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) - [x] Enhancement (non-breaking change which adds functionality) - [ ] Test enhancement (non-breaking change to increase test coverage) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages) - [ ] Documentation Update (if none of the other choices apply) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf). - [x] I ran tests locally with my changes, all passed. - [ ] I fixed all failing tests in the CI pipelines. - [ ] I fixed all introduced issues with CodeQL and LGTM. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added necessary documentation (if appropriate). - [ ] Any dependent changes have been merged and published in downstream modules. ## Further comments ### Files changed: | File | Change | |------|--------| | `Schema/ModelDesign.cs` | Added `TypeDefinitionModellingRule` property to `HierarchyNode` | | `Schema/ModelDesignValidator.cs` | Populates `TypeDefinitionModellingRule` during hierarchy merge; updates through base→derived type merges, freezes on instance overrides | | `GeneratorOptions.cs` | Added `UseTypeDefinitionModellingRules` option with full XML doc | | `NodeStateGenerator.cs` | `GetEffectiveModellingRule()` + `IsValidPromotion()` helpers; updated structural check sites and runtime `ModellingRuleId` emission; `NodeToGenerate` extended with `TypeDefinitionModellingRule` | | `StackGeneration.cs` | Enabled option for stack generation | | `ModelCompilationOptions.cs` | Added option + MSBuild property read | | `ModelCompilation.cs` | Wired option through to `GeneratorOptions` | | `OPCFoundation.Opc.Ua.SourceGeneration.props` | Registered MSBuild `CompilerVisibleProperty` | | `readme.md` | Documented new MSBuild property with promotion semantics |
160 lines
6.3 KiB
C#
160 lines
6.3 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading;
|
|
using Microsoft.CodeAnalysis;
|
|
using Microsoft.CodeAnalysis.CSharp;
|
|
using ILogger = SGF.Diagnostics.ILogger;
|
|
using SourceProductionContext = SGF.SgfSourceProductionContext;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Generates the stack core
|
|
/// </summary>
|
|
internal sealed class StackGeneration
|
|
{
|
|
/// <summary>
|
|
/// Generate stack
|
|
/// </summary>
|
|
public StackGeneration(
|
|
SourceProductionContext context,
|
|
CompilationOptions compilationOptions,
|
|
StackGenerationOptions options,
|
|
ILogger logger)
|
|
{
|
|
m_context = context;
|
|
m_options = options;
|
|
m_compilationOptions = compilationOptions;
|
|
m_telemetry = SourceGeneratorTelemetry.Create(logger, m_context);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Generate all stack files
|
|
/// </summary>
|
|
public void Emit(CancellationToken cancellationToken)
|
|
{
|
|
if (!CheckCompilationOptions(out StackGenerationType generationType))
|
|
{
|
|
return;
|
|
}
|
|
using var fileSystem = new VirtualFileSystem();
|
|
try
|
|
{
|
|
// Generate files into the virtual file system
|
|
Generators.GenerateStack(
|
|
generationType,
|
|
fileSystem,
|
|
string.Empty,
|
|
m_telemetry,
|
|
new GeneratorOptions
|
|
{
|
|
Cancellation = cancellationToken,
|
|
Exclusions = m_options.Exclude,
|
|
OptimizeForCompileSpeed =
|
|
m_compilationOptions.OptimizationLevel ==
|
|
OptimizationLevel.Debug,
|
|
// The standard NodeSet "Models" pass runs in the Opc.Ua
|
|
// (Types-only) assembly which does not reference
|
|
// ISessionClient/ObjectTypeClient. Proxies are emitted
|
|
// by the Stack pass (Opc.Ua.Core) instead.
|
|
OmitObjectTypeProxies =
|
|
generationType == StackGenerationType.Models,
|
|
UseTypeDefinitionModellingRules = true
|
|
});
|
|
// Collect all generated cs files and produce them into the compilation
|
|
foreach (string file in fileSystem.CreatedFiles
|
|
.Where(f => f.EndsWith(".cs", StringComparison.OrdinalIgnoreCase)))
|
|
{
|
|
string content = Encoding.UTF8.GetString(fileSystem.Get(file));
|
|
m_context.AddSource(file, content);
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.Exception,
|
|
Location.None,
|
|
ex.Message,
|
|
ex.StackTrace));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests the compilation options are valid
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
private bool CheckCompilationOptions(out StackGenerationType type)
|
|
{
|
|
if (m_compilationOptions.LanguageVersion < LanguageVersion.CSharp13)
|
|
{
|
|
type = StackGenerationType.None;
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.GenericError,
|
|
Location.None,
|
|
"Opc UA stack is too old. Minimum required language version is CSharp 14."));
|
|
return false;
|
|
}
|
|
|
|
// Check that we are running with opc ua core production only
|
|
switch (m_compilationOptions.AssemblyName)
|
|
{
|
|
case "Opc.Ua.Core.Types":
|
|
type = StackGenerationType.Models;
|
|
break;
|
|
case "Opc.Ua.Core":
|
|
type = StackGenerationType.Stack;
|
|
break;
|
|
case "Opc.Ua.Test":
|
|
type = StackGenerationType.All;
|
|
break;
|
|
default:
|
|
type = StackGenerationType.None;
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.GenericError,
|
|
Location.None,
|
|
$"Stack generation not supported for {m_compilationOptions.AssemblyName} assembly."));
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
private readonly SourceProductionContext m_context;
|
|
private readonly StackGenerationOptions m_options;
|
|
private readonly ITelemetryContext m_telemetry;
|
|
private readonly CompilationOptions m_compilationOptions;
|
|
}
|
|
}
|