Files
UA-.NETStandard/tests/Opc.Ua.Client.Tests/Session/ChannelManagerSessionFactoryTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

388 lines
15 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Client.Tests
{
/// <summary>
/// Deterministic unit tests for <see cref="ChannelManagerSessionFactory"/> that exercise
/// its constructor guards, diagnostics delegation, argument validation and the
/// channel-only reconnect participant without opening a real session or touching the network.
/// </summary>
[TestFixture]
[Category("Client")]
[Category("ChannelManagerSessionFactory")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
public sealed class ChannelManagerSessionFactoryTests
{
private ITelemetryContext m_telemetry;
[SetUp]
public void SetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
}
[Test]
public void ConstructorWithNullManagerThrowsArgumentNullException()
{
ArgumentNullException ex = Assert.Throws<ArgumentNullException>(() =>
new ChannelManagerSessionFactory(null!, m_telemetry));
Assert.That(ex.ParamName, Is.EqualTo("manager"));
}
[Test]
public void ConstructorWithNullTelemetryThrowsArgumentNullException()
{
var manager = new Mock<IClientChannelManager>();
ArgumentNullException ex = Assert.Throws<ArgumentNullException>(() =>
new ChannelManagerSessionFactory(manager.Object, null!));
Assert.That(ex.ParamName, Is.EqualTo("telemetry"));
}
[Test]
public void ConstructorStoresTelemetry()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
Assert.That(factory.Telemetry, Is.SameAs(m_telemetry));
}
[Test]
public void WithSubscriptionEngineReturnsAConfiguredCopyAndLeavesTheOriginal()
{
var manager = new Mock<IClientChannelManager>();
var registry = new Mock<ISecurityPolicyRegistry>().Object;
var original = new ChannelManagerSessionFactory(
manager.Object,
m_telemetry,
DiagnosticsMasks.All,
securityPolicies: registry);
ISubscriptionEngineFactory engine = new Mock<ISubscriptionEngineFactory>().Object;
ISessionFactory copy = original.WithSubscriptionEngine(engine);
Assert.That(copy, Is.TypeOf<ChannelManagerSessionFactory>());
Assert.That(copy, Is.Not.SameAs(original));
Assert.That(copy.SubscriptionEngineFactory, Is.SameAs(engine));
Assert.That(copy.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.All));
Assert.That(copy.Telemetry, Is.SameAs(m_telemetry));
Assert.That(((ChannelManagerSessionFactory)copy).SecurityPolicyRegistry, Is.SameAs(registry));
Assert.That(original.SubscriptionEngineFactory, Is.Null);
}
[Test]
public void ReturnDiagnosticsDefaultsToNone()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
Assert.That(factory.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.None));
}
[Test]
public void ConstructorAppliesReturnDiagnostics()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(
manager.Object,
m_telemetry,
DiagnosticsMasks.All);
Assert.That(factory.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.All));
}
[Test]
public void ReturnDiagnosticsSetterUpdatesValue()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry)
{
ReturnDiagnostics = DiagnosticsMasks.ServiceSymbolicId
};
Assert.That(factory.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.ServiceSymbolicId));
factory.ReturnDiagnostics = DiagnosticsMasks.All;
Assert.That(factory.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.All));
}
[Test]
public void ConstructorAcceptsTimeProvider()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(
manager.Object,
m_telemetry,
DiagnosticsMasks.SymbolicId,
TimeProvider.System);
Assert.That(factory.Telemetry, Is.SameAs(m_telemetry));
Assert.That(factory.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.SymbolicId));
}
[Test]
public async Task CreateChannelAsyncReturnsChannelFromManagerAsync()
{
var channel = new Mock<IManagedTransportChannel>();
var manager = new Mock<IClientChannelManager>();
manager
.Setup(m => m.GetAsync(
It.IsAny<ConfiguredEndpoint>(),
It.IsAny<Func<IManagedTransportChannel, IReconnectParticipant>>(),
It.IsAny<ITransportWaitingConnection>(),
It.IsAny<CancellationToken>()))
.Returns(() => new ValueTask<IManagedTransportChannel>(channel.Object));
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ConfiguredEndpoint endpoint = CreateEndpoint();
ITransportChannel result = await factory.CreateChannelAsync(
CreateConfiguration(),
null,
endpoint,
updateBeforeConnect: false,
checkDomain: false,
CancellationToken.None).ConfigureAwait(false);
Assert.That(result, Is.SameAs(channel.Object));
Assert.That(endpoint.UpdateBeforeConnect, Is.False);
Assert.That(endpoint.Configuration, Is.Not.Null);
manager.Verify(
m => m.GetAsync(
endpoint,
It.IsAny<Func<IManagedTransportChannel, IReconnectParticipant>>(),
It.IsAny<ITransportWaitingConnection>(),
It.IsAny<CancellationToken>()),
Times.Once);
}
[Test]
public async Task CreateChannelAsyncWithConnectionKeepsUpdateBeforeConnectAsync()
{
var channel = new Mock<IManagedTransportChannel>();
var connection = new Mock<ITransportWaitingConnection>();
var manager = new Mock<IClientChannelManager>();
manager
.Setup(m => m.GetAsync(
It.IsAny<ConfiguredEndpoint>(),
It.IsAny<Func<IManagedTransportChannel, IReconnectParticipant>>(),
It.IsAny<ITransportWaitingConnection>(),
It.IsAny<CancellationToken>()))
.Returns(() => new ValueTask<IManagedTransportChannel>(channel.Object));
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ConfiguredEndpoint endpoint = CreateEndpoint();
ITransportChannel result = await factory.CreateChannelAsync(
CreateConfiguration(),
connection.Object,
endpoint,
updateBeforeConnect: true,
checkDomain: false,
CancellationToken.None).ConfigureAwait(false);
Assert.That(result, Is.SameAs(channel.Object));
Assert.That(endpoint.UpdateBeforeConnect, Is.True);
}
[Test]
public void CreateChannelAsyncWithNullConfigurationThrowsArgumentNullException()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ConfiguredEndpoint endpoint = CreateEndpoint();
ArgumentNullException ex = Assert.ThrowsAsync<ArgumentNullException>(async () =>
await factory.CreateChannelAsync(
null!,
null,
endpoint,
updateBeforeConnect: false,
checkDomain: false,
CancellationToken.None).ConfigureAwait(false));
Assert.That(ex.ParamName, Is.EqualTo("configuration"));
}
[Test]
public void CreateChannelAsyncWithNullEndpointThrowsArgumentNullException()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ArgumentNullException ex = Assert.ThrowsAsync<ArgumentNullException>(async () =>
await factory.CreateChannelAsync(
CreateConfiguration(),
null,
null!,
updateBeforeConnect: false,
checkDomain: false,
CancellationToken.None).ConfigureAwait(false));
Assert.That(ex.ParamName, Is.EqualTo("endpoint"));
}
[Test]
public void CreateAsyncReverseConnectWithNullEndpointThrowsArgumentNullException()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ArgumentNullException ex = Assert.ThrowsAsync<ArgumentNullException>(async () =>
await factory.CreateAsync(
CreateConfiguration(),
(ReverseConnectManager)null!,
null!,
updateBeforeConnect: false,
checkDomain: false,
"TestSession",
30000u,
null,
default,
CancellationToken.None).ConfigureAwait(false));
Assert.That(ex.ParamName, Is.EqualTo("endpoint"));
}
[Test]
public void CreateAsyncReverseConnectWithNullManagerDelegatesToPlainPath()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ArgumentNullException ex = Assert.ThrowsAsync<ArgumentNullException>(async () =>
await factory.CreateAsync(
null!,
(ReverseConnectManager)null!,
CreateEndpoint(),
updateBeforeConnect: false,
checkDomain: false,
"TestSession",
30000u,
null,
default,
CancellationToken.None).ConfigureAwait(false));
Assert.That(ex.ParamName, Is.EqualTo("configuration"));
}
[Test]
public void RecreateAsyncWithNullTemplateDelegatesToInnerFactory()
{
var manager = new Mock<IClientChannelManager>();
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ArgumentException ex = Assert.ThrowsAsync<ArgumentException>(async () =>
await factory.RecreateAsync(null!, CancellationToken.None).ConfigureAwait(false));
Assert.That(ex.ParamName, Is.EqualTo("sessionTemplate"));
}
[Test]
public async Task CreateChannelAsyncBindsChannelOnlyReconnectParticipantAsync()
{
var channel = new Mock<IManagedTransportChannel>();
var manager = new Mock<IClientChannelManager>();
IReconnectParticipant? capturedParticipant = null;
manager
.Setup(m => m.GetAsync(
It.IsAny<ConfiguredEndpoint>(),
It.IsAny<Func<IManagedTransportChannel, IReconnectParticipant>>(),
It.IsAny<ITransportWaitingConnection>(),
It.IsAny<CancellationToken>()))
.Returns((
ConfiguredEndpoint endpoint,
Func<IManagedTransportChannel, IReconnectParticipant> participantFactory,
ITransportWaitingConnection connection,
CancellationToken ct) =>
{
capturedParticipant = participantFactory(channel.Object);
return new ValueTask<IManagedTransportChannel>(channel.Object);
});
var factory = new ChannelManagerSessionFactory(manager.Object, m_telemetry);
ConfiguredEndpoint configuredEndpoint = CreateEndpoint();
await factory.CreateChannelAsync(
CreateConfiguration(),
null,
configuredEndpoint,
updateBeforeConnect: false,
checkDomain: false,
CancellationToken.None).ConfigureAwait(false);
Assert.That(capturedParticipant, Is.Not.Null);
Assert.That(capturedParticipant.Id, Does.StartWith("ChannelManagerSessionFactory-"));
Assert.That(capturedParticipant.Endpoint, Is.SameAs(configuredEndpoint));
ParticipantReconnectResult reconnectResult = await capturedParticipant
.OnReconnectAsync(channel.Object, 0, CancellationToken.None)
.ConfigureAwait(false);
Assert.That(reconnectResult, Is.EqualTo(ParticipantReconnectResult.Reactivated));
}
private static ConfiguredEndpoint CreateEndpoint()
{
return new ConfiguredEndpoint(null!, new EndpointDescription
{
EndpointUrl = "opc.tcp://localhost:4840",
SecurityMode = MessageSecurityMode.None,
SecurityPolicyUri = SecurityPolicies.None
});
}
private ApplicationConfiguration CreateConfiguration()
{
return new ApplicationConfiguration(m_telemetry)
{
ClientConfiguration = new ClientConfiguration()
};
}
}
}