mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-29 15:11:53 +08:00
# Description Remove stock phrasing and correct misleading or inconsistent technical documentation. The initial two passes covered 367 Markdown files, followed by an interactive review of 169 editorial flags. The U5 interpretation originally deferred in that review has since received the upstream Mantis answer recorded by #4843; remaining server/spec follow-ups stay explicit in the CTT log. - Correct package responsibilities, migration steps, API names, ownership, protocol descriptions and links. Keep bundled migration guides synchronized. Preserve historical conclusions as historical records with separate re-check notes. - Provide at least two rendered TOC levels throughout `docs/`. Convert appropriate architecture figures to Mermaid without changing code examples, transcripts or historical quotations. - Address the October 19 feedback with concrete setup/migration instructions, corrected certificate paths and PubSub names, shorter repeated caveats, consistent XML comments, and a full review of the Concepts guide. Retain #4839's API corrections. - Integrate #4841's runtime/performance guidance and review incoming/recent prose. Preserve dated measurements rather than claiming new benchmark runs; clarify allocation ratios, startup-only processor settings, JIT warm-up and the benchmark commit's scope. Missing raw measurement artifacts and repeat ranges remain tracked by #4842. - Merge master through `e8c5d800a` in `32c6394b7`. Resolve the CTT log conflict using the updated Mantis states and OPC answers, retaining historical framing and re-checks for C28/C32/C43. - Address the latest naming/index feedback in `adb5bf693`: rename the guides to `docs/WotCon.md` and `docs/WotNodeSetConversion.md`; move the provider and DataType-declaration contracts into the conversion guide and remove `docs/WoT.md`. Rename `samples/DI` to `samples/Di` and `samples/Isa95` to `samples/ISA95`. Add content-index READMEs to Di, FluentApi, ISA95, Lds and PubSub; update solution entries, project references, Docker/CI paths, test fixture paths and documentation links with exact casing. **WoT guide scope.** This branch retains the detailed conversion guide that #4758 had replaced with an anchor stub. Conversion limits, verified document sets, preservation rules and provider ownership now live together in `WotNodeSetConversion.md`; binding/runtime guidance remains in `WotBindings.md` and `WotCon.md`. The design-rationale/test-ledger prose was shortened, the oversized argument-table cell moved into its section, and existing anchors preserved. **SDK policy is a separate, explicit user-directed change.** `global.json` sets a stable minimum of `10.0.400`, `rollForward: latestMajor`, and `allowPrerelease: false`. Newer major SDKs are permitted; CI's explicit SDK pins are unchanged. README, GettingStarted, DeveloperGuide and Recycling instructions reflect the possible analyzer differences. The image-contract regression fix accepts compatible stable SDK images instead of requiring exact equality with the floor. The latest four rename/index threads are resolved after publication. Three older threads remain open: universal obsolete-removal timing, unconditional nonce-strength wording, and a blanket Vision NativeAOT claim. Existing implementation/evidence constraints are explained in their inline replies. The two-level TOCs remain as requested. ## Validation - `git diff --check` and staged diff checks: passed. The untouched upstream AutoID NodeSet retains its provenance bytes, including two existing license-header trailing spaces. - `.\.azurepipelines\validate-migration-plugin.ps1`: passed; 15 bundled migration documents and manifests synchronized. - Documentation/path validation: **101** documents retain two rendered TOC levels (**2,228** entries), with idempotent formatting. **52** new relative links and their anchors passed exact-case checks. No tracked references to the old guide/sample paths remain. Both relocated provider-contract sections are preserved in the destination. - `dotnet sln UA.slnx list`: passed; shows the renamed Di/ISA95 projects and the existing FluentApi/Lds/PubSub projects. Updated solution and pump ProjectReference paths also passed exact-case existence checks. - Latest focused commands, run from the repository root: ```powershell # Passed: 61 channel send-order and reconnect tests. dotnet test tests\Opc.Ua.Core.Tests\Opc.Ua.Core.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~UaSCBinaryChannelSendOrderTests|FullyQualifiedName~TcpReconnectKeyAgreementTests' --verbosity minimal # Passed: 5 pump datasheet tests; builds the renamed pump sample. dotnet test tests\Opc.Ua.Di.Tests\Opc.Ua.Di.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~PumpDatasheetConformanceTests' --verbosity minimal # Passed: 4 repository NodeSet path/round-trip tests, including the moved pump models. dotnet test tests\Opc.Ua.Types.Tests\Opc.Ua.Types.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~RepositorySourceSurvivesSerializedLinkedPartitionsAsync' --verbosity minimal # Passed: build, zero warnings/errors. dotnet build samples\ISA95\MinimalIsa95Server\MinimalIsa95Server.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal # Passed: dependent sample-test project build, zero warnings/errors. dotnet build tests\Opc.Ua.WotCon.Samples.Tests\Opc.Ua.WotCon.Samples.Tests.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal ``` Earlier focused integration checks passed 2,620 tests across AutoID, event queues/scheduling, source generation, MCP/package profiles and WoT. Both reviewed Mermaid diagrams rendered locally without network access. These checks are not a full solution run. The full solution has **not** been rerun for this review. Earlier `dotnet test UA.slnx -p:CustomTestTarget=net10.0 --verbosity quiet` did not pass: three AOT projects rejected VSTest and 20 Vision tests failed during graphics initialization with `OutOfMemoryException`. Remaining long-running tests were stopped at the user's request. A focused Vision rerun passed 558 tests and reproduced those 20 failures. The earlier `dotnet test UA.slnx -p:CustomTestTarget=net48 --verbosity quiet` was blocked by the former SDK pin and was not retried after the policy change. The user approved proceeding with those limitations documented; current remote CI is not claimed green. ## Related Issues - Follow-up #4842 tracks the requested 2.0.2+ benchmark/tuning and diagnostic-tool documentation refresh. #4841 supplies documentation and earlier results, not all newly requested measurements. - #4758 explains the conversion guide's earlier consolidation; the current provider contracts are now consolidated into `WotNodeSetConversion.md`. - #4839 supplies the reviewed API corrections; #4843 supplies the updated CTT issue record. - The original prose cleanup and SDK policy were user-requested without a source issue. No new runtime architecture is introduced by these documentation edits. ## Checklist _Put an `x` in the boxes that apply. You can complete these step by step after opening the PR._ - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [ ] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. --------- Co-authored-by: Roman Ettlinger <romanett98@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
463 lines
22 KiB
YAML
463 lines
22 KiB
YAML
name: Images CI
|
|
|
|
on:
|
|
push:
|
|
branches: [ master, release/*, docker* ]
|
|
# No paths-ignore here either: every push to master or release/* must
|
|
# report `images summary`, which the Release ruleset requires before a
|
|
# release branch can be cut from that commit. The discover job skips the
|
|
# image builds for documentation- or test-only pushes instead.
|
|
pull_request:
|
|
branches: [ master, main, master378, develop/*, release/* ]
|
|
# NOTE: deliberately no `paths-ignore` filter, and the same branch list as
|
|
# the `CI` workflow so both gates report on exactly the same pull requests.
|
|
# A workflow that is filtered out by `paths`/`paths-ignore` never reports
|
|
# its checks at all, and a required status check that never reports leaves
|
|
# a pull request permanently "Expected — waiting for status to be
|
|
# reported". `images summary` below is designed to be that required check,
|
|
# so this workflow has to trigger on every pull request. The docs/tests
|
|
# exclusion is applied inside the `discover` job instead, which skips the
|
|
# expensive image builds while still letting the summary report.
|
|
# Rebuild and republish every image on demand, for example after a base
|
|
# image security update that changes nothing in this repository.
|
|
workflow_dispatch:
|
|
|
|
# Pull requests and feature branches cancel a superseded run: only the newest
|
|
# commit's result matters there. A push to a protected line (master, main,
|
|
# master378, release/*) never cancels, and each commit gets its own group,
|
|
# because a queued run in a shared group is replaced as well as a running one
|
|
# being cancelled. Every protected commit therefore finishes its required
|
|
# checks ('build-and-test summary', 'images summary'), which the Release
|
|
# ruleset demands before a release/<major>.<minor> branch can be cut from it.
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || ((github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master378' || startsWith(github.ref, 'refs/heads/release/')) && github.sha) || github.ref }}
|
|
cancel-in-progress: ${{ github.event_name == 'pull_request' || !(github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master378' || startsWith(github.ref, 'refs/heads/release/')) }}
|
|
|
|
env:
|
|
REGISTRY: ghcr.io
|
|
DOCKERSIGN: false
|
|
# Every published sample image. `publish-samples` compiles each project
|
|
# once, natively, and `build-and-push-image` runs one leg per entry that
|
|
# only copies the published output into the multi-platform image.
|
|
IMAGES: >-
|
|
[
|
|
{"image": "refserver", "project": "samples/Reference/ConsoleReferenceServer/ConsoleReferenceServer.csproj", "dockerfile": "./samples/Reference/ConsoleReferenceServer/Dockerfile"},
|
|
{"image": "ldsserver", "project": "samples/Lds/ConsoleLdsServer/ConsoleLdsServer.csproj", "dockerfile": "./samples/Lds/ConsoleLdsServer/Dockerfile"},
|
|
{"image": "boilerserver", "project": "samples/MinimalApi/MinimalBoilerServer/MinimalBoilerServer.csproj", "dockerfile": "./samples/MinimalApi/MinimalBoilerServer/Dockerfile"},
|
|
{"image": "calcserver", "project": "samples/MinimalApi/MinimalCalcServer/MinimalCalcServer.csproj", "dockerfile": "./samples/MinimalApi/MinimalCalcServer/Dockerfile"},
|
|
{"image": "mcpserver", "project": "tools/Opc.Ua.Mcp/Opc.Ua.Mcp.csproj", "dockerfile": "./tools/Opc.Ua.Mcp/Dockerfile"},
|
|
{"image": "redundantserver", "project": "samples/Redundancy/RedundantServer/RedundantServer.csproj", "dockerfile": "./samples/Redundancy/RedundantServer/Dockerfile"},
|
|
{"image": "pumpserver", "project": "samples/Di/PumpDeviceIntegrationServer/PumpDeviceIntegrationServer.csproj", "dockerfile": "./samples/Di/PumpDeviceIntegrationServer/Dockerfile"},
|
|
{"image": "redundantclient", "project": "samples/Redundancy/RedundantClient/RedundantClient.csproj", "dockerfile": "./samples/Redundancy/RedundantClient/Dockerfile"},
|
|
{"image": "redundantpubsub", "project": "samples/Redundancy/RedundantPubSub/RedundantPubSub.csproj", "dockerfile": "./samples/Redundancy/RedundantPubSub/Dockerfile"},
|
|
{"image": "pubsubclient", "project": "samples/PubSub/ConsoleReferencePubSubClient/ConsoleReferencePubSubClient.csproj", "dockerfile": "./samples/PubSub/ConsoleReferencePubSubClient/Dockerfile"},
|
|
{"image": "recyclingserver", "project": "samples/Recycling/RecyclingServer/RecyclingServer.csproj", "dockerfile": "./samples/Recycling/RecyclingServer/Dockerfile"},
|
|
{"image": "recyclingclient", "project": "samples/Recycling/RecyclingOperatorConsole/RecyclingOperatorConsole.csproj", "dockerfile": "./samples/Recycling/RecyclingOperatorConsole/Dockerfile"}
|
|
]
|
|
|
|
jobs:
|
|
discover:
|
|
name: Discover image changes
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
outputs:
|
|
relevant_changes: ${{ steps.relevance.outputs.relevant_changes }}
|
|
images: ${{ steps.images.outputs.images }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
# Full history so the path-relevance check below can diff a pull
|
|
# request against its merge base.
|
|
fetch-depth: 0
|
|
- name: Resolve path relevance
|
|
id: relevance
|
|
shell: pwsh
|
|
env:
|
|
EVENT_NAME: ${{ github.event_name }}
|
|
BASE_SHA: ${{ github.event.pull_request.base.sha }}
|
|
BEFORE_SHA: ${{ github.event.before }}
|
|
run: |
|
|
# Reproduces the `paths-ignore` allow-list that used to sit on both
|
|
# triggers: an image is rebuilt for any change that is not purely
|
|
# documentation or test code. Filtering the whole workflow out would
|
|
# stop `images summary` from ever reporting, which would block every
|
|
# documentation-only pull request, and every documentation-only push
|
|
# as a release-branch cut point, since the check is required.
|
|
$relevantChanges = $true
|
|
$range = $null
|
|
if ($env:EVENT_NAME -eq 'pull_request' -and -not [string]::IsNullOrWhiteSpace($env:BASE_SHA)) {
|
|
# Triple-dot: diff from the merge base, not from the current base
|
|
# branch head, so a change that landed on the base branch after
|
|
# this one was cut is not misread as an image-relevant change.
|
|
$range = "$($env:BASE_SHA)...HEAD"
|
|
}
|
|
elseif ($env:EVENT_NAME -eq 'push' -and $env:BEFORE_SHA -match '^[0-9a-f]{40}$' -and
|
|
$env:BEFORE_SHA -notmatch '^0+$') {
|
|
# A new branch has an all-zero 'before', and a force push can name
|
|
# a commit this clone does not have: build everything in both cases
|
|
# rather than guess what changed.
|
|
& git cat-file -e "$($env:BEFORE_SHA)^{commit}" 2>$null
|
|
if ($LASTEXITCODE -eq 0) {
|
|
$range = "$($env:BEFORE_SHA)..HEAD"
|
|
}
|
|
}
|
|
if ($range) {
|
|
$changed = @(& git diff --name-only $range)
|
|
if ($LASTEXITCODE -ne 0) {
|
|
throw (
|
|
"Could not diff '$range' (git exit code $LASTEXITCODE). " +
|
|
'Refusing to skip required image builds.')
|
|
}
|
|
$relevantChanges = $false
|
|
foreach ($file in $changed) {
|
|
if ($file -like 'docs/*' -or $file -like 'tests/*') {
|
|
continue
|
|
}
|
|
$relevantChanges = $true
|
|
break
|
|
}
|
|
Write-Host "Changed files: $(@($changed).Count); image-relevant: $relevantChanges"
|
|
}
|
|
"relevant_changes=$($relevantChanges.ToString().ToLowerInvariant())" |
|
|
Out-File -FilePath $env:GITHUB_OUTPUT -Append
|
|
- name: Resolve image matrix
|
|
id: images
|
|
shell: pwsh
|
|
run: |
|
|
$images = @($env:IMAGES | ConvertFrom-Json)
|
|
"images=$(ConvertTo-Json -InputObject $images -Compress)" |
|
|
Out-File -FilePath $env:GITHUB_OUTPUT -Append
|
|
|
|
publish-samples:
|
|
# Compiles every sample once, natively on the x64 runner. The output is
|
|
# framework-dependent portable IL (no runtime identifier, no app host), so
|
|
# the same files serve linux/amd64 and linux/arm64. Compiling inside the
|
|
# image build instead ran the SDK for arm64 under QEMU emulation, which
|
|
# took over an hour per image.
|
|
name: Publish sample applications
|
|
needs: discover
|
|
if: ${{ needs.discover.outputs.relevant_changes == 'true' }}
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up .NET 10
|
|
uses: actions/setup-dotnet@v6
|
|
with:
|
|
dotnet-version: '10.0.402'
|
|
|
|
- name: Set Version
|
|
shell: pwsh
|
|
run: ./.azurepipelines/set-version.ps1
|
|
|
|
- name: Publish samples
|
|
shell: pwsh
|
|
run: |
|
|
# The same options the Dockerfiles use when they build from source.
|
|
$options = @(
|
|
'-c', 'Release',
|
|
'-f', 'net10.0',
|
|
'-p:PublishAot=false',
|
|
'-p:UseAppHost=false',
|
|
'-p:CustomTestTarget=net10.0',
|
|
'-p:Dockerbuild=true',
|
|
"-p:Version=$env:NBGV_Version",
|
|
"-p:AssemblyVersion=$env:NBGV_SimpleVersion",
|
|
"-p:FileVersion=$env:NBGV_Version",
|
|
"-p:InformationalVersion=$env:NBGV_AssemblyInformationalVersion")
|
|
foreach ($entry in @($env:IMAGES | ConvertFrom-Json)) {
|
|
Write-Host "::group::$($entry.image) ($($entry.project))"
|
|
& dotnet publish $entry.project @options -o "artifacts/docker/publish/$($entry.image)"
|
|
$exitCode = $LASTEXITCODE
|
|
Write-Host '::endgroup::'
|
|
if ($exitCode -ne 0) {
|
|
throw "Publishing $($entry.project) failed (exit code $exitCode)."
|
|
}
|
|
}
|
|
|
|
- name: Upload published samples
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: docker-publish
|
|
path: artifacts/docker/publish
|
|
if-no-files-found: error
|
|
retention-days: 1
|
|
|
|
build-and-push-image:
|
|
name: build-and-push-image (${{ matrix.image }})
|
|
needs:
|
|
- discover
|
|
- publish-samples
|
|
# Skipped rather than filtered out when nothing image-relevant changed, so
|
|
# the summary below still reports a result.
|
|
if: ${{ needs.discover.outputs.relevant_changes == 'true' }}
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include: ${{ fromJSON(needs.discover.outputs.images) }}
|
|
env:
|
|
IMAGE_NAME: ${{ matrix.image }}
|
|
IS_NOT_PR: ${{ !github.head_ref && true }}
|
|
permissions:
|
|
contents: read
|
|
packages: write
|
|
# This is used to complete the identity challenge
|
|
# with sigstore/fulcio when running outside of PRs.
|
|
id-token: write
|
|
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up .NET 10
|
|
uses: actions/setup-dotnet@v6
|
|
with:
|
|
dotnet-version: '10.0.402'
|
|
|
|
- name: Set Version
|
|
shell: pwsh
|
|
run: ./.azurepipelines/set-version.ps1
|
|
|
|
# Install the cosign tool except on PR
|
|
# https://github.com/sigstore/cosign-installer
|
|
- name: Install cosign
|
|
if: github.event_name != 'pull_request' && env.DOCKERSIGN == 'true'
|
|
uses: sigstore/cosign-installer@main
|
|
with:
|
|
cosign-release: 'v1.13.1'
|
|
|
|
# https://github.com/docker/build-push-action
|
|
- name: Setup Docker buildx
|
|
uses: docker/setup-buildx-action@v4
|
|
|
|
# Login against a Docker registry except on PR
|
|
# https://github.com/docker/login-action
|
|
- name: Log into registry ${{ env.REGISTRY }}
|
|
if: github.event_name != 'pull_request'
|
|
uses: docker/login-action@v4
|
|
with:
|
|
registry: ${{ env.REGISTRY }}
|
|
username: ${{ github.actor }}
|
|
password: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Prepare Tag Repo Info
|
|
env:
|
|
# Same rule as the ref below: pass values into the script as data
|
|
# rather than interpolating them into its source.
|
|
SOURCE_REPOSITORY: ${{ github.repository }}
|
|
run: |
|
|
set -euo pipefail
|
|
repository=$(printf '%s' "$SOURCE_REPOSITORY" \
|
|
| tr '[:upper:]' '[:lower:]' \
|
|
| awk '{gsub(/-|\./, "")}1')
|
|
echo "IMAGE_REPOSITORY=${REGISTRY}/${repository}/${IMAGE_NAME}" >> "$GITHUB_ENV"
|
|
# Use NBGV's canonical NuGet SemVer rather than NBGV_Version, whose
|
|
# fourth component is a git-height build number. Stable image tags
|
|
# must align with the explicit M.m.p package release version.
|
|
#
|
|
# Strip any "+<metadata>" before the value becomes a tag: '+' is not
|
|
# a legal Docker tag character, so build-push-action would fail on it.
|
|
# With version.json's current "nugetPackageVersion.semVer: 2" NBGV
|
|
# already folds the commit id into a prerelease segment instead
|
|
# (measured on nbgv 3.7.115: "2.0.0-preview.24.gd602b190a4", no '+'),
|
|
# so this is a no-op today and exists so a version.json change cannot
|
|
# silently break every image build.
|
|
version="${NBGV_NuGetPackageVersion%%+*}"
|
|
# Fail closed on anything else a tag may not contain, rather than
|
|
# letting the registry reject the push after the whole image is built.
|
|
if ! printf '%s' "$version" | grep -Eq '^[A-Za-z0-9_][A-Za-z0-9._-]{0,127}$'; then
|
|
echo "Version '${NBGV_NuGetPackageVersion}' does not yield a usable Docker tag." >&2
|
|
exit 1
|
|
fi
|
|
echo "IMAGE_VERSION=${version}" >> "$GITHUB_ENV"
|
|
|
|
- name: Prepare Tag Branch info
|
|
# Append a branch-derived suffix to the version/"latest" tags for
|
|
# every build that is not an exact stable release - not just a
|
|
# non-public-release build. NBGV_PublicRelease is true for the whole
|
|
# duration a canonical release/<major>.<minor> branch is eligible to
|
|
# publish, including every commit while it is still stabilizing the
|
|
# next patch (e.g. "2.0.1-preview.3"); without this, an in-progress
|
|
# release-branch commit would overwrite the global "latest" image tag
|
|
# before the release is actually approved. Only the exact stable
|
|
# commit (NBGV_PrereleaseVersion empty) skips the suffix. See
|
|
# docs/ReleaseProcess.md.
|
|
if: env.NBGV_PublicRelease == 'False' || env.NBGV_PrereleaseVersion != ''
|
|
env:
|
|
# Never interpolate github.ref into the script body: a ref is
|
|
# attacker-influenced text and git permits shell metacharacters such
|
|
# as ';', '$', '`' and quotes in a branch name, which would execute
|
|
# here. Pass it as data and transform the quoted variable instead.
|
|
SOURCE_REF: ${{ github.ref }}
|
|
run: |
|
|
set -euo pipefail
|
|
# Strip "refs/heads/" (two slash-terminated segments) and reduce the
|
|
# remainder to the characters a Docker tag may contain, so neither the
|
|
# later tag-assembly steps nor the registry can receive anything else.
|
|
suffix=$(printf '%s' "$SOURCE_REF" \
|
|
| tr '[:upper:]' '[:lower:]' \
|
|
| awk '{sub(/([^\/]*\/){2}/,""); gsub(/\/|_/, "-"); gsub(/[^a-z0-9.-]/, "-")}1')
|
|
if [ -z "$suffix" ]; then
|
|
echo "Unable to derive an image tag suffix from '$SOURCE_REF'." >&2
|
|
exit 1
|
|
fi
|
|
echo "IMAGE_TAG=-${suffix}" >> "$GITHUB_ENV"
|
|
|
|
- name: Determine release line precedence
|
|
# Only the newest canonical release/<major>.<minor> line may move the
|
|
# unqualified ":latest" and ":release" aliases. Without this, a later
|
|
# 2.0.x maintenance release would drag both aliases back to the older
|
|
# minor after 2.1.x had already published, contradicting the guarantee
|
|
# in docs/ReleaseProcess.md that older maintenance lines cannot move
|
|
# them backwards. Fails closed: if the newest line cannot be
|
|
# determined, this build is treated as a superseded line and only
|
|
# publishes line-specific aliases.
|
|
if: ${{ env.NBGV_PublicRelease == 'True' && env.NBGV_PrereleaseVersion == '' && env.IS_NOT_PR == 'true' }}
|
|
run: |
|
|
set -euo pipefail
|
|
highest=$(git ls-remote --heads origin 'refs/heads/release/*' \
|
|
| sed -E 's#.*refs/heads/release/##' \
|
|
| grep -E '^[0-9]+\.[0-9]+$' \
|
|
| sort -t. -k1,1n -k2,2n \
|
|
| tail -n1 || true)
|
|
echo "Newest canonical release line: '${highest:-<none>}'; this build: '${NBGV_MajorMinorVersion}'"
|
|
if [ -n "$highest" ] && [ "$highest" = "${NBGV_MajorMinorVersion}" ]; then
|
|
echo "IS_NEWEST_RELEASE_LINE=true" >> "$GITHUB_ENV"
|
|
else
|
|
echo "IS_NEWEST_RELEASE_LINE=false" >> "$GITHUB_ENV"
|
|
fi
|
|
|
|
- name: Prepare version and latest tag
|
|
run: |
|
|
set -euo pipefail
|
|
echo "TAG_BRANCH=${IMAGE_REPOSITORY}:${IMAGE_VERSION}${IMAGE_TAG:-}" >> "$GITHUB_ENV"
|
|
latest_suffix="${IMAGE_TAG:-}"
|
|
if [ "${IS_NEWEST_RELEASE_LINE:-}" = "false" ]; then
|
|
# Stable release on a superseded maintenance line: leave ":latest"
|
|
# on the newest line and publish a line-specific alias instead.
|
|
latest_suffix="-${NBGV_MajorMinorVersion}"
|
|
fi
|
|
echo "TAG_LATEST=${IMAGE_REPOSITORY}:latest${latest_suffix}" >> "$GITHUB_ENV"
|
|
|
|
- name: Prepare Release tags
|
|
if: ${{ env.NBGV_PublicRelease == 'True' && env.NBGV_PrereleaseVersion == '' && env.IS_NOT_PR == 'true' }}
|
|
run: |
|
|
set -euo pipefail
|
|
# Every release line keeps its exact version and major.minor tags;
|
|
# only the newest line also claims the unqualified ":release" alias.
|
|
tags=",${IMAGE_REPOSITORY}:${NBGV_MajorMinorVersion},${IMAGE_REPOSITORY}:${NBGV_SimpleVersion}"
|
|
if [ "${IS_NEWEST_RELEASE_LINE:-}" = "true" ]; then
|
|
tags="${tags},${IMAGE_REPOSITORY}:release"
|
|
fi
|
|
echo "TAG_RELEASE=${tags}" >> "$GITHUB_ENV"
|
|
|
|
# Extract metadata (tags, labels) for Docker
|
|
# https://github.com/docker/metadata-action
|
|
- name: Extract Docker metadata
|
|
id: meta
|
|
uses: docker/metadata-action@v6
|
|
with:
|
|
images: ${{ env.IMAGE_REPOSITORY }}
|
|
|
|
- name: Download published samples
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: docker-publish
|
|
path: artifacts/docker/publish
|
|
|
|
# Build and push Docker image with Buildx (don't push on PR)
|
|
# https://github.com/docker/build-push-action
|
|
# The "prebuilt" stage only copies the output of publish-samples into the
|
|
# runtime base image, so no instruction runs for a foreign platform and
|
|
# QEMU is not needed for the arm64 image.
|
|
- name: Build and push Docker image
|
|
id: build-and-push
|
|
uses: docker/build-push-action@v7
|
|
with:
|
|
context: .
|
|
build-args: |
|
|
PUBLISH_SOURCE=prebuilt
|
|
PUBLISH_DIR=artifacts/docker/publish/${{ matrix.image }}
|
|
push: ${{ github.event_name != 'pull_request' }}
|
|
tags: ${{ env.TAG_BRANCH }},${{ env.TAG_LATEST }}${{ env.TAG_RELEASE }}
|
|
platforms: linux/amd64,linux/arm64/v8
|
|
file: ${{ matrix.dockerfile }}
|
|
labels: ${{ steps.meta.outputs.labels }}
|
|
provenance: false
|
|
cache-from: type=gha,scope=${{ matrix.image }}
|
|
# setup-buildx-action@v4 installs Buildx and BuildKit versions that support ignore-error.
|
|
cache-to: type=gha,mode=max,scope=${{ matrix.image }},ignore-error=true
|
|
|
|
# Sign the resulting Docker image digest except on PRs.
|
|
# https://github.com/sigstore/cosign
|
|
- name: Sign the published Docker image
|
|
if: github.event_name != 'pull_request' && env.DOCKERSIGN == 'true'
|
|
env:
|
|
COSIGN_EXPERIMENTAL: "true"
|
|
# This step uses the identity token to provision an ephemeral certificate
|
|
# against the sigstore community Fulcio instance.
|
|
run: |
|
|
echo Signing ${{ env.IMAGE_REPOSITORY }}@${{ steps.build-and-push.outputs.digest }}
|
|
echo "${{ env.IMAGE_REPOSITORY }}" | xargs -I {} cosign sign {}@${{ steps.build-and-push.outputs.digest }}
|
|
|
|
images-summary:
|
|
# The single fixed-name check for every image in the matrix above. Matrix
|
|
# job names carry their image in parentheses, so they change whenever an
|
|
# image is added or renamed and cannot be pinned in a ruleset. This job's
|
|
# name never changes, so branch protection can require `images summary`
|
|
# once and automatically cover every present and future image.
|
|
name: images summary
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
if: ${{ always() }}
|
|
needs:
|
|
- discover
|
|
- publish-samples
|
|
- build-and-push-image
|
|
steps:
|
|
- name: Evaluate job results
|
|
shell: pwsh
|
|
env:
|
|
RELEVANT_CHANGES: ${{ needs.discover.outputs.relevant_changes }}
|
|
DISCOVER_RESULT: ${{ needs.discover.result }}
|
|
PUBLISH_RESULT: ${{ needs.publish-samples.result }}
|
|
IMAGES_RESULT: ${{ needs.build-and-push-image.result }}
|
|
run: |
|
|
if ($env:RELEVANT_CHANGES -eq 'true') {
|
|
Write-Host 'This change is image-relevant; every sample image was built.'
|
|
}
|
|
else {
|
|
Write-Host 'Only documentation or test code changed; the image matrix is expected to be skipped.'
|
|
}
|
|
|
|
$results = [ordered]@{
|
|
'discover' = $env:DISCOVER_RESULT
|
|
'publish-samples' = $env:PUBLISH_RESULT
|
|
'build-and-push-image' = $env:IMAGES_RESULT
|
|
}
|
|
|
|
$bad = @()
|
|
foreach ($job in $results.GetEnumerator()) {
|
|
Write-Host "$($job.Key): $($job.Value)"
|
|
# A matrix job aggregates to 'success' only when every leg succeeded,
|
|
# so one broken image fails this gate. 'skipped' is a valid outcome -
|
|
# nothing image-relevant changed for this event.
|
|
if (@('success', 'skipped') -notcontains $job.Value) {
|
|
$bad += "$($job.Key)=$($job.Value)"
|
|
}
|
|
}
|
|
|
|
if ($bad.Count -gt 0) {
|
|
Write-Host "::error::Image builds did not succeed: $($bad -join ', ')"
|
|
exit 1
|
|
}
|
|
Write-Host 'All image builds succeeded or were intentionally skipped.'
|