mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 21:55:54 +08:00
# Description
Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).
Six commits, applied bottom-up in safety order so each batch leaves the
build green:
1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
197 hits across ~30 files; pure mechanical cleanup.
2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.
3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
Roslynator formatting (RCS0xxx) blank-line and punctuation rules.
4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.
5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.
6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
- Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.
### What this PR does **not** touch
- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.
## Related Issues
_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
---------
Co-authored-by: agent <agent@local>
573 lines
24 KiB
C#
573 lines
24 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Channels;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
using Opc.Ua.Security.Certificates;
|
|
|
|
namespace Opc.Ua.Client
|
|
{
|
|
/// <summary>
|
|
/// Automatic certificate-change handling for
|
|
/// <see cref="ManagedSession"/>. Subscribes to the application's
|
|
/// <see cref="ICertificateLifecycle.CertificateChanges"/> stream
|
|
/// (resolved via <see cref="ApplicationConfiguration.CertificateManager"/>)
|
|
/// and surfaces every observed change through the
|
|
/// <see cref="ApplicationCertificateChanged"/> event so applications
|
|
/// can implement custom rotation policies. When
|
|
/// <see cref="DisableAutoReconnectOnCertificateChange"/> is
|
|
/// <c>false</c> (the default) the manager additionally reloads the
|
|
/// instance certificate and triggers a reconnect on
|
|
/// <see cref="CertificateChangeKind.ApplicationCertificateUpdated"/>,
|
|
/// and re-runs server-certificate validation on
|
|
/// <see cref="CertificateChangeKind.TrustListUpdated"/> /
|
|
/// <see cref="CertificateChangeKind.CrlUpdated"/> so the session
|
|
/// reconnects only when the cached server cert is no longer
|
|
/// trusted under the new state. See
|
|
/// <see cref="RunRevalidationLoopAsync(CancellationToken)"/> for the debouncing /
|
|
/// single-in-flight semantics.
|
|
/// </summary>
|
|
public partial class ManagedSession
|
|
{
|
|
/// <summary>
|
|
/// When <c>false</c> (the default), the managed session
|
|
/// automatically reacts to events published by the application's
|
|
/// <see cref="CertificateManager"/>:
|
|
/// <list type="bullet">
|
|
/// <item>
|
|
/// <see cref="CertificateChangeKind.ApplicationCertificateUpdated"/>
|
|
/// — call
|
|
/// <see cref="ISession.ReloadInstanceCertificateAsync(CancellationToken)"/>
|
|
/// and trigger a reconnect so the new client cert takes
|
|
/// effect immediately rather than at the next SecurityToken
|
|
/// renewal (OPC UA Part 4 §5.5.2).
|
|
/// </item>
|
|
/// <item>
|
|
/// <see cref="CertificateChangeKind.TrustListUpdated"/> or
|
|
/// <see cref="CertificateChangeKind.CrlUpdated"/> — debounce
|
|
/// a burst of events, re-run
|
|
/// <see cref="ICertificateValidatorEx.ValidateAsync(Certificate, TrustListIdentifier, CancellationToken)"/>
|
|
/// against the cached server certificate, and reconnect
|
|
/// ONLY when the result flips from valid to invalid. The
|
|
/// debounce keeps batch trust-list updates (e.g. a new
|
|
/// server onboarded into a shared fleet) from forcing every
|
|
/// session in the process to reconnect.
|
|
/// </item>
|
|
/// </list>
|
|
/// Set this property to <c>true</c> to opt out of all automatic
|
|
/// reconnects — applications that require manual control
|
|
/// (auditing, idempotency) can subscribe to
|
|
/// <see cref="ApplicationCertificateChanged"/> and call
|
|
/// <see cref="ISession.ReloadInstanceCertificateAsync(CancellationToken)"/>
|
|
/// + <see cref="ISession.ReconnectAsync(ITransportWaitingConnection, ITransportChannel, CancellationToken)"/>
|
|
/// themselves. The <see cref="ApplicationCertificateChanged"/>
|
|
/// event still fires for diagnostics regardless of this setting.
|
|
/// </summary>
|
|
public bool DisableAutoReconnectOnCertificateChange { get; set; }
|
|
|
|
/// <summary>
|
|
/// Subscribes to
|
|
/// <see cref="ICertificateLifecycle.CertificateChanges"/> on the
|
|
/// application's <see cref="CertificateManager"/>. Safe to call
|
|
/// when no certificate manager is configured (no-op). Disposed
|
|
/// by <see cref="UnsubscribeCertificateChanges"/>.
|
|
/// </summary>
|
|
private void SubscribeCertificateChanges()
|
|
{
|
|
ICertificateLifecycle? lifecycle = m_configuration.CertificateManager;
|
|
if (lifecycle == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
m_certificateChangeSubscription?.Dispose();
|
|
m_certificateChangeSubscription = lifecycle.CertificateChanges.Subscribe(
|
|
new CertificateChangeObserver(this));
|
|
StartRevalidationLoop();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Unsubscribes from
|
|
/// <see cref="ICertificateLifecycle.CertificateChanges"/> and
|
|
/// cancels the background revalidation loop. Safe to call when
|
|
/// no subscription is active. Synchronous callers (the sync
|
|
/// <see cref="Dispose(bool)"/> path) cannot
|
|
/// await the loop's exit;
|
|
/// <see cref="StopRevalidationLoopAsync"/> handles the
|
|
/// asynchronous wait used by <c>DisposeAsync</c>.
|
|
/// </summary>
|
|
private void UnsubscribeCertificateChanges()
|
|
{
|
|
IDisposable? subscription = Interlocked.Exchange(
|
|
ref m_certificateChangeSubscription, null);
|
|
subscription?.Dispose();
|
|
CancelRevalidationLoop();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Handler invoked from the <see cref="CertificateChangeObserver"/>
|
|
/// on the certificate-manager dispatcher thread. Must NOT block
|
|
/// or allocate per-event work — the heavy lifting runs on the
|
|
/// long-lived <see cref="RunRevalidationLoopAsync(CancellationToken)"/> loop, woken
|
|
/// via <see cref="SignalRevalidation"/>.
|
|
/// </summary>
|
|
private void OnCertificateChange(CertificateChangeEvent evt)
|
|
{
|
|
if (m_disposed != 0)
|
|
{
|
|
return;
|
|
}
|
|
|
|
switch (evt.Kind)
|
|
{
|
|
case CertificateChangeKind.ApplicationCertificateUpdated:
|
|
case CertificateChangeKind.TrustListUpdated:
|
|
case CertificateChangeKind.CrlUpdated:
|
|
break;
|
|
default:
|
|
// CertificateRejected / CertificateExpiring do not
|
|
// require session-level action.
|
|
return;
|
|
}
|
|
|
|
ApplicationCertificateChanged?.Invoke(this, evt);
|
|
|
|
if (DisableAutoReconnectOnCertificateChange)
|
|
{
|
|
return;
|
|
}
|
|
|
|
switch (evt.Kind)
|
|
{
|
|
case CertificateChangeKind.ApplicationCertificateUpdated:
|
|
// Own-certificate rotation always needs reload +
|
|
// reconnect — no validation can save it. Fire-and-
|
|
// forget on the thread pool; the inner session's
|
|
// reconnect lock serialises with any in-flight
|
|
// ReconnectAsync (see HandleApplicationCertificateUpdatedAsync).
|
|
_ = Task.Run(() => HandleApplicationCertificateUpdatedAsync(evt));
|
|
break;
|
|
case CertificateChangeKind.TrustListUpdated:
|
|
case CertificateChangeKind.CrlUpdated:
|
|
// Wake the persistent revalidation loop. No Task is
|
|
// allocated here — SignalRevalidation collapses
|
|
// bursts via a bounded channel of capacity 1 with
|
|
// BoundedChannelFullMode.DropWrite.
|
|
SignalRevalidation();
|
|
break;
|
|
}
|
|
}
|
|
|
|
private async Task HandleApplicationCertificateUpdatedAsync(CertificateChangeEvent evt)
|
|
{
|
|
try
|
|
{
|
|
Session? session = m_session;
|
|
if (session == null || m_disposed != 0)
|
|
{
|
|
return;
|
|
}
|
|
|
|
// Concurrency note:
|
|
// * Session.ReloadInstanceCertificateAsync takes the
|
|
// same m_reconnectLock used by ReconnectAsync, so
|
|
// it serialises behind any in-flight reconnect /
|
|
// activate and the reload completes before the next
|
|
// reconnect starts.
|
|
// * StateMachine.TriggerReconnect locks the state-
|
|
// machine lock and is idempotent if the connection
|
|
// is already in the Reconnecting state.
|
|
// The worst case on a racy event is one extra reconnect
|
|
// attempt — benign, the next attempt picks up the new
|
|
// cert.
|
|
await session.ReloadInstanceCertificateAsync()
|
|
.ConfigureAwait(false);
|
|
|
|
StateMachine.TriggerReconnect();
|
|
|
|
m_logger.LogInformation(
|
|
"ManagedSession: requested reconnect after {Kind} on {TrustList}.",
|
|
evt.Kind,
|
|
evt.TrustList);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
m_logger.LogWarning(
|
|
ex,
|
|
"ManagedSession: failed to react to certificate change {Kind}.",
|
|
evt.Kind);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Posts a wake-up to <see cref="RunRevalidationLoopAsync(CancellationToken)"/>.
|
|
/// Allocation-free in the steady state — when a signal is
|
|
/// already pending the bounded channel silently drops the
|
|
/// duplicate, giving AutoResetEvent-like coalescing semantics.
|
|
/// </summary>
|
|
private void SignalRevalidation()
|
|
{
|
|
m_revalidationSignal.Writer.TryWrite(0);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Starts the single per-session revalidation loop. Idempotent:
|
|
/// callers may invoke from <see cref="SubscribeCertificateChanges"/>
|
|
/// even if the loop was previously started — the existing loop
|
|
/// is cancelled and replaced. The pattern mirrors
|
|
/// <see cref="StartIdentityRefreshLoop"/>.
|
|
/// </summary>
|
|
private void StartRevalidationLoop()
|
|
{
|
|
var cts = new CancellationTokenSource();
|
|
Task task = RunRevalidationLoopAsync(cts.Token);
|
|
|
|
CancellationTokenSource? previousCts;
|
|
lock (m_revalidationLock)
|
|
{
|
|
previousCts = m_revalidationCancellation;
|
|
m_revalidationCancellation = cts;
|
|
m_revalidationTask = task;
|
|
}
|
|
previousCts?.Cancel();
|
|
previousCts?.Dispose();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Cancels the revalidation loop without awaiting its exit.
|
|
/// Used by the synchronous <see cref="Dispose(bool)"/>
|
|
/// path which cannot await asynchronously. Mirrors
|
|
/// <see cref="CancelIdentityRefreshLoop"/>.
|
|
/// </summary>
|
|
private void CancelRevalidationLoop()
|
|
{
|
|
CancellationTokenSource? cts;
|
|
lock (m_revalidationLock)
|
|
{
|
|
cts = m_revalidationCancellation;
|
|
m_revalidationCancellation = null;
|
|
m_revalidationTask = null;
|
|
}
|
|
cts?.Cancel();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Cancels the revalidation loop and awaits its exit. Used by
|
|
/// <see cref="DisposeAsync"/> to guarantee the
|
|
/// loop has released the certificate manager and any in-flight
|
|
/// validation completed before the manager is torn down.
|
|
/// </summary>
|
|
private async Task StopRevalidationLoopAsync()
|
|
{
|
|
CancellationTokenSource? cts;
|
|
Task? task;
|
|
lock (m_revalidationLock)
|
|
{
|
|
cts = m_revalidationCancellation;
|
|
task = m_revalidationTask;
|
|
m_revalidationCancellation = null;
|
|
m_revalidationTask = null;
|
|
}
|
|
|
|
if (cts == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
try
|
|
{
|
|
cts.Cancel();
|
|
if (task != null)
|
|
{
|
|
await task.ConfigureAwait(false);
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
}
|
|
finally
|
|
{
|
|
cts.Dispose();
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Long-lived loop that drains <see cref="m_revalidationSignal"/>
|
|
/// and re-runs server-certificate validation whenever the
|
|
/// application's <see cref="CertificateManager"/> publishes a
|
|
/// <see cref="CertificateChangeKind.TrustListUpdated"/> or
|
|
/// <see cref="CertificateChangeKind.CrlUpdated"/> event.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// The loop owns the at-most-one-in-flight property — only this
|
|
/// task ever calls <see cref="RevalidateServerCertificateAsync"/>,
|
|
/// and it does so serially. Bursts of signals collapse to a
|
|
/// single validation: <see cref="m_revalidationSignal"/> is a
|
|
/// bounded channel of capacity 1 with
|
|
/// <see cref="BoundedChannelFullMode.DropWrite"/>, so duplicate
|
|
/// signals received while one is pending are silently dropped.
|
|
/// </para>
|
|
/// <para>
|
|
/// After the signal is read, the loop waits a short debounce
|
|
/// window via <see cref="m_timeProvider"/> so a burst of events
|
|
/// (e.g. a batch trust-list refresh) coalesces to one validation
|
|
/// on the final state. Signals that arrive during the debounce
|
|
/// or during the validation itself re-fill the channel and are
|
|
/// picked up on the next iteration, so the final state is always
|
|
/// honoured exactly once after the burst settles.
|
|
/// </para>
|
|
/// </remarks>
|
|
private Task RunRevalidationLoopAsync(CancellationToken ct)
|
|
{
|
|
return RunRevalidationLoopAsync(
|
|
m_revalidationSignal.Reader,
|
|
m_timeProvider,
|
|
s_revalidationDebounce,
|
|
RevalidateServerCertificateAsync,
|
|
m_logger,
|
|
ct);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Pure loop body, factored out so it can be exercised in
|
|
/// isolation without standing up a connected
|
|
/// <see cref="ManagedSession"/>. Drains the signal channel,
|
|
/// debounces bursts via the injected <see cref="TimeProvider"/>,
|
|
/// then invokes <paramref name="revalidate"/> exactly once per
|
|
/// settled burst — including a re-arm when signals arrive
|
|
/// during the validation itself (the bounded-channel writer in
|
|
/// <see cref="SignalRevalidation"/> refills the channel after
|
|
/// the post-debounce drain, so the next iteration picks it up).
|
|
/// </summary>
|
|
/// <param name="reader">Reader for the signal channel.</param>
|
|
/// <param name="timeProvider">Time provider used by the debounce delay.</param>
|
|
/// <param name="debounce">Debounce window.</param>
|
|
/// <param name="revalidate">Callback that performs the actual
|
|
/// validation. Exceptions are caught and logged; the loop
|
|
/// continues so a transient failure does not break the wiring.</param>
|
|
/// <param name="logger">Logger for revalidation failures.</param>
|
|
/// <param name="ct">Cancellation token signalled at Dispose.</param>
|
|
internal static async Task RunRevalidationLoopAsync(
|
|
ChannelReader<int> reader,
|
|
TimeProvider timeProvider,
|
|
TimeSpan debounce,
|
|
Func<CancellationToken, Task> revalidate,
|
|
ILogger logger,
|
|
CancellationToken ct)
|
|
{
|
|
try
|
|
{
|
|
while (!ct.IsCancellationRequested)
|
|
{
|
|
await reader.ReadAsync(ct).ConfigureAwait(false);
|
|
|
|
await timeProvider.Delay(debounce, ct).ConfigureAwait(false);
|
|
|
|
// Drain any signals that arrived during the debounce
|
|
// so the next ReadAsync only fires for events that
|
|
// post-date this validation.
|
|
while (reader.TryRead(out _))
|
|
{
|
|
}
|
|
|
|
try
|
|
{
|
|
await revalidate(ct).ConfigureAwait(false);
|
|
}
|
|
catch (OperationCanceledException) when (ct.IsCancellationRequested)
|
|
{
|
|
return;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
logger.LogWarning(
|
|
ex,
|
|
"ManagedSession: server-certificate revalidation failed; will retry on next change.");
|
|
}
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
// Loop cancellation from Dispose / Unsubscribe — exit cleanly.
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Re-runs <see cref="ICertificateValidatorEx.ValidateAsync(Certificate, TrustListIdentifier, CancellationToken)"/>
|
|
/// against the cached server certificate currently advertised by
|
|
/// the session's configured endpoint and triggers a reconnect
|
|
/// when the result flips from valid to invalid.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Virtual to give unit tests a seam without standing up a full
|
|
/// connected session. The default implementation pulls the cert
|
|
/// from <c>ConfiguredEndpoint.Description.ServerCertificate</c>
|
|
/// (the cert the channel was negotiated against), early-returns
|
|
/// when no cert is cached (e.g. a <c>SecurityPolicy.None</c>
|
|
/// channel), validates against the default Peers trust list, and
|
|
/// calls <see cref="ConnectionStateMachine.TriggerReconnect"/>
|
|
/// when the result is no longer valid.
|
|
/// </remarks>
|
|
internal virtual async Task RevalidateServerCertificateAsync(CancellationToken ct)
|
|
{
|
|
Session? session = m_session;
|
|
if (session == null || m_disposed != 0)
|
|
{
|
|
return;
|
|
}
|
|
|
|
ConfiguredEndpoint? endpoint = session.ConfiguredEndpoint;
|
|
ByteString serverCertBlob = endpoint?.Description?.ServerCertificate ?? default;
|
|
if (serverCertBlob.IsEmpty)
|
|
{
|
|
// SecurityPolicy.None or pre-discovery — nothing to validate.
|
|
return;
|
|
}
|
|
|
|
ICertificateValidatorEx? validator = m_configuration.CertificateManager;
|
|
if (validator == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
byte[] rawData = serverCertBlob.ToArray();
|
|
using var serverCert = Certificate.FromRawData(rawData);
|
|
|
|
CertificateValidationResult result;
|
|
try
|
|
{
|
|
result = await validator.ValidateAsync(serverCert, ct: ct)
|
|
.ConfigureAwait(false);
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
throw;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
m_logger.LogWarning(
|
|
ex,
|
|
"ManagedSession: ValidateAsync threw on cached server certificate {Thumbprint}; treating as invalid.",
|
|
serverCert.Thumbprint);
|
|
StateMachine.TriggerReconnect();
|
|
return;
|
|
}
|
|
|
|
if (result.IsValid)
|
|
{
|
|
m_logger.LogDebug(
|
|
"ManagedSession: cached server certificate {Thumbprint} still trusted after trust/CRL update — no reconnect needed.",
|
|
serverCert.Thumbprint);
|
|
return;
|
|
}
|
|
|
|
m_logger.LogInformation(
|
|
"ManagedSession: cached server certificate {Thumbprint} no longer trusted after trust/CRL update ({Status}); triggering reconnect.",
|
|
serverCert.Thumbprint,
|
|
result.StatusCode);
|
|
StateMachine.TriggerReconnect();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Raised on every observed
|
|
/// <see cref="CertificateChangeEvent"/> regardless of
|
|
/// <see cref="DisableAutoReconnectOnCertificateChange"/>. Subscribers
|
|
/// can use this for diagnostics or to implement custom
|
|
/// rotation policies.
|
|
/// </summary>
|
|
public event EventHandler<CertificateChangeEvent>? ApplicationCertificateChanged;
|
|
|
|
// CA2213 false-positive: Interlocked.Exchange in
|
|
// UnsubscribeCertificateChanges hides the dispose call from the
|
|
// analyzer. Disposed in both Dispose paths.
|
|
#pragma warning disable CA2213
|
|
private IDisposable? m_certificateChangeSubscription;
|
|
/// <summary>
|
|
/// CTS owned by StartRevalidationLoop / disposed by
|
|
/// StopRevalidationLoopAsync. CancelRevalidationLoop (sync) only
|
|
/// cancels — the CTS is freed by the next StartRevalidationLoop
|
|
/// or by StopRevalidationLoopAsync.
|
|
/// </summary>
|
|
private CancellationTokenSource? m_revalidationCancellation;
|
|
#pragma warning restore CA2213
|
|
|
|
private readonly Lock m_revalidationLock = new();
|
|
private Task? m_revalidationTask;
|
|
|
|
/// <summary>
|
|
/// Bounded channel of capacity 1 with
|
|
/// <see cref="BoundedChannelFullMode.DropWrite"/> — duplicate
|
|
/// signals received while one is already pending are silently
|
|
/// dropped, which gives AutoResetEvent-like semantics without
|
|
/// per-event allocation.
|
|
/// </summary>
|
|
private readonly Channel<int> m_revalidationSignal
|
|
= Channel.CreateBounded<int>(new BoundedChannelOptions(1)
|
|
{
|
|
FullMode = BoundedChannelFullMode.DropWrite,
|
|
SingleReader = true,
|
|
SingleWriter = false,
|
|
AllowSynchronousContinuations = false
|
|
});
|
|
|
|
private static readonly TimeSpan s_revalidationDebounce
|
|
= TimeSpan.FromMilliseconds(250);
|
|
|
|
private sealed class CertificateChangeObserver : IObserver<CertificateChangeEvent>
|
|
{
|
|
private readonly ManagedSession m_owner;
|
|
|
|
public CertificateChangeObserver(ManagedSession owner)
|
|
{
|
|
m_owner = owner;
|
|
}
|
|
|
|
public void OnNext(CertificateChangeEvent value)
|
|
{
|
|
m_owner.OnCertificateChange(value);
|
|
}
|
|
|
|
public void OnError(Exception error)
|
|
{
|
|
m_owner.m_logger.LogWarning(
|
|
error,
|
|
"ManagedSession: certificate change stream errored.");
|
|
}
|
|
|
|
public void OnCompleted()
|
|
{
|
|
}
|
|
}
|
|
}
|
|
}
|