Files
Marc Schier 81b3c9b371 [Server] Implement NodeManagement service set and fix DeleteAddressSpace (#3839)
# Description

Adds the OPC UA NodeManagement service set (AddNodes / DeleteNodes /
AddReferences / DeleteReferences) to the server SDK and fixes a
long-standing shutdown bug where `NodeState.Delete` callbacks never
fired on address-space teardown.

### NodeManagement service set (#3736)

- New optional `INodeManagementAsyncNodeManager` facet interface (added
to `INodeManager.cs` alongside other facets, discovered via `as`,
**not** part of the `IAsyncNodeManager` composite). Opt-in per
NodeManager via `AllowNodeManagement` — default is `false` so existing
NodeManagers preserve binary compatibility.
- Dispatcher in `MasterNodeManager` routes:
- **AddNodes** by `RequestedNewNodeId.NamespaceIndex` when supplied,
otherwise to the parent's owning NodeManager. When the parent's owner is
read-only (e.g. `ObjectsFolder` owned by `CoreNodeManager`), the
dispatcher falls back to the first opted-in NodeManager so conformance
flows work out of the box.
- **DeleteNodes** / **AddReferences** / **DeleteReferences** to the
owning NodeManager of the target or source node, returning
`BadUserAccessDenied` when that NodeManager has not opted in.
Cross-NodeManager `AddReference` / `DeleteReference` best-effort mirrors
the inverse edge on the target's NodeManager.
- `AsyncCustomNodeManager` provides a default implementation: per-item
validation, `RequestedNewNodeId` honored, browse-name dedup for both
local and cross-NodeManager parents, `DeleteTargetReferences` semantics,
and a NodeId allocator fallback when an `INodeIdFactory.New` override
returns a null `NodeId` (e.g. parent-based hierarchical naming with no
parent attached).
- `StandardServer` adds the four service overrides plumbed through
`OperationLimits.MaxNodesPerNodeManagement`, audit events, and
`OnRequestComplete`; new `ReportAuditAddReferencesEvent` /
`ReportAuditDeleteReferencesEvent` helpers in `AuditEvents`.
- Quickstarts `ReferenceNodeManager` opts in via `AllowNodeManagement =>
true`; the legacy partial-class override in
`ReferenceServer.NodeManagement.cs` is removed.

### `NodeState.Delete` on shutdown (#3762)

- `CustomNodeManager.DeleteAddressSpace` and
`AsyncCustomNodeManager.DeleteAddressSpaceAsync` now snapshot root
`PredefinedNodes` (skipping children whose parent is in the snapshot to
prevent double-fire), invoke `NodeState.Delete(SystemContext)` on each
root (which recurses into children and raises `OnBeforeDelete` /
`OnAfterDelete` / `NodeStateChangeMasks.Deleted`), and then clear the
map.
- Derived overrides in Quickstarts `ReferenceNodeManager`,
`SampleNodeManager`, and `FileSystemNodeManager` chain to `base` so the
callback fires for their nodes too.

### Tests

- **21 new dispatcher unit tests** in
`Tests/Opc.Ua.Server.Tests/NodeManager/AsyncCustomNodeManagerNodeManagementTests.cs`
covering `AllowNodeManagement` default/opt-in, AddNode validation
(`BadBrowseNameInvalid`, `BadParentNodeIdInvalid`, `BadNodeIdRejected`,
`BadNodeIdExists`, `BadBrowseNameDuplicated`, `BadNodeClassInvalid`),
RequestedNewNodeId paths, DeleteNode + `DeleteTargetReferences`,
AddReference duplicate detection (`BadDuplicateReferenceNotAllowed`),
and DeleteReference (`BadNoMatch`).
- **2 new DeleteAddressSpaceAsync tests** in
`AsyncCustomNodeManagerTests` verifying `NodeState.Delete` invocation
and no double-fire on children.
- Updated InformationModel
`NodeManagementAddRefTests.AddReferenceBetweenExistingNodesSucceedsAsync`
to accept `BadUserAccessDenied` / `BadNotSupported` when the source NM
has opted out.
- **Full `Opc.Ua.Server.Tests` on net10.0: 1709 passed, 0 failed.**
- **All 26 InformationModel `Category=NodeManagement` conformance tests
pass** against the reference server (1 skipped where source NM opts
out).

### Docs

- New [`Docs/NodeManagement.md`](Docs/NodeManagement.md) with
architecture, opt-in pattern, dispatch and routing rules,
request-handling table, error-code table, audit events, and
custom-behavior examples.
- `Docs/MigrationGuide.md` gets two new sections — *NodeManagement
service set* (downstream migration steps) and *DeleteAddressSpace
invokes NodeState.Delete (#3762)* (shutdown behavior change) — with TOC
entries.
- `Docs/README.md` links the new `NodeManagement.md`.

## Related Issues

- Fixes #3736
- Fixes #3762

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
2026-06-04 13:02:32 +02:00

385 lines
14 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
namespace Opc.Ua.Server.FileSystem
{
/// <summary>
/// Exposes an <see cref="IFileSystemProvider"/> in the server's
/// address space using the standard OPC UA Part 5 §C / Part 20 §4
/// <c>FileType</c> / <c>FileDirectoryType</c> companion model.
/// </summary>
/// <remarks>
/// <para>
/// The provider is mounted as a single
/// <c>FileDirectoryType</c> instance under the standard
/// <c>Server.FileSystem</c> object (<c>ObjectIds.FileSystem</c>,
/// <c>i=16314</c>) via a <c>HasComponent</c> reference. This is
/// what <c>FileSystemClient.OpenServerFileSystem</c> on the
/// client side expects to find.
/// </para>
/// <para>
/// To mount several providers side-by-side, register one
/// <see cref="FileSystemNodeManager"/> per provider — each owns
/// its own namespace and adds its own <c>HasComponent</c> child
/// under <c>i=16314</c>.
/// </para>
/// </remarks>
public sealed class FileSystemNodeManager : AsyncCustomNodeManager
{
/// <summary>
/// Base URI used to build the namespace URI of a mounted
/// provider. The full URI is
/// <c>{NamespaceUriBase}/{MountName}</c>.
/// </summary>
public const string NamespaceUriBase = "http://opcfoundation.org/UA/Server/FileSystem";
/// <summary>
/// Initialises a new node manager backed by
/// <paramref name="provider"/>.
/// </summary>
public FileSystemNodeManager(
IServerInternal server,
ApplicationConfiguration configuration,
IFileSystemProvider provider)
: base(server, configuration, BuildNamespaceUri(provider))
{
Provider = provider ?? throw new ArgumentNullException(nameof(provider));
SystemContext.SystemHandle = this;
SystemContext.NodeIdFactory = this;
NamespaceUris = new List<string> { BuildNamespaceUri(provider) };
NamespaceIndex = base.NamespaceIndex;
}
/// <summary>
/// The provider backing this node manager.
/// </summary>
public IFileSystemProvider Provider { get; }
/// <summary>
/// Namespace index assigned to this provider's nodes.
/// </summary>
public new ushort NamespaceIndex { get; }
/// <inheritdoc/>
public override NodeId New(ISystemContext context, NodeState node)
{
return FileSystemNodeId.ConstructIdForComponent(node, NamespaceIndex);
}
/// <inheritdoc/>
public override ValueTask CreateAddressSpaceAsync(
IDictionary<NodeId, IList<IReference>> externalReferences,
CancellationToken cancellationToken = default)
{
lock (m_lock)
{
if (!externalReferences.TryGetValue(ObjectIds.FileSystem,
out IList<IReference>? references))
{
externalReferences[ObjectIds.FileSystem] = references = [];
}
NodeId rootId = FileSystemNodeId.BuildRoot(NamespaceIndex);
references.Add(new NodeStateReference(
ReferenceTypeIds.HasComponent, false, rootId));
}
return default;
}
/// <inheritdoc/>
protected override ValueTask<NodeHandle> GetManagerHandleAsync(
ServerSystemContext context,
NodeId nodeId,
IDictionary<NodeId, NodeState> cache,
CancellationToken cancellationToken = default)
{
lock (m_lock)
{
if (!IsNodeIdInNamespace(nodeId))
{
return new ValueTask<NodeHandle>();
}
if (nodeId.IdType != IdType.String &&
PredefinedNodes.TryGetValue(nodeId, out NodeState? node))
{
return new ValueTask<NodeHandle>(new NodeHandle
{
NodeId = nodeId,
Node = node,
Validated = true
});
}
if (FileSystemNodeId.TryParse(nodeId, out FileSystemNodeId parsed))
{
return new ValueTask<NodeHandle>(new NodeHandle
{
NodeId = nodeId,
Validated = false,
ParsedNodeId = new ParsedFileSystemNodeId(parsed)
});
}
return new ValueTask<NodeHandle>();
}
}
/// <inheritdoc/>
public override ValueTask DeleteAddressSpaceAsync(CancellationToken cancellationToken = default)
{
lock (m_lock)
{
foreach (FileHandle handle in m_handles.Values)
{
handle.Dispose();
}
m_handles.Clear();
}
return base.DeleteAddressSpaceAsync(cancellationToken);
}
/// <inheritdoc/>
protected override void Dispose(bool disposing)
{
if (disposing)
{
lock (m_lock)
{
foreach (FileHandle handle in m_handles.Values)
{
handle.Dispose();
}
m_handles.Clear();
}
}
base.Dispose(disposing);
}
/// <inheritdoc/>
protected override async ValueTask<NodeState> ValidateNodeAsync(
ServerSystemContext context,
NodeHandle handle,
IDictionary<NodeId, NodeState> cache,
CancellationToken cancellationToken = default)
{
if (handle == null)
{
return null!;
}
if (handle.Validated)
{
return handle.Node;
}
NodeState? target = null;
if (cache != null && cache.TryGetValue(handle.NodeId, out target))
{
if (target == null)
{
return null!;
}
handle.Node = target;
handle.Validated = true;
return target;
}
try
{
if (handle.ParsedNodeId is not ParsedFileSystemNodeId parsed)
{
return null!;
}
FileSystemEntry? entry = await Provider
.GetEntryAsync(parsed.Value.ProviderPath, cancellationToken)
.ConfigureAwait(false);
if (parsed.Value.RootType != FileSystemNodeId.Root && entry == null)
{
return null!;
}
NodeState? root = parsed.Value.RootType switch
{
FileSystemNodeId.Root => new DirectoryObjectState(
context,
FileSystemNodeId.BuildRoot(NamespaceIndex),
string.Empty,
Provider.MountName,
isRoot: true),
FileSystemNodeId.Directory => new DirectoryObjectState(
context,
FileSystemNodeId.BuildDirectory(parsed.Value.ProviderPath, NamespaceIndex),
parsed.Value.ProviderPath,
entry!.Value.Name,
isRoot: false),
FileSystemNodeId.File => new FileObjectState(
context,
FileSystemNodeId.BuildFile(parsed.Value.ProviderPath, NamespaceIndex),
parsed.Value.ProviderPath,
entry!.Value.Name),
_ => null
};
if (root == null)
{
return null!;
}
if (string.IsNullOrEmpty(parsed.Value.ComponentPath))
{
handle.Validated = true;
handle.Node = target = root;
return target;
}
NodeState? component = root.FindChildBySymbolicName(
context, parsed.Value.ComponentPath!);
if (component == null)
{
return null!;
}
handle.Validated = true;
handle.Node = target = component;
return target;
}
finally
{
cache?.Add(handle.NodeId, target!);
}
}
/// <summary>
/// Returns the NodeId of the parent directory of the supplied
/// provider path, or <see cref="NodeId.Null"/> when the path
/// is at the root.
/// </summary>
internal NodeId GetParentNodeId(string providerPath)
{
if (string.IsNullOrEmpty(providerPath))
{
return NodeId.Null;
}
int slash = providerPath.LastIndexOf('/');
string parent = slash < 0 ? string.Empty : providerPath[..slash];
return string.IsNullOrEmpty(parent)
? FileSystemNodeId.BuildRoot(NamespaceIndex)
: FileSystemNodeId.BuildDirectory(parent, NamespaceIndex);
}
/// <summary>
/// Combines a parent provider path with a child name, taking
/// care of empty parents and trailing slashes.
/// </summary>
internal string CombineProviderPath(string parent, string name)
{
if (string.IsNullOrEmpty(parent))
{
return name;
}
return parent.TrimEnd('/') + "/" + name;
}
/// <summary>
/// Looks up or creates the file handle for the given file
/// NodeId. Returns <c>null</c> if the NodeId is not a file
/// NodeId in this provider's namespace.
/// </summary>
internal FileHandle? GetOrCreateHandle(NodeId nodeId, string providerPath)
{
lock (m_lock)
{
if (m_handles.TryGetValue(nodeId, out FileHandle? handle))
{
return handle;
}
handle = new FileHandle(Provider, providerPath);
m_handles.Add(nodeId, handle);
return handle;
}
}
/// <summary>
/// Drops and disposes the file handle associated with
/// <paramref name="nodeId"/>. Called after delete / move so
/// stale handles don't leak.
/// </summary>
internal void ForgetHandle(NodeId nodeId)
{
lock (m_lock)
{
if (m_handles.TryGetValue(nodeId, out FileHandle? handle))
{
handle.Dispose();
m_handles.Remove(nodeId);
}
}
}
private static string BuildNamespaceUri(IFileSystemProvider provider)
{
if (provider == null)
{
throw new ArgumentNullException(nameof(provider));
}
if (string.IsNullOrEmpty(provider.MountName))
{
throw new ArgumentException(
"Provider MountName must be non-empty.",
nameof(provider));
}
return NamespaceUriBase + "/" + provider.MountName;
}
private readonly Dictionary<NodeId, FileHandle> m_handles = [];
private readonly object m_lock = new();
/// <summary>
/// Boxes a <see cref="FileSystemNodeId"/> for storage in
/// <see cref="NodeHandle.ParsedNodeId"/> (which expects a
/// reference type).
/// </summary>
private sealed class ParsedFileSystemNodeId
{
public ParsedFileSystemNodeId(FileSystemNodeId value)
{
Value = value;
}
public FileSystemNodeId Value { get; }
}
}
}