Files
Marc Schier 81b3c9b371 [Server] Implement NodeManagement service set and fix DeleteAddressSpace (#3839)
# Description

Adds the OPC UA NodeManagement service set (AddNodes / DeleteNodes /
AddReferences / DeleteReferences) to the server SDK and fixes a
long-standing shutdown bug where `NodeState.Delete` callbacks never
fired on address-space teardown.

### NodeManagement service set (#3736)

- New optional `INodeManagementAsyncNodeManager` facet interface (added
to `INodeManager.cs` alongside other facets, discovered via `as`,
**not** part of the `IAsyncNodeManager` composite). Opt-in per
NodeManager via `AllowNodeManagement` — default is `false` so existing
NodeManagers preserve binary compatibility.
- Dispatcher in `MasterNodeManager` routes:
- **AddNodes** by `RequestedNewNodeId.NamespaceIndex` when supplied,
otherwise to the parent's owning NodeManager. When the parent's owner is
read-only (e.g. `ObjectsFolder` owned by `CoreNodeManager`), the
dispatcher falls back to the first opted-in NodeManager so conformance
flows work out of the box.
- **DeleteNodes** / **AddReferences** / **DeleteReferences** to the
owning NodeManager of the target or source node, returning
`BadUserAccessDenied` when that NodeManager has not opted in.
Cross-NodeManager `AddReference` / `DeleteReference` best-effort mirrors
the inverse edge on the target's NodeManager.
- `AsyncCustomNodeManager` provides a default implementation: per-item
validation, `RequestedNewNodeId` honored, browse-name dedup for both
local and cross-NodeManager parents, `DeleteTargetReferences` semantics,
and a NodeId allocator fallback when an `INodeIdFactory.New` override
returns a null `NodeId` (e.g. parent-based hierarchical naming with no
parent attached).
- `StandardServer` adds the four service overrides plumbed through
`OperationLimits.MaxNodesPerNodeManagement`, audit events, and
`OnRequestComplete`; new `ReportAuditAddReferencesEvent` /
`ReportAuditDeleteReferencesEvent` helpers in `AuditEvents`.
- Quickstarts `ReferenceNodeManager` opts in via `AllowNodeManagement =>
true`; the legacy partial-class override in
`ReferenceServer.NodeManagement.cs` is removed.

### `NodeState.Delete` on shutdown (#3762)

- `CustomNodeManager.DeleteAddressSpace` and
`AsyncCustomNodeManager.DeleteAddressSpaceAsync` now snapshot root
`PredefinedNodes` (skipping children whose parent is in the snapshot to
prevent double-fire), invoke `NodeState.Delete(SystemContext)` on each
root (which recurses into children and raises `OnBeforeDelete` /
`OnAfterDelete` / `NodeStateChangeMasks.Deleted`), and then clear the
map.
- Derived overrides in Quickstarts `ReferenceNodeManager`,
`SampleNodeManager`, and `FileSystemNodeManager` chain to `base` so the
callback fires for their nodes too.

### Tests

- **21 new dispatcher unit tests** in
`Tests/Opc.Ua.Server.Tests/NodeManager/AsyncCustomNodeManagerNodeManagementTests.cs`
covering `AllowNodeManagement` default/opt-in, AddNode validation
(`BadBrowseNameInvalid`, `BadParentNodeIdInvalid`, `BadNodeIdRejected`,
`BadNodeIdExists`, `BadBrowseNameDuplicated`, `BadNodeClassInvalid`),
RequestedNewNodeId paths, DeleteNode + `DeleteTargetReferences`,
AddReference duplicate detection (`BadDuplicateReferenceNotAllowed`),
and DeleteReference (`BadNoMatch`).
- **2 new DeleteAddressSpaceAsync tests** in
`AsyncCustomNodeManagerTests` verifying `NodeState.Delete` invocation
and no double-fire on children.
- Updated InformationModel
`NodeManagementAddRefTests.AddReferenceBetweenExistingNodesSucceedsAsync`
to accept `BadUserAccessDenied` / `BadNotSupported` when the source NM
has opted out.
- **Full `Opc.Ua.Server.Tests` on net10.0: 1709 passed, 0 failed.**
- **All 26 InformationModel `Category=NodeManagement` conformance tests
pass** against the reference server (1 skipped where source NM opts
out).

### Docs

- New [`Docs/NodeManagement.md`](Docs/NodeManagement.md) with
architecture, opt-in pattern, dispatch and routing rules,
request-handling table, error-code table, audit events, and
custom-behavior examples.
- `Docs/MigrationGuide.md` gets two new sections — *NodeManagement
service set* (downstream migration steps) and *DeleteAddressSpace
invokes NodeState.Delete (#3762)* (shutdown behavior change) — with TOC
entries.
- `Docs/README.md` links the new `NodeManagement.md`.

## Related Issues

- Fixes #3736
- Fixes #3762

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
2026-06-04 13:02:32 +02:00

413 lines
20 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
namespace Opc.Ua.Server
{
/// <summary>
/// The master node manager for the server.
/// </summary>
public interface IMasterNodeManager
{
/// <summary>
/// The node managers being managed.
/// </summary>
IReadOnlyList<IAsyncNodeManager> AsyncNodeManagers { get; }
/// <summary>
/// Returns the configuration node manager.
/// </summary>
IConfigurationNodeManager? ConfigurationNodeManager { get; }
/// <summary>
/// Returns the core node manager.
/// </summary>
ICoreNodeManager? CoreNodeManager { get; }
/// <summary>
/// Returns the diagnostics node manager.
/// </summary>
IDiagnosticsNodeManager? DiagnosticsNodeManager { get; }
/// <summary>
/// The node managers being managed.
/// </summary>
IReadOnlyList<INodeManager> NodeManagers { get; }
/// <summary>
/// Adds the references to the target.
/// </summary>
ValueTask AddReferencesAsync(NodeId sourceId, IList<IReference> references, CancellationToken cancellationToken = default);
/// <summary>
/// Dispatches AddNodes service requests (Part 4 §5.8.2) per item to the
/// node manager that owns the parent node.
/// </summary>
/// <remarks>
/// For every item, the dispatcher resolves the parent NodeId and routes
/// the request to the owning <see cref="INodeManagementAsyncNodeManager"/>.
/// When the owner has not opted into NodeManagement, the corresponding
/// result is <see cref="StatusCodes.BadUserAccessDenied"/>.
/// </remarks>
ValueTask<(ArrayOf<AddNodesResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> AddNodesAsync(
OperationContext context,
ArrayOf<AddNodesItem> nodesToAdd,
CancellationToken cancellationToken = default);
/// <summary>
/// Dispatches DeleteNodes service requests (Part 4 §5.8.4) per item to
/// the node manager that owns the node being deleted. When the item
/// requests target-reference removal, the dispatcher removes inverse
/// references in all other node managers that point at the deleted node.
/// </summary>
ValueTask<(ArrayOf<StatusCode> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> DeleteNodesAsync(
OperationContext context,
ArrayOf<DeleteNodesItem> nodesToDelete,
CancellationToken cancellationToken = default);
/// <summary>
/// Dispatches AddReferences service requests (Part 4 §5.8.3) per item.
/// </summary>
/// <remarks>
/// Forward references are routed to the source node's owning manager.
/// When the target node is local, the inverse edge is also written into
/// the target's owning manager so Browse returns symmetric edges.
/// </remarks>
ValueTask<(ArrayOf<StatusCode> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> AddReferencesAsync(
OperationContext context,
ArrayOf<AddReferencesItem> referencesToAdd,
CancellationToken cancellationToken = default);
/// <summary>
/// Dispatches DeleteReferences service requests (Part 4 §5.8.5) per item.
/// </summary>
ValueTask<(ArrayOf<StatusCode> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> DeleteReferencesAsync(
OperationContext context,
ArrayOf<DeleteReferencesItem> referencesToDelete,
CancellationToken cancellationToken = default);
/// <summary>
/// Returns the set of references that meet the filter criteria.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask<(ArrayOf<BrowseResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> BrowseAsync(
OperationContext context,
ViewDescription view,
uint maxReferencesPerNode,
ArrayOf<BrowseDescription> nodesToBrowse,
CancellationToken cancellationToken = default);
/// <summary>
/// Continues a browse operation that was previously halted.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask<(ArrayOf<BrowseResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> BrowseNextAsync(
OperationContext context,
bool releaseContinuationPoints,
ArrayOf<ByteString> continuationPoints,
CancellationToken cancellationToken = default);
/// <summary>
/// Calls a method defined on an object.
/// </summary>
/// <exception cref="ArgumentNullException">
/// <paramref name="context"/> is <c>null</c>.</exception>
ValueTask<(ArrayOf<CallMethodResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> CallAsync(
OperationContext context,
ArrayOf<CallMethodRequest> methodsToCall,
CancellationToken cancellationToken = default);
/// <summary>
/// Handles condition refresh request.
/// </summary>
ValueTask ConditionRefreshAsync(OperationContext context, IList<IEventMonitoredItem> monitoredItems, CancellationToken cancellationToken = default);
/// <summary>
/// Creates a set of monitored items.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
/// <exception cref="ArgumentOutOfRangeException"></exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask CreateMonitoredItemsAsync(
OperationContext context,
uint subscriptionId,
double publishingInterval,
TimestampsToReturn timestampsToReturn,
ArrayOf<MonitoredItemCreateRequest> itemsToCreate,
IList<ServiceResult> errors,
IList<MonitoringFilterResult> filterResults,
IList<IMonitoredItem> monitoredItems,
bool createDurable,
CancellationToken cancellationToken = default);
/// <summary>
/// Deletes a set of monitored items.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
ValueTask DeleteMonitoredItemsAsync(
OperationContext context,
uint subscriptionId,
IList<IMonitoredItem> itemsToDelete,
IList<ServiceResult> errors,
CancellationToken cancellationToken = default);
/// <summary>
/// Deletes the references to the target.
/// </summary>
ValueTask DeleteReferencesAsync(NodeId targetId, IList<IReference> references, CancellationToken cancellationToken = default);
/// <summary>
/// Searches the node id in all node managers,
/// returns the node state if found (and node Manager supports it), otherwise returns null.
/// </summary>
ValueTask<NodeState?> FindNodeInAddressSpaceAsync(NodeId nodeId, CancellationToken cancellationToken = default);
/// <summary>
/// Returns node handle and its node manager.
/// </summary>
[Obsolete("Use GetManagerHandleAsync instead.")]
object? GetManagerHandle(NodeId nodeId, out IAsyncNodeManager? nodeManager);
/// <summary>
/// Returns node handle and its node manager.
/// </summary>
object? GetManagerHandle(NodeId nodeId, out INodeManager? nodeManager);
/// <summary>
/// Returns node handle and its node manager.
/// </summary>
ValueTask<(object? handle, IAsyncNodeManager? nodeManager)> GetManagerHandleAsync(NodeId nodeId, CancellationToken cancellationToken = default);
/// <summary>
/// Reads the history of a set of items.
/// </summary>
/// <exception cref="ServiceResultException"></exception>
ValueTask<(ArrayOf<HistoryReadResult> values, ArrayOf<DiagnosticInfo> diagnosticInfos)> HistoryReadAsync(
OperationContext context,
ExtensionObject historyReadDetails,
TimestampsToReturn timestampsToReturn,
bool releaseContinuationPoints,
ArrayOf<HistoryReadValueId> nodesToRead,
CancellationToken cancellationToken = default);
/// <summary>
/// Updates the history for a set of nodes.
/// </summary>
ValueTask<(ArrayOf<HistoryUpdateResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> HistoryUpdateAsync(
OperationContext context,
ArrayOf<ExtensionObject> historyUpdateDetails,
CancellationToken cancellationToken = default);
/// <summary>
/// Modifies a set of monitored items.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask ModifyMonitoredItemsAsync(
OperationContext context,
TimestampsToReturn timestampsToReturn,
IList<IMonitoredItem> monitoredItems,
ArrayOf<MonitoredItemModifyRequest> itemsToModify,
IList<ServiceResult> errors,
IList<MonitoringFilterResult> filterResults,
CancellationToken cancellationToken = default);
/// <summary>
/// Reads a set of nodes.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="nodesToRead"/> is <c>null</c>.</exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask<(ArrayOf<DataValue> values, ArrayOf<DiagnosticInfo> diagnosticInfos)> ReadAsync(
OperationContext context,
double maxAge,
TimestampsToReturn timestampsToReturn,
ArrayOf<ReadValueId> nodesToRead,
CancellationToken cancellationToken = default);
/// <summary>
/// Registers the node manager as the node manager for Nodes in the specified namespace.
/// </summary>
/// <param name="namespaceUri">The URI of the namespace.</param>
/// <param name="nodeManager">The NodeManager which owns node in the namespace.</param>
/// <remarks>
/// <para>
/// Multiple NodeManagers may register interest in a Namespace.
/// The order in which this method is called determines the precedence if multiple NodeManagers exist.
/// This method adds the namespaceUri to the Server's Namespace table if it does not already exist.
/// </para>
/// <para>This method is thread safe and can be called at anytime.</para>
/// <para>
/// This method does not have to be called for any namespaces that were in the NodeManager's
/// NamespaceUri property when the MasterNodeManager was created.
/// </para>
/// </remarks>
/// <exception cref="ArgumentNullException">Throw if the namespaceUri or the nodeManager are null.</exception>
void RegisterNamespaceManager(string namespaceUri, IAsyncNodeManager nodeManager);
/// <summary>
/// Registers the node manager as the node manager for Nodes in the specified namespace.
/// </summary>
/// <param name="namespaceUri">The URI of the namespace.</param>
/// <param name="nodeManager">The NodeManager which owns node in the namespace.</param>
/// <remarks>
/// <para>
/// Multiple NodeManagers may register interest in a Namespace.
/// The order in which this method is called determines the precedence if multiple NodeManagers exist.
/// This method adds the namespaceUri to the Server's Namespace table if it does not already exist.
/// </para>
/// <para>This method is thread safe and can be called at anytime.</para>
/// <para>
/// This method does not have to be called for any namespaces that were in the NodeManager's
/// NamespaceUri property when the MasterNodeManager was created.
/// </para>
/// </remarks>
/// <exception cref="ArgumentNullException">Throw if the namespaceUri or the nodeManager are null.</exception>
void RegisterNamespaceManager(string namespaceUri, INodeManager nodeManager);
/// <summary>
/// Registers a set of node ids.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="nodesToRegister"/> is <c>null</c>.</exception>
void RegisterNodes(OperationContext context, ArrayOf<NodeId> nodesToRegister, out ArrayOf<NodeId> registeredNodeIds);
/// <summary>
/// Deletes the specified references.
/// </summary>
[Obsolete("Use RemoveReferencesAsync instead.")]
void RemoveReferences(List<LocalReference> referencesToRemove);
/// <summary>
/// Deletes the specified references.
/// </summary>
ValueTask RemoveReferencesAsync(List<LocalReference> referencesToRemove, CancellationToken cancellationToken = default);
/// <summary>
/// Restore a set of monitored items after a Server Restart.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="itemsToRestore"/> is <c>null</c>.</exception>
/// <exception cref="InvalidOperationException"></exception>
ValueTask RestoreMonitoredItemsAsync(
IList<IStoredMonitoredItem> itemsToRestore,
IList<IMonitoredItem> monitoredItems,
IUserIdentity savedOwnerIdentity,
CancellationToken cancellationToken = default);
/// <summary>
/// Signals that a session is closing.
/// </summary>
ValueTask SessionClosingAsync(OperationContext context, NodeId sessionId, bool deleteSubscriptions, CancellationToken cancellationToken = default);
/// <summary>
/// Signals that a session has been activated with a changed user identity.
/// </summary>
ValueTask SessionActivatedAsync(OperationContext context, NodeId sessionId, CancellationToken cancellationToken = default);
/// <summary>
/// Changes the monitoring mode for a set of items.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
ValueTask SetMonitoringModeAsync(
OperationContext context,
MonitoringMode monitoringMode,
IList<IMonitoredItem> itemsToModify,
IList<ServiceResult> errors,
CancellationToken cancellationToken = default);
/// <summary>
/// Shuts down the node managers.
/// </summary>
ValueTask ShutdownAsync(CancellationToken cancellationToken = default);
/// <summary>
/// Creates the node managers and start them
/// </summary>
ValueTask StartupAsync(CancellationToken cancellationToken = default);
/// <summary>
/// Transfers a set of monitored items.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
ValueTask TransferMonitoredItemsAsync(
OperationContext context,
bool sendInitialValues,
IList<IMonitoredItem> monitoredItems,
IList<ServiceResult> errors,
CancellationToken cancellationToken = default);
/// <summary>
/// Translates a start node id plus a relative paths into a node id.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="browsePaths"/> is <c>null</c>.</exception>
/// <exception cref="ServiceResultException"></exception>
ValueTask<(ArrayOf<BrowsePathResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> TranslateBrowsePathsToNodeIdsAsync(
OperationContext context,
ArrayOf<BrowsePath> browsePaths,
CancellationToken cancellationToken = default);
/// <summary>
/// Unregisters the node manager as the node manager for Nodes in the specified namespace.
/// </summary>
/// <param name="namespaceUri">The URI of the namespace.</param>
/// <param name="nodeManager">The NodeManager which no longer owns nodes in the namespace.</param>
/// <returns>A value indicating whether the node manager was successfully unregistered.</returns>
/// <exception cref="ArgumentNullException">Throw if the namespaceUri or the nodeManager are null.</exception>
bool UnregisterNamespaceManager(string namespaceUri, IAsyncNodeManager nodeManager);
/// <summary>
/// Unregisters the node manager as the node manager for Nodes in the specified namespace.
/// </summary>
/// <param name="namespaceUri">The URI of the namespace.</param>
/// <param name="nodeManager">The NodeManager which no longer owns nodes in the namespace.</param>
/// <returns>A value indicating whether the node manager was successfully unregistered.</returns>
/// <exception cref="ArgumentNullException">Throw if the namespaceUri or the nodeManager are null.</exception>
bool UnregisterNamespaceManager(string namespaceUri, INodeManager nodeManager);
/// <summary>
/// Unregisters a set of node ids.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="nodesToUnregister"/> is <c>null</c>.</exception>
void UnregisterNodes(OperationContext context, ArrayOf<NodeId> nodesToUnregister);
/// <summary>
/// Writes a set of values.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
ValueTask<(ArrayOf<StatusCode> results, ArrayOf<DiagnosticInfo> diagnosticInfos)> WriteAsync(
OperationContext context,
ArrayOf<WriteValue> nodesToWrite,
CancellationToken cancellationToken = default);
}
}