Files
UA-.NETStandard/Tests/Opc.Ua.Client.Tests/FileSystem/TemporaryFileTransferClientTests.cs
Marc Schier 0000513cde Pluggable user-identity provider model (#3807)
# Description

Introduces a pluggable user-identity provider model covering all OPC UA
Part 6 §6.5 mechanisms (Anonymous, UserName, X509, IssuedToken/JWT) on
both client and server, with full
`Microsoft.Extensions.DependencyInjection` integration, plus the Part 12
§9 `AuthorizationService` two-phase token-request flow **including
refresh-token rotation**, the Part 12 §8 KeyCredential Push model, and a
clean provider model for OPC 10000-12 §7.2 `ApplicationSelfAdmin`. The
work is split across phase-by-phase commits so it can be reviewed
independently; nothing here changes wire-level behaviour or forces
existing applications to migrate.

### Documentation

All under `Docs/`:

- `IdentityProviders.md` — full developer guide: three-layer model,
recipes, configuration reference, "what gets auto-wired" matrix, JWS
algorithm table, identity-augmenters section, **"Implementing your own
provider"** how-to subsections for Entra / OIDC / Windows / AspNetCore
(sibling files merged in per review feedback).
- `DependencyInjection.md` — `Identity` sections with `appsettings.json`
examples, identity-extension matrix, `WithAuthorizationService` +
`WithKeyCredentialPush` + `AddIdentityAugmenter` extensions documented.
- `RoleBasedUserManagement.md` — claim-criteria callout describing
`IIdentityClaims` probe surface.
- `AuthorizationService.md` — Architecture diagram +
`IAccessTokenProvider` conceptual narrative restored from master; modern
`StartRequestToken` / `FinishRequestToken` flow leads; refresh-token
recipe added.
- `KeyCredentialService.md` — Push model + Pull vs Push vs Bridge
decision matrix + Hybrid (Push + Pull) section; explicit experimental
warning for the bridge.
- `GDS.md` — KeyCredential Push, `StartRequestToken`,
`GdsApplicationSelfAdminProvider`, **shipped Refresh-token support with
rotation policy and audit semantics** all documented.
- `MigrationGuide.md` — User Identity Providers section listing
`[Obsolete]` markers + mechanical recipes; SelfAdmin migration via
`IIdentityAugmenter`; `EnableRefreshTokens` default note.
- `README.md` index entries.

## Checklist

- [x] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [x] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [x] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [x] I have addressed **all** PR feedback received.
2026-06-02 01:14:54 +02:00

231 lines
9.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Client.FileSystem;
using Opc.Ua.Client.TestFramework;
using Opc.Ua.Tests;
namespace Opc.Ua.Client.Tests.FileSystem
{
/// <summary>
/// Unit tests for <see cref="TemporaryFileTransferClient"/> that
/// validate the temp-write commit lifecycle (CloseAndCommit vs
/// Close, single terminal call).
/// </summary>
[TestFixture]
[Category("FileSystem")]
[Parallelizable]
public class TemporaryFileTransferClientTests
{
[Test]
public async Task CommitAsyncSendsCloseAndCommitOnceAsync()
{
using var harness = TempTransferHarness.Create();
UaTemporaryWriteFile temp = await harness
.GenerateForWriteAsync().ConfigureAwait(false);
await harness.WriteSomeBytesAsync(temp).ConfigureAwait(false);
NodeId completion = await temp.CommitAsync().ConfigureAwait(false);
await temp.DisposeAsync().ConfigureAwait(false);
await temp.CommitAsync().ConfigureAwait(false);
Assert.That(harness.CloseAndCommitCount, Is.EqualTo(1));
Assert.That(harness.CloseCount, Is.Zero);
Assert.That(completion, Is.EqualTo(new NodeId(99)));
}
[Test]
public async Task DisposeWithoutCommitSendsCloseAsync()
{
using var harness = TempTransferHarness.Create();
UaTemporaryWriteFile temp = await harness
.GenerateForWriteAsync().ConfigureAwait(false);
await temp.DisposeAsync().ConfigureAwait(false);
await temp.DisposeAsync().ConfigureAwait(false);
Assert.That(harness.CloseCount, Is.EqualTo(1));
Assert.That(harness.CloseAndCommitCount, Is.Zero);
}
[Test]
public async Task GenerateForReadReturnsStreamThatClosesHandleOnDisposeAsync()
{
using var harness = TempTransferHarness.Create();
UaFileStream stream = await harness.Client
.GenerateFileForReadAsync(default, CancellationToken.None)
.ConfigureAwait(false);
await stream.DisposeAsync().ConfigureAwait(false);
Assert.That(harness.CloseCount, Is.EqualTo(1));
}
[Test]
public async Task TempStreamWrapperDisposeDoesNotCloseHandleAsync()
{
using var harness = TempTransferHarness.Create();
UaTemporaryWriteFile temp = await harness
.GenerateForWriteAsync().ConfigureAwait(false);
// Disposing the wrapped Stream must NOT close the server handle.
temp.Stream.Dispose();
Assert.That(harness.CloseCount, Is.Zero);
Assert.That(harness.CloseAndCommitCount, Is.Zero);
await temp.CommitAsync().ConfigureAwait(false);
Assert.That(harness.CloseAndCommitCount, Is.EqualTo(1));
}
private sealed class TempTransferHarness : IDisposable
{
private readonly Dictionary<uint, Func<CallMethodRequest, Variant[]>> m_handlers = [];
private TempTransferHarness(TemporaryFileTransferClient client)
{
Client = client;
}
public TemporaryFileTransferClient Client { get; }
public int CloseAndCommitCount { get; private set; }
public int CloseCount { get; private set; }
public static TempTransferHarness Create()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
IServiceMessageContext messageContext = ServiceMessageContext.Create(telemetry);
var sessionMock = new Mock<ISession>(MockBehavior.Loose);
sessionMock.SetupGet(s => s.MessageContext).Returns(messageContext);
TempTransferHarness harness = null;
sessionMock
.Setup(s => s.CallAsync(
It.IsAny<RequestHeader>(),
It.IsAny<ArrayOf<CallMethodRequest>>(),
It.IsAny<CancellationToken>()))
.Returns<RequestHeader, ArrayOf<CallMethodRequest>, CancellationToken>(
(_, requests, _) =>
{
CallMethodRequest req = requests[0];
req.MethodId.TryGetValue(out uint methodId);
Variant[] outputs = harness!.m_handlers[methodId](req);
var result = new CallMethodResult
{
StatusCode = StatusCodes.Good,
OutputArguments = outputs.ToArrayOf()
};
var response = new CallResponse
{
ResponseHeader = new ResponseHeader(),
Results = new[] { result }.ToArrayOf(),
DiagnosticInfos = default
};
return new ValueTask<CallResponse>(response);
});
var client = new TemporaryFileTransferClient(
sessionMock.Object,
new NodeId(1000));
harness = new TempTransferHarness(client);
harness.RegisterHandlers();
return harness;
}
public async Task<UaTemporaryWriteFile> GenerateForWriteAsync()
{
return await Client
.GenerateFileForWriteAsync(default, CancellationToken.None)
.ConfigureAwait(false);
}
public async Task WriteSomeBytesAsync(UaTemporaryWriteFile temp)
{
byte[] payload = [1, 2, 3];
#if NETSTANDARD2_1_OR_GREATER || NET
await temp.Stream
.WriteAsync(payload.AsMemory(), CancellationToken.None)
.ConfigureAwait(false);
#else
await temp.Stream
.WriteAsync(payload, 0, payload.Length, CancellationToken.None)
.ConfigureAwait(false);
#endif
}
public void Dispose()
{
// No-op (mock-only).
}
private void RegisterHandlers()
{
m_handlers[Methods.FileType_Close] = _ =>
{
CloseCount++;
return [];
};
m_handlers[Methods.FileType_Write] = _ => [];
m_handlers[Methods.FileType_SetPosition] = _ => [];
m_handlers[Methods.FileType_Read] = _ =>
[new Variant(Array.Empty<byte>().ToByteString())];
// GenerateFileForRead → (NodeId, uint handle, NodeId completionStateMachine).
m_handlers[Methods.TemporaryFileTransferType_GenerateFileForRead] = _ =>
[
new Variant(new NodeId(123)),
new Variant(7u),
new Variant(NodeId.Null)
];
// GenerateFileForWrite → (NodeId, uint handle).
m_handlers[Methods.TemporaryFileTransferType_GenerateFileForWrite] = _ =>
[
new Variant(new NodeId(123)),
new Variant(7u)
];
// CloseAndCommit → NodeId.
m_handlers[Methods.TemporaryFileTransferType_CloseAndCommit] = _ =>
{
CloseAndCommitCount++;
return [new Variant(new NodeId(99))];
};
}
}
}
}