Files
UA-.NETStandard/Tests/Opc.Ua.Server.Tests/Fluent/SimulationBuilderExtensionsTests.cs
Marc Schier 4d613d11dc CI: migrate to netstandard Managed DevOps Pool + per-TFM build matrix (#3866)
# Description

End-to-end migration of the Azure DevOps CI pipelines to the
`netstandard` Managed DevOps Pool with the build matrix re-shaped to fit
the new agents and a handful of test/project fixes that fell out of the
migration.

**Pipeline routing & defaults**

- `azure-pipelines.yml` and `azure-pipelines-preview.yml` default
`managedPool=true`, routing Windows/Linux jobs to the `netstandard`
Managed DevOps Pool with `ImageOverride` demands; flipping the
queue-time boolean to `false` falls back to Microsoft-hosted agents.
- Per-platform images come from the root yml (single source of truth):
- Managed pool: `windows-2022-g2` / `ubuntu-22.04-g2` (Mac stays hosted:
`macOS-15`).
  - Hosted: `windows-2025-vs2026` / `ubuntu-24.04` / `macOS-15`.
- `.azurepipelines/test.yml` and `test-aot.yml` declare `hosted` as a
typed `boolean` parameter so `not(parameters.hosted)` actually evaluates
correctly (an untyped value left it as the string `'false'`, which is
truthy and silently routed managed-pool jobs to Microsoft-hosted
`vmImage` demands).
- macOS test jobs always run on the Microsoft-hosted `macOS-15` image
regardless of `managedPool`; the four per-framework test stages queue a
dedicated `hosted: true` Mac invocation unconditionally and the main
matrix carries only Windows+Linux.
- Test-template prep jobs (which only run a PowerShell matrix script)
run on the managed pool whenever a `poolName` is set, even when the
matrix `hosted: true`, so the Microsoft-hosted parallel-job allotment
isn't blocked.

**Build stage — per-(TFM × configuration) matrix**

- `.azurepipelines/get-matrix.ps1` gained a `-Tfms` parameter that fans
the matrix across target frameworks alongside the existing agent /
configuration dimensions and emits a per-entry `targetTfm`.
- `.azurepipelines/sln.yml` accepts a `tfms` parameter and threads
`$(targetTfm)` into both `dotnet restore` and `dotnet build` as
`/p:CustomTestTarget=$(targetTfm)` so each matrix job builds a single
TFM and fits on the Managed DevOps Pool's small (~16 GB) temp disk.
- `azure-pipelines.yml` `build` stage passes `tfms: 'net10.0,net48'` for
PR builds and the full
`net472,net48,netstandard2.0,netstandard2.1,net8.0,net9.0,net10.0` set
for master / scheduled / manual / fork-PR runs.
- `sln.yml`'s restore step uses `command: custom` (`custom: restore`)
because `command: restore` silently drops the `arguments` input —
without it `/p:CustomTestTarget` never reached restore and
`obj/project.assets.json` was populated with the wrong TFM set.
- `sln.yml` no longer uses the `MSBuild@1` task; it now uses
`DotNetCoreCLI@2` with `dotnet build` so the .NET 10 SDK's bundled
MSBuild (which understands `.slnx`) is used instead of Visual Studio
2022's MSBuild on the managed-pool image.

**Project-level fixes that fell out of the matrix split**

- `Applications/McpServer`, `Applications/MinimalBoilerServer`,
`Applications/MinimalCalcServer`, and `Tests/Opc.Ua.Aot.Tests` each get
a `Directory.Build.targets` that turns the project into a no-op (cleared
`Compile` / `ProjectReference` / `PackageReference` / etc.,
`OutputType=Library`) when `CustomTestTarget` restricts the matrix to a
legacy TFM (`net4*` / `netstandard2.*`) the project can't target. Target
overrides are deliberately avoided — same-named targets in
`Directory.Build.targets` ALWAYS replace the SDK definitions, which
would silently break `dotnet publish` / `dotnet test` in the
unrestricted GitHub Actions flows.
- `Tools/Opc.Ua.MigrationAnalyzer.csproj`'s `ProjectReference` to
`Opc.Ua.MigrationAnalyzer.Core` no longer hard-pins
`SetTargetFramework=net10.0`; the pin follows `CustomTestTarget` (and
falls back to `net10.0` when unset).

**Test reliability**

-
`Tests/Opc.Ua.PubSub.Tests/IntervalRunnerTests.FakeTimeProviderDrivesDeterministicSchedulingAsync`
no longer calls a single `fake.Advance(300)` expecting three timers to
fire — it advances one 100 ms interval at a time and waits for each fire
(the runner only registers the next `Delay` after the previous callback
resumes on the thread pool; on slower CI agents the race surfaces
consistently).
- `Tests/Opc.Ua.Server.Tests/Fluent/SimulationBuilderExtensionsTests`
(four "expect ≥ N ticks in 150 ms" tests) replace fixed
`Task.Delay`/`Thread.Sleep` waits with a `WaitForAsync` polling helper,
eliminating thread-pool cold-start flakiness on slow agents (observed on
the hosted `macOS-15` runner).

## Related Issues

_No tracking issue — pipeline tuning to standardize on the netstandard
Managed DevOps Pool, plus the test/project follow-ups required for the
matrix to be green on that pool._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — pipeline +
test-reliability fixes; the two test fixes themselves were verified to
pass 5× in stress runs locally.)_
- [x] I have added all necessary documentation. _(Comments inline in the
new `Directory.Build.targets`, `sln.yml`, and `azure-pipelines.yml`
explain the unusual MSBuild/`DotNetCoreCLI@2` interactions for future
maintainers.)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [x] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(Verified
`dotnet build UA.slnx -p:CustomTestTarget=net10.0 -c Release` and
`-p:CustomTestTarget=net48 -c Debug` both complete with 0 errors;
targeted test runs for the two modified test files pass 5/5.)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
2026-06-10 17:19:41 +02:00

274 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Server.Fluent;
#nullable enable
#pragma warning disable CA2000
namespace Opc.Ua.Server.Tests.Fluent
{
/// <summary>
/// Tests for <see cref="SimulationBuilderExtensions"/> /
/// <see cref="ISimulationBuilder"/> — fluent simulation tick API.
/// </summary>
[TestFixture]
[Category("Fluent")]
public class SimulationBuilderExtensionsTests
{
private const ushort kNs = 2;
[Test]
public void SimulationRejectsNegativeInterval()
{
using var h = SimulationHarness.Create();
Assert.Throws<ArgumentOutOfRangeException>(
() => h.Builder.Simulation(TimeSpan.Zero));
Assert.Throws<ArgumentOutOfRangeException>(
() => h.Builder.Simulation(TimeSpan.FromMilliseconds(-1)));
}
[Test]
public void SimulationOnPlainBuilderThrowsBadConfigurationError()
{
using var h = SimulationHarness.CreateWithoutFluentBase();
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => h.Builder.Simulation(TimeSpan.FromMilliseconds(10)))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadConfigurationError));
}
[Test]
public async Task OnTickFiresPeriodically()
{
using var h = SimulationHarness.Create();
int ticks = 0;
h.Builder.Simulation(TimeSpan.FromMilliseconds(25))
.OnTick((ctx, dt) => Interlocked.Increment(ref ticks));
h.Builder.Seal();
await WaitForAsync(
() => Volatile.Read(ref ticks) >= 2,
"Tick should fire at least twice with a 25ms interval.")
.ConfigureAwait(false);
}
[Test]
public async Task AsyncOnTickIsAwaited()
{
using var h = SimulationHarness.Create();
int started = 0;
int completed = 0;
h.Builder.Simulation(TimeSpan.FromMilliseconds(25))
.OnTick(async (ctx, dt, ct) =>
{
Interlocked.Increment(ref started);
await Task.Delay(5, ct).ConfigureAwait(false);
Interlocked.Increment(ref completed);
});
h.Builder.Seal();
await WaitForAsync(() => Volatile.Read(ref started) >= 2).ConfigureAwait(false);
await WaitForAsync(() => Volatile.Read(ref completed) >= 2).ConfigureAwait(false);
}
[Test]
public async Task ExceptionInHandlerDoesNotKillLoop()
{
using var h = SimulationHarness.Create();
int ticks = 0;
h.Builder.Simulation(TimeSpan.FromMilliseconds(25))
.OnTick((ctx, dt) =>
{
int n = Interlocked.Increment(ref ticks);
if (n == 1)
{
throw new InvalidOperationException("boom");
}
});
h.Builder.Seal();
await WaitForAsync(
() => Volatile.Read(ref ticks) >= 3,
"Handler-thrown exception must not stop subsequent ticks.")
.ConfigureAwait(false);
}
[Test]
public void OnTickAfterSealRejected()
{
using var h = SimulationHarness.Create();
ISimulationBuilder sb = h.Builder.Simulation(TimeSpan.FromMilliseconds(100));
h.Builder.Seal();
// Adding a NEW simulation should be rejected after Seal/Start.
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => h.Builder.Simulation(TimeSpan.FromMilliseconds(100)))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadInvalidState));
}
[Test]
public void DisposeStopsRunningLoops()
{
var h = SimulationHarness.Create();
int ticks = 0;
h.Builder.Simulation(TimeSpan.FromMilliseconds(25))
.OnTick((ctx, dt) => Interlocked.Increment(ref ticks));
h.Builder.Seal();
Thread.Sleep(75);
h.Dispose();
int snapshot = Volatile.Read(ref ticks);
Thread.Sleep(75);
int afterDispose = Volatile.Read(ref ticks);
Assert.That(afterDispose, Is.EqualTo(snapshot).Within(1),
"No ticks should fire after Dispose (modulo one already-in-flight).");
}
[Test]
public async Task MultipleOnTickHandlersAllFire()
{
using var h = SimulationHarness.Create();
int handlerA = 0, handlerB = 0;
h.Builder.Simulation(TimeSpan.FromMilliseconds(25))
.OnTick((ctx, dt) => Interlocked.Increment(ref handlerA))
.OnTick((ctx, dt) => Interlocked.Increment(ref handlerB));
h.Builder.Seal();
await WaitForAsync(
() => Volatile.Read(ref handlerA) >= 2 && Volatile.Read(ref handlerB) >= 2)
.ConfigureAwait(false);
Assert.That(
Math.Abs(Volatile.Read(ref handlerA) - Volatile.Read(ref handlerB)),
Is.LessThanOrEqualTo(1),
"Both handlers fire on the same tick — counts should be in lockstep.");
}
private static async Task WaitForAsync(
Func<bool> condition,
string? message = null,
int timeoutMs = 5000)
{
DateTime end = DateTime.UtcNow + TimeSpan.FromMilliseconds(timeoutMs);
while (!condition())
{
if (DateTime.UtcNow > end)
{
Assert.Fail(
message ?? $"Condition not satisfied within {timeoutMs}ms.");
}
await Task.Delay(10).ConfigureAwait(false);
}
}
/// <summary>
/// Test harness — a FluentNodeManagerBase subclass + a NodeManagerBuilder
/// attached via AttachToBuilder.
/// </summary>
private sealed class SimulationHarness : IDisposable
{
internal NodeManagerBuilder Builder { get; private set; } = null!;
private TestFluentManager? m_manager;
private NodeManagerBuilder? m_plainBuilder;
internal static SimulationHarness Create()
{
var harness = new SimulationHarness
{
m_manager = new TestFluentManager()
};
ServerSystemContext ctx = harness.m_manager.SystemContext;
harness.Builder = new NodeManagerBuilder(
ctx,
harness.m_manager,
defaultNamespaceIndex: kNs,
rootResolver: _ => null!,
nodeIdResolver: _ => null!,
typeIdResolver: _ => []);
harness.m_manager.AttachToBuilder(harness.Builder);
return harness;
}
internal static SimulationHarness CreateWithoutFluentBase()
{
var harness = new SimulationHarness
{
m_plainBuilder = new NodeManagerBuilder(
new SystemContext(telemetry: null!) { NamespaceUris = new NamespaceTable() },
Mock.Of<IAsyncNodeManager>(),
defaultNamespaceIndex: kNs,
rootResolver: _ => null!,
nodeIdResolver: _ => null!,
typeIdResolver: _ => [])
};
harness.Builder = harness.m_plainBuilder;
return harness;
}
public void Dispose()
{
m_manager?.Dispose();
m_manager = null;
}
}
private sealed class TestFluentManager : FluentNodeManagerBase
{
public TestFluentManager()
: base(CreateMockServer(), TestNamespaceUri)
{
}
private const string TestNamespaceUri = "urn:test:simulation";
private static IServerInternal CreateMockServer()
{
var ns = new NamespaceTable();
ns.Append(Ua.Namespaces.OpcUa);
var mockTelemetry = new Mock<ITelemetryContext>();
var mock = new Mock<IServerInternal>();
mock.SetupGet(m => m.NamespaceUris).Returns(ns);
mock.SetupGet(m => m.Telemetry).Returns(mockTelemetry.Object);
IServiceMessageContext msgCtx = ServiceMessageContext.Create(mockTelemetry.Object);
mock.SetupGet(m => m.MessageContext).Returns(msgCtx);
mock.SetupGet(m => m.DefaultSystemContext).Returns(
new ServerSystemContext(mock.Object));
return mock.Object;
}
}
}
}