Files
Marc Schier e80d0ca9ac Use a 4-byte KeyNonce in the reference PubSub sample (#4710)
# Description

The first PubSub exchange in
[docs/PubSub.md](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/docs/PubSub.md#run-a-first-publisher-and-subscriber)
delivers no DataSets on master or in the 2.0.0 source. The subscriber
only logs `DataSetReader Reader 1 faulted on MessageReceiveTimeout`,
while the publisher logs `UADP security wrap failed; dropping message`
with `ArgumentException: AES-CTR nonce must be exactly 12 bytes` for
every NetworkMessage.

Cause: the reference PubSub sample's demo keys use a 12-byte KeyNonce.
Since #4573, the AES-CTR counter block follows OPC 10000-14 Table 157
(`KeyNonce[4] || MessageNonce[8] || BlockCounter[4]`). With the sample's
keys, the publisher builds a 20-byte nonce, and `AesCtrTransform`
rejects it. The 2.0.0 release (release/2.0 at bc5da1006) contains #4573
and the 12-byte sample, so it is affected too.

Fix: the sample sizes its KeyNonce with
`AesCtrNonceLayout.KeyNonceLength`. No SDK change.

Regression test:
`PubSubAotTests.SamplePublisherDeliversSecuredDataSetToSampleSubscriberAsync`
starts the sample publisher and subscriber with the sample keys over
unicast loopback and waits for a DataSet. The existing sample-based AOT
tests only built or started the applications, so nothing caught the
regression.

### Validation

| Command | Result |
| --- | --- |
| `tests\Opc.Ua.Aot.Tests\bin\Debug\net10.0\Opc.Ua.Aot.Tests.exe
--treenode-filter
"/*/*/PubSubAotTests/SamplePublisherDeliversSecuredDataSetToSampleSubscriberAsync"`
(JIT), before the fix | Failed: `TimeoutException`, no DataSet within 10
s |
| same, after the fix | Passed, 3 of 3 runs |
| `tests\Opc.Ua.Aot.Tests\bin\Debug\net10.0\Opc.Ua.Aot.Tests.exe
--treenode-filter "/*/*/PubSubAotTests/*"` | 8 of 8 passed |
| The two `dotnet run` commands of the docs/PubSub.md first exchange,
run verbatim | 15 DataSets in 15 s; the publisher logs no failures |

The release/2.0 branch has the same sample and would need a backport,
which is not part of this PR.

## Related Issues

- No tracking issue. Found while re-verifying the documented first
PubSub exchange after the 2.0.0 release.

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-10-09 15:17:01 +02:00

123 lines
5.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using Opc.Ua;
using Opc.Ua.PubSub.Security;
namespace Quickstarts.ConsoleReferencePubSubClient
{
/// <summary>
/// Demo-only shared symmetric key material wiring the reference
/// publisher and subscriber for <c>SignAndEncrypt</c> over the
/// <c>PubSub-Aes256-CTR</c> policy without an external Security Key
/// Service. The publisher and subscriber both build an identical
/// <see cref="StaticSecurityKeyProvider"/> from the constants below.
/// </summary>
/// <remarks>
/// The fixed keys here are a sample convenience ONLY. Production
/// deployments must source keys from a real SKS (see
/// <see href="https://reference.opcfoundation.org/specs/OPC-10000-14/v1.05.06/8.3">
/// Part 14 §8.3</see>) and never embed key material in source.
/// </remarks>
public static class SampleSecurity
{
/// <summary>
/// SecurityGroupId shared by the demo publisher and subscriber.
/// </summary>
public const string SecurityGroupId = "DemoSecurityGroup";
/// <summary>
/// Placeholder Security Key Service endpoint URL. The demo sources
/// keys from a local <see cref="StaticSecurityKeyProvider"/>, but
/// the configuration validator requires a secured group to declare
/// at least one SecurityKeyService endpoint per
/// <see href="https://reference.opcfoundation.org/specs/OPC-10000-14/v1.05.06/6.2.5.4">
/// Part 14 §6.2.5.4</see>.
/// </summary>
public const string SecurityKeyServiceUrl = "opc.tcp://localhost:4840/SecurityKeyService";
private const uint TokenId = 1U;
/// <summary>
/// Builds the shared static key provider. Identical on both the
/// publisher and subscriber so secured frames round-trip.
/// </summary>
/// <param name="timeProvider">Clock for the key ring.</param>
/// <returns>A configured key provider.</returns>
public static IPubSubSecurityKeyProvider CreateKeyProvider(
TimeProvider? timeProvider = null)
{
byte[] signingKey = BuildKey(0x10, 32);
byte[] encryptingKey = BuildKey(0x20, 32);
byte[] keyNonce = BuildKey(0x30, AesCtrNonceLayout.KeyNonceLength);
PubSubSecurityKey? key = null;
PubSubSecurityKeyRing? ring = null;
try
{
key = new PubSubSecurityKey(
TokenId,
ByteString.Create(signingKey),
ByteString.Create(encryptingKey),
ByteString.Create(keyNonce),
DateTimeUtc.From(DateTime.UtcNow),
TimeSpan.FromHours(24));
ring = new PubSubSecurityKeyRing(SecurityGroupId, timeProvider);
ring.SetCurrent(key);
// Ownership of the key transfers to the ring; null out the
// local so it is not disposed here on the success path.
key = null;
var provider = new StaticSecurityKeyProvider(SecurityGroupId, ring);
// Ownership of the ring transfers to the returned provider,
// which lives for the application lifetime.
ring = null;
return provider;
}
finally
{
ring?.Dispose();
key?.Dispose();
}
}
private static byte[] BuildKey(byte seed, int length)
{
byte[] bytes = new byte[length];
for (int i = 0; i < length; i++)
{
bytes[i] = (byte)((seed + (i * 7)) & 0xFF);
}
return bytes;
}
}
}