mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-17 05:11:13 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
492 lines
16 KiB
C#
492 lines
16 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using BenchmarkDotNet.Attributes;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Core.Encoders.Tests
|
|
{
|
|
/// <summary>
|
|
/// The element type of an array benchmark.
|
|
/// </summary>
|
|
public enum CodecArrayKind
|
|
{
|
|
String,
|
|
Int32,
|
|
Double,
|
|
NodeId,
|
|
Variant,
|
|
DataValue,
|
|
ExtensionObject,
|
|
Encodeable,
|
|
EncodeableByTypeId
|
|
}
|
|
|
|
/// <summary>
|
|
/// The message of a message benchmark.
|
|
/// </summary>
|
|
public enum CodecMessageKind
|
|
{
|
|
ReadResponse,
|
|
PublishResponse,
|
|
NestedVariant
|
|
}
|
|
|
|
/// <summary>
|
|
/// Shared setup of the binary codec benchmarks.
|
|
/// </summary>
|
|
public abstract class BinaryCodecBenchmarkBase
|
|
{
|
|
protected static ServiceMessageContext CreateContext()
|
|
{
|
|
ServiceMessageContext context = ServiceMessageContext.Create(NUnitTelemetryContext.Create());
|
|
context.MaxArrayLength = 10_000_000;
|
|
context.MaxMessageSize = 256 * 1024 * 1024;
|
|
return context;
|
|
}
|
|
|
|
protected static readonly DateTimeUtc s_timestamp =
|
|
new DateTime(2024, 03, 01, 06, 05, 59, DateTimeKind.Utc);
|
|
|
|
protected static Variant CreateScalarVariant(int ii)
|
|
{
|
|
return (ii % 5) switch
|
|
{
|
|
0 => new Variant(ii),
|
|
1 => new Variant(ii * 0.5),
|
|
2 => new Variant("Value" + ii),
|
|
3 => new Variant(ii % 2 == 0),
|
|
_ => new Variant(s_timestamp)
|
|
};
|
|
}
|
|
|
|
protected static DataValue CreateDataValue(int ii)
|
|
{
|
|
return new DataValue(
|
|
new Variant(ii * 0.25),
|
|
ii % 10 == 0 ? StatusCodes.UncertainLastUsableValue : StatusCodes.Good,
|
|
s_timestamp,
|
|
s_timestamp);
|
|
}
|
|
|
|
protected static NodeId CreateNodeId(int ii)
|
|
{
|
|
return ii % 2 == 0
|
|
? new NodeId((uint)(1000 + ii), 2)
|
|
: new NodeId("Channel1.Device1.Tag" + ii, 3);
|
|
}
|
|
|
|
protected static ReadValueId CreateReadValueId(int ii)
|
|
{
|
|
return new ReadValueId
|
|
{
|
|
NodeId = CreateNodeId(ii),
|
|
AttributeId = Attributes.Value
|
|
};
|
|
}
|
|
|
|
protected ServiceMessageContext m_context = null!;
|
|
protected MemoryStream m_stream = null!;
|
|
protected byte[] m_encoded = null!;
|
|
protected int m_sink;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Encodes and decodes one large array of an element type with the
|
|
/// binary codec.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("BinaryEncoder")]
|
|
[NonParallelizable]
|
|
[MemoryDiagnoser]
|
|
public class BinaryCodecArrayBenchmarks : BinaryCodecBenchmarkBase
|
|
{
|
|
[ParamsAllValues]
|
|
public CodecArrayKind Kind { get; set; }
|
|
|
|
[Params(16, 1024, 100_000)]
|
|
public int Count { get; set; } = 16;
|
|
|
|
[GlobalSetup]
|
|
public void GlobalSetup()
|
|
{
|
|
m_context = CreateContext();
|
|
m_strings = new string[Count];
|
|
m_int32s = new int[Count];
|
|
m_doubles = new double[Count];
|
|
m_nodeIds = new NodeId[Count];
|
|
m_variants = new Variant[Count];
|
|
m_dataValues = new DataValue[Count];
|
|
m_extensionObjects = new ExtensionObject[Count];
|
|
m_readValueIds = new ReadValueId[Count];
|
|
for (int ii = 0; ii < Count; ii++)
|
|
{
|
|
m_strings[ii] = "Channel1.Device1.Tag" + ii;
|
|
m_int32s[ii] = ii * 7;
|
|
m_doubles[ii] = ii * 0.5;
|
|
m_nodeIds[ii] = CreateNodeId(ii);
|
|
m_variants[ii] = CreateScalarVariant(ii);
|
|
m_dataValues[ii] = CreateDataValue(ii);
|
|
m_readValueIds[ii] = CreateReadValueId(ii);
|
|
m_extensionObjects[ii] = new ExtensionObject(m_readValueIds[ii]);
|
|
}
|
|
|
|
using var encoder = new BinaryEncoder(m_context);
|
|
WriteArray(encoder);
|
|
m_encoded = encoder.CloseAndReturnBuffer()!;
|
|
m_stream = new MemoryStream(m_encoded!.Length * 2);
|
|
}
|
|
|
|
[GlobalCleanup]
|
|
public void GlobalCleanup()
|
|
{
|
|
m_stream?.Dispose();
|
|
}
|
|
|
|
[Benchmark]
|
|
public void Encode()
|
|
{
|
|
m_stream.Position = 0;
|
|
using var encoder = new BinaryEncoder(m_stream, m_context, true);
|
|
WriteArray(encoder);
|
|
}
|
|
|
|
[Benchmark]
|
|
public int Decode()
|
|
{
|
|
using var decoder = new BinaryDecoder(m_encoded, m_context);
|
|
return m_sink = ReadArray(decoder);
|
|
}
|
|
|
|
[Test]
|
|
public void ArraysRoundTrip([Values] CodecArrayKind kind)
|
|
{
|
|
Kind = kind;
|
|
GlobalSetup();
|
|
try
|
|
{
|
|
Encode();
|
|
Assert.That(Decode(), Is.EqualTo(Count));
|
|
}
|
|
finally
|
|
{
|
|
GlobalCleanup();
|
|
}
|
|
}
|
|
|
|
private void WriteArray(BinaryEncoder encoder)
|
|
{
|
|
switch (Kind)
|
|
{
|
|
case CodecArrayKind.String:
|
|
encoder.WriteStringArray(null, m_strings);
|
|
break;
|
|
case CodecArrayKind.Int32:
|
|
encoder.WriteInt32Array(null, m_int32s);
|
|
break;
|
|
case CodecArrayKind.Double:
|
|
encoder.WriteDoubleArray(null, m_doubles);
|
|
break;
|
|
case CodecArrayKind.NodeId:
|
|
encoder.WriteNodeIdArray(null, m_nodeIds);
|
|
break;
|
|
case CodecArrayKind.Variant:
|
|
encoder.WriteVariantArray(null, m_variants);
|
|
break;
|
|
case CodecArrayKind.DataValue:
|
|
encoder.WriteDataValueArray(null, m_dataValues);
|
|
break;
|
|
case CodecArrayKind.ExtensionObject:
|
|
encoder.WriteExtensionObjectArray(null, m_extensionObjects);
|
|
break;
|
|
case CodecArrayKind.Encodeable:
|
|
case CodecArrayKind.EncodeableByTypeId:
|
|
encoder.WriteEncodeableArray(null, (ArrayOf<ReadValueId>)m_readValueIds);
|
|
break;
|
|
default:
|
|
throw new InvalidOperationException($"Unsupported array kind {Kind}.");
|
|
}
|
|
}
|
|
|
|
private int ReadArray(BinaryDecoder decoder)
|
|
{
|
|
return Kind switch
|
|
{
|
|
CodecArrayKind.String => decoder.ReadStringArray(null).Count,
|
|
CodecArrayKind.Int32 => decoder.ReadInt32Array(null).Count,
|
|
CodecArrayKind.Double => decoder.ReadDoubleArray(null).Count,
|
|
CodecArrayKind.NodeId => decoder.ReadNodeIdArray(null).Count,
|
|
CodecArrayKind.Variant => decoder.ReadVariantArray(null).Count,
|
|
CodecArrayKind.DataValue => decoder.ReadDataValueArray(null).Count,
|
|
CodecArrayKind.ExtensionObject => decoder.ReadExtensionObjectArray(null).Count,
|
|
CodecArrayKind.Encodeable => decoder.ReadEncodeableArray<ReadValueId>(null).Count,
|
|
CodecArrayKind.EncodeableByTypeId => decoder.ReadEncodeableArray<ReadValueId>(
|
|
null,
|
|
DataTypeIds.ReadValueId).Count,
|
|
_ => throw new InvalidOperationException($"Unsupported array kind {Kind}.")
|
|
};
|
|
}
|
|
|
|
private string[] m_strings = null!;
|
|
private int[] m_int32s = null!;
|
|
private double[] m_doubles = null!;
|
|
private NodeId[] m_nodeIds = null!;
|
|
private Variant[] m_variants = null!;
|
|
private DataValue[] m_dataValues = null!;
|
|
private ExtensionObject[] m_extensionObjects = null!;
|
|
private ReadValueId[] m_readValueIds = null!;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Encodes and decodes many scalar Variants one by one.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("BinaryEncoder")]
|
|
[NonParallelizable]
|
|
[MemoryDiagnoser]
|
|
public class BinaryCodecScalarVariantBenchmarks : BinaryCodecBenchmarkBase
|
|
{
|
|
[Params(1000)]
|
|
public int Count { get; set; } = 1000;
|
|
|
|
[GlobalSetup]
|
|
[OneTimeSetUp]
|
|
public void GlobalSetup()
|
|
{
|
|
m_context = CreateContext();
|
|
m_variants = new Variant[Count];
|
|
for (int ii = 0; ii < Count; ii++)
|
|
{
|
|
m_variants[ii] = CreateScalarVariant(ii);
|
|
}
|
|
using var encoder = new BinaryEncoder(m_context);
|
|
WriteVariants(encoder);
|
|
m_encoded = encoder.CloseAndReturnBuffer()!;
|
|
m_stream = new MemoryStream(m_encoded!.Length * 2);
|
|
}
|
|
|
|
[GlobalCleanup]
|
|
[OneTimeTearDown]
|
|
public void GlobalCleanup()
|
|
{
|
|
m_stream?.Dispose();
|
|
}
|
|
|
|
[Benchmark]
|
|
[Test]
|
|
public void EncodeScalarVariants()
|
|
{
|
|
m_stream.Position = 0;
|
|
using var encoder = new BinaryEncoder(m_stream, m_context, true);
|
|
WriteVariants(encoder);
|
|
}
|
|
|
|
[Benchmark]
|
|
[Test]
|
|
public void DecodeScalarVariants()
|
|
{
|
|
using var decoder = new BinaryDecoder(m_encoded, m_context);
|
|
int count = 0;
|
|
for (int ii = 0; ii < Count; ii++)
|
|
{
|
|
if (!decoder.ReadVariant(null).IsNull)
|
|
{
|
|
count++;
|
|
}
|
|
}
|
|
m_sink = count;
|
|
}
|
|
|
|
private void WriteVariants(BinaryEncoder encoder)
|
|
{
|
|
for (int ii = 0; ii < m_variants.Length; ii++)
|
|
{
|
|
encoder.WriteVariant(null, m_variants[ii]);
|
|
}
|
|
}
|
|
|
|
private Variant[] m_variants;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Encodes and decodes realistic service messages and a nested
|
|
/// Variant structure.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("BinaryEncoder")]
|
|
[NonParallelizable]
|
|
[MemoryDiagnoser]
|
|
public class BinaryCodecMessageBenchmarks : BinaryCodecBenchmarkBase
|
|
{
|
|
[ParamsAllValues]
|
|
public CodecMessageKind Kind { get; set; }
|
|
|
|
[Params(100, 10_000)]
|
|
public int Count { get; set; } = 100;
|
|
|
|
[GlobalSetup]
|
|
public void GlobalSetup()
|
|
{
|
|
m_context = CreateContext();
|
|
m_message = Kind switch
|
|
{
|
|
CodecMessageKind.ReadResponse => CreateReadResponse(Count),
|
|
CodecMessageKind.PublishResponse => CreatePublishResponse(Count),
|
|
CodecMessageKind.NestedVariant => CreateNestedVariant(Count),
|
|
_ => throw new InvalidOperationException($"Unsupported message kind {Kind}.")
|
|
};
|
|
m_encoded = BinaryEncoder.EncodeMessage(m_message, m_context);
|
|
m_stream = new MemoryStream(m_encoded.Length * 2);
|
|
}
|
|
|
|
[GlobalCleanup]
|
|
public void GlobalCleanup()
|
|
{
|
|
m_stream?.Dispose();
|
|
}
|
|
|
|
[Benchmark]
|
|
public void EncodeMessage()
|
|
{
|
|
m_stream.Position = 0;
|
|
BinaryEncoder.EncodeMessage(m_message, m_stream, m_context, true);
|
|
}
|
|
|
|
[Benchmark]
|
|
public IEncodeable DecodeMessage()
|
|
{
|
|
return BinaryDecoder.DecodeMessage<IEncodeable>(m_encoded, m_context);
|
|
}
|
|
|
|
[Benchmark]
|
|
public IEncodeable DecodeMessageFromStream()
|
|
{
|
|
using var stream = new MemoryStream(m_encoded, false);
|
|
return BinaryDecoder.DecodeMessage<IEncodeable>(stream, m_context);
|
|
}
|
|
|
|
[Test]
|
|
public void MessagesRoundTrip([Values] CodecMessageKind kind)
|
|
{
|
|
Kind = kind;
|
|
GlobalSetup();
|
|
try
|
|
{
|
|
EncodeMessage();
|
|
Assert.That(DecodeMessage(), Is.EqualTo(m_message));
|
|
Assert.That(DecodeMessageFromStream(), Is.EqualTo(m_message));
|
|
}
|
|
finally
|
|
{
|
|
GlobalCleanup();
|
|
}
|
|
}
|
|
|
|
private static ReadResponse CreateReadResponse(int count)
|
|
{
|
|
var results = new DataValue[count];
|
|
for (int ii = 0; ii < count; ii++)
|
|
{
|
|
results[ii] = CreateDataValue(ii);
|
|
}
|
|
return new ReadResponse
|
|
{
|
|
ResponseHeader = new ResponseHeader { Timestamp = s_timestamp, RequestHandle = 42 },
|
|
Results = results
|
|
};
|
|
}
|
|
|
|
private static PublishResponse CreatePublishResponse(int count)
|
|
{
|
|
var items = new MonitoredItemNotification[count];
|
|
for (int ii = 0; ii < count; ii++)
|
|
{
|
|
items[ii] = new MonitoredItemNotification
|
|
{
|
|
ClientHandle = (uint)ii,
|
|
Value = CreateDataValue(ii)
|
|
};
|
|
}
|
|
var notification = new DataChangeNotification { MonitoredItems = items };
|
|
return new PublishResponse
|
|
{
|
|
ResponseHeader = new ResponseHeader { Timestamp = s_timestamp, RequestHandle = 43 },
|
|
SubscriptionId = 7,
|
|
AvailableSequenceNumbers = new uint[] { 11, 12 },
|
|
NotificationMessage = new NotificationMessage
|
|
{
|
|
SequenceNumber = 12,
|
|
PublishTime = s_timestamp,
|
|
NotificationData = new ExtensionObject[] { new(notification) }
|
|
}
|
|
};
|
|
}
|
|
|
|
/// <summary>
|
|
/// A write request whose values are Variant arrays of Variant arrays
|
|
/// that hold DataValues and ExtensionObjects.
|
|
/// </summary>
|
|
private static WriteRequest CreateNestedVariant(int count)
|
|
{
|
|
var nodesToWrite = new WriteValue[Math.Max(1, count / 100)];
|
|
for (int jj = 0; jj < nodesToWrite.Length; jj++)
|
|
{
|
|
var outer = new Variant[100];
|
|
for (int ii = 0; ii < outer.Length; ii++)
|
|
{
|
|
var inner = new Variant[]
|
|
{
|
|
CreateScalarVariant(ii),
|
|
new(CreateDataValue(ii)),
|
|
new(new ExtensionObject(CreateReadValueId(ii))),
|
|
new(new Variant[] { CreateScalarVariant(ii + 1), CreateScalarVariant(ii + 2) })
|
|
};
|
|
outer[ii] = new Variant(inner);
|
|
}
|
|
nodesToWrite[jj] = new WriteValue
|
|
{
|
|
NodeId = CreateNodeId(jj),
|
|
AttributeId = Attributes.Value,
|
|
Value = new DataValue(new Variant(outer))
|
|
};
|
|
}
|
|
return new WriteRequest
|
|
{
|
|
RequestHeader = new RequestHeader { Timestamp = s_timestamp, RequestHandle = 44 },
|
|
NodesToWrite = nodesToWrite
|
|
};
|
|
}
|
|
|
|
private IEncodeable m_message = null!;
|
|
}
|
|
}
|