Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

276 lines
12 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using System.Text;
using Microsoft.Extensions.Logging;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Core.Tests.Stack.Server
{
/// <summary>
/// Tests for <see cref="RequestHandleReader"/> and the ServiceFault it feeds
/// (OPC 10000-4 §7.33: the requestHandle should be echoed even for a request
/// that is not valid).
/// </summary>
[TestFixture]
[Category("Server")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public class RequestHandleReaderTests
{
private const uint kRequestHandle = 4711;
private const int kDecodeMaxStringLength = 100;
private ITelemetryContext m_telemetry = null!;
[SetUp]
public void SetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
}
[TestCase(false)]
[TestCase(true)]
public void FromBinaryReadsHandleOfRequestAboveMaxStringLength(bool stringAuthenticationToken)
{
ReadRequest request = CreateOversizedRequest(stringAuthenticationToken);
byte[] message = BinaryEncoder.EncodeMessage(request, CreateContext(0));
ServiceMessageContext decodeContext = CreateContext(kDecodeMaxStringLength);
// the request itself cannot be decoded
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => BinaryDecoder.DecodeMessage<IServiceRequest>(message, decodeContext))!;
Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadEncodingLimitsExceeded));
Assert.That(RequestHandleReader.FromBinary(message), Is.EqualTo(kRequestHandle));
using var stream = new MemoryStream(message);
Assert.That(RequestHandleReader.FromBinary(stream), Is.EqualTo(kRequestHandle));
}
/// <summary>
/// The AuthenticationToken itself can be the field the decoder rejects;
/// the reader skips it by its encoded length.
/// </summary>
[TestCase(false)]
[TestCase(true)]
public void FromBinaryReadsHandleWhenAuthenticationTokenIsAboveLimits(bool byteStringToken)
{
ReadRequest request = CreateOversizedRequest(false);
request.RequestHeader.AuthenticationToken = byteStringToken
? new NodeId(ByteString.From(new byte[10 * kDecodeMaxStringLength]), 2)
: new NodeId(new string('t', 10 * kDecodeMaxStringLength), 2);
byte[] message = BinaryEncoder.EncodeMessage(request, CreateContext(0));
ServiceMessageContext decodeContext = CreateContext(kDecodeMaxStringLength);
decodeContext.MaxByteStringLength = kDecodeMaxStringLength;
Assert.That(
() => BinaryDecoder.DecodeMessage<IServiceRequest>(message, decodeContext),
Throws.TypeOf<ServiceResultException>());
Assert.That(RequestHandleReader.FromBinary(message), Is.EqualTo(kRequestHandle));
}
[Test]
public void FromBinaryReadsHandleFromArraySegmentAndNonSeekableStream()
{
byte[] message = BinaryEncoder.EncodeMessage(CreateOversizedRequest(true), CreateContext(0));
byte[] framed = new byte[message.Length + 16];
message.CopyTo(framed, 8);
Assert.That(
RequestHandleReader.FromBinary(new ArraySegment<byte>(framed, 8, message.Length)),
Is.EqualTo(kRequestHandle));
Assert.That(RequestHandleReader.FromBinary(default(ArraySegment<byte>)), Is.Zero);
using var nonSeekable = new NonSeekableStream(message);
Assert.That(RequestHandleReader.FromBinary(nonSeekable), Is.EqualTo(kRequestHandle));
}
[TestCase(new byte[] { 0x40, 0x00 })]
[TestCase(new byte[] { 0x80, 0x00 })]
[TestCase(new byte[] { 0x06, 0x00 })]
[TestCase(new byte[] { 0x03, 0x00, 0x00, 0xFE, 0xFF, 0xFF, 0xFF })]
[TestCase(new byte[] { 0x03, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x41 })]
public void FromBinaryReturnsZeroForInvalidNodeIdEncoding(byte[] message)
{
Assert.That(RequestHandleReader.FromBinary(message), Is.Zero);
}
[Test]
public void FromBinaryReturnsZeroForFailingOrTruncatedNonSeekableStream()
{
byte[] message = BinaryEncoder.EncodeMessage(CreateOversizedRequest(true), CreateContext(0));
using var throwing = new ThrowingStream();
Assert.That(RequestHandleReader.FromBinary(throwing), Is.Zero);
using var truncated = new NonSeekableStream(message.AsSpan(0, 10).ToArray());
Assert.That(RequestHandleReader.FromBinary(truncated), Is.Zero);
using var truncatedHandle = new NonSeekableStream(message.AsSpan(0, message.Length - 50).ToArray());
Assert.That(RequestHandleReader.FromBinary(truncatedHandle), Is.EqualTo(kRequestHandle));
// encoding id (four byte, 4) + token "session-token" (1 + 2 + 4 + 13)
// + timestamp (8): the handle starts at offset 32.
Assert.That(BitConverter.ToUInt32(message, 32), Is.EqualTo(kRequestHandle));
using var shortHandle = new MemoryStream(message.AsSpan(0, 34).ToArray());
Assert.That(RequestHandleReader.FromBinary(shortHandle), Is.Zero);
}
[TestCase(0)]
[TestCase(3)]
[TestCase(12)]
public void FromBinaryReturnsZeroForTruncatedMessage(int length)
{
byte[] message = BinaryEncoder.EncodeMessage(CreateOversizedRequest(false), CreateContext(0));
Assert.That(
RequestHandleReader.FromBinary(message.AsSpan(0, length).ToArray()),
Is.Zero);
}
[Test]
public void FromBinaryReturnsZeroForNull()
{
Assert.That(RequestHandleReader.FromBinary((byte[]?)null), Is.Zero);
Assert.That(RequestHandleReader.FromBinary((Stream?)null), Is.Zero);
}
[Test]
public void FromJsonReadsHandleOfEncodedRequest()
{
ReadRequest request = CreateOversizedRequest(stringAuthenticationToken: true);
foreach (JsonEncoderOptions options in new[] { JsonEncoderOptions.Compact, JsonEncoderOptions.Verbose })
{
using var memory = new MemoryStream();
using (var encoder = new JsonEncoder(memory, CreateContext(0), options))
{
encoder.EncodeMessage(request, request.TypeId);
}
Assert.That(RequestHandleReader.FromJson(memory.ToArray()), Is.EqualTo(kRequestHandle));
}
}
[TestCase("{\"UaTypeId\":\"i=629\",\"RequestHeader\":{\"RequestHandle\":42}}", 42u)]
[TestCase("{\"NodesToRead\":[],\"RequestHeader\":{\"Timestamp\":\"x\",\"RequestHandle\":42},\"UaTypeId\":\"i=629\"}", 42u)]
[TestCase("{\"Other\":{\"RequestHandle\":1},\"RequestHeader\":{\"RequestHandle\":42}}", 42u)]
[TestCase("{\"List\":[{\"RequestHeader\":{\"RequestHandle\":1}}],\"RequestHeader\":{\"RequestHandle\":42}}", 42u)]
[TestCase("{\"RequestHeader\":{\"RequestHandle\":42}, broken", 42u)]
[TestCase("{\"UaBody\":{\"RequestHeader\":{\"RequestHandle\":42}}}", 0u)]
[TestCase("{\"Other\":{\"RequestHeader\":{\"RequestHandle\":42}}}", 0u)]
[TestCase("{\"RequestHandle\":42}", 0u)]
[TestCase("{\"RequestHeader\":{\"RequestHandle\":\"42\"}}", 0u)]
[TestCase("{\"RequestHeader\":{\"RequestHandle\":-1}}", 0u)]
[TestCase("{\"RequestHeader\": broken {\"RequestHandle\":42}}", 0u)]
[TestCase("", 0u)]
[TestCase("junk!", 0u)]
public void FromJsonFindsOnlyTheRequestHeaderHandle(string json, uint expected)
{
Assert.That(RequestHandleReader.FromJson(Encoding.UTF8.GetBytes(json)), Is.EqualTo(expected));
}
[Test]
public void CreateFaultEchoesRequestHandleOfUndecodedRequest()
{
ILogger logger = m_telemetry.CreateLogger<RequestHandleReaderTests>();
DateTime before = DateTime.UtcNow.AddSeconds(-1);
ServiceFault fault = EndpointBase.CreateFault(
logger,
null,
new ServiceResultException(StatusCodes.BadEncodingLimitsExceeded),
kRequestHandle);
Assert.That(fault.ResponseHeader.RequestHandle, Is.EqualTo(kRequestHandle));
Assert.That(fault.ResponseHeader.ServiceResult, Is.EqualTo(StatusCodes.BadEncodingLimitsExceeded));
Assert.That((DateTime)fault.ResponseHeader.Timestamp, Is.GreaterThan(before));
// the handle of a decoded request takes precedence
fault = EndpointBase.CreateFault(
logger,
new ReadRequest { RequestHeader = new RequestHeader { RequestHandle = 7 } },
new ServiceResultException(StatusCodes.BadSecurityPolicyRejected),
kRequestHandle);
Assert.That(fault.ResponseHeader.RequestHandle, Is.EqualTo(7u));
}
private sealed class ThrowingStream : MemoryStream
{
public override int ReadByte()
{
throw new IOException("read failed");
}
}
private sealed class NonSeekableStream : MemoryStream
{
public NonSeekableStream(byte[] buffer)
: base(buffer, writable: false)
{
}
public override bool CanSeek => false;
}
private ServiceMessageContext CreateContext(int maxStringLength)
{
ServiceMessageContext context = ServiceMessageContext.Create(m_telemetry);
context.MaxStringLength = maxStringLength;
context.MaxMessageSize = 0;
return context;
}
private static ReadRequest CreateOversizedRequest(bool stringAuthenticationToken)
{
return new ReadRequest
{
RequestHeader = new RequestHeader
{
AuthenticationToken = stringAuthenticationToken
? new NodeId("session-token", 0)
: new NodeId(Guid.NewGuid(), 1),
Timestamp = DateTime.UtcNow,
RequestHandle = kRequestHandle,
TimeoutHint = 10000
},
NodesToRead =
[
new ReadValueId
{
NodeId = new NodeId(new string('n', 10 * kDecodeMaxStringLength), 1),
AttributeId = Attributes.Value
}
]
};
}
}
}