Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

265 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2000: test code; many disposables are ownership-transferred to test fixtures or short-lived,
// making CA2000 noisy without a real leak risk. Disabled file-level for the suite.
#pragma warning disable CA2000
using System;
using System.Collections.Generic;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Core.Tests.Stack.State
{
/// <summary>
/// Tests that <see cref="ProgramStateMachineState"/> wires the cause
/// methods it ships handlers for. Part 3 §5.7 defines
/// <c>Executable</c> / <c>UserExecutable</c> as "may this Method be
/// called right now", which for a Part 16 cause is
/// <see cref="FiniteStateMachineState.IsCausePermitted"/>; left
/// unwired the attributes stay at the <c>true</c> the node was
/// constructed with and a client can only discover which causes
/// apply by calling one and being refused.
/// </summary>
[TestFixture]
[Category("ProgramStateMachineState")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public class ProgramStateMachineStateTests
{
private const ushort kNs = 2;
private ISystemContext m_context;
private ITelemetryContext m_telemetry;
[OneTimeSetUp]
protected void OneTimeSetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
var messageContext = ServiceMessageContext.Create(m_telemetry);
messageContext.NamespaceUris.GetIndexOrAppend(Namespaces.OpcUa);
m_context = new SystemContext(m_telemetry)
{
NamespaceUris = messageContext.NamespaceUris
};
}
[OneTimeTearDown]
protected void OneTimeTearDown()
{
(m_context as IDisposable)?.Dispose();
}
[Test]
public void CauseMethodsReportExecutableFromTheCurrentState()
{
ProgramStateMachineState machine = CreateMachine(
out MethodState start, out MethodState halt);
// The machine starts in Ready: Start applies, Halt applies,
// Reset (Halted only) does not.
Assert.Multiple(() =>
{
Assert.That(ReadAttribute(start, Attributes.Executable), Is.True);
Assert.That(ReadAttribute(start, Attributes.UserExecutable), Is.True);
Assert.That(ReadAttribute(halt, Attributes.Executable), Is.True);
});
machine.SetState(m_context, Objects.ProgramStateMachineType_Halted);
Assert.Multiple(() =>
{
Assert.That(ReadAttribute(start, Attributes.Executable), Is.False);
Assert.That(ReadAttribute(start, Attributes.UserExecutable), Is.False);
Assert.That(ReadAttribute(halt, Attributes.Executable), Is.False);
});
}
[Test]
public void CauseMethodsAreBoundToTheMatchingCause()
{
ProgramStateMachineState machine = CreateMachine(
out MethodState start, out _);
Assert.That(start.OnCallMethod, Is.Not.Null);
ServiceResult result = start.OnCallMethod!(
m_context, start, inputArguments: default, outputArguments: []);
Assert.That(ServiceResult.IsGood(result), Is.True, $"Start must succeed: {result}");
Assert.That(CurrentStateId(machine),
Is.EqualTo(Objects.ProgramStateMachineType_Running));
}
[Test]
public void MethodsAddedAfterCreateAreWiredOnDemand()
{
ProgramStateMachineState machine = CreateMachine(out _, out _);
// Create rebuilds the child list from the type template, so
// a method materialized afterwards has to be wired by the
// server — the public entry point exists for exactly that.
MethodState reset = AddMethod(machine, BrowseNames.Reset, "Machine_Reset");
Assert.That(reset.OnReadExecutable, Is.Null);
machine.WireCauseMethods(m_context);
// The machine is in Ready, and Reset is a cause of Halted.
Assert.Multiple(() =>
{
Assert.That(reset.OnCallMethod, Is.Not.Null);
Assert.That(ReadAttribute(reset, Attributes.Executable), Is.False);
});
machine.SetState(m_context, Objects.ProgramStateMachineType_Halted);
Assert.That(ReadAttribute(reset, Attributes.Executable), Is.True);
}
/// <summary>
/// Part 5 6.4.3: a cause refused in the current state is audited with Status FALSE
/// and is not reported as a program transition.
/// </summary>
[Test]
public void RefusedCauseIsAuditedAsFailed()
{
ProgramStateMachineState machine = CreateMachine(out MethodState start, out _);
machine.SetState(m_context, Objects.ProgramStateMachineType_Halted);
var events = new List<IFilterTarget>();
machine.SetAreEventsMonitored(m_context, true, false);
machine.OnReportEvent = (_, _, e) => events.Add(e);
ServiceResult result = machine.DoCause(
m_context, start, Methods.ProgramStateMachineType_Start, default, []);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadNotSupported));
Assert.That(events, Has.Count.EqualTo(1));
Assert.That(events[0], Is.InstanceOf<AuditUpdateStateEventState>());
Assert.That(((AuditUpdateStateEventState)events[0]).Status!.Value, Is.False);
}
/// <summary>
/// Builds a machine with two of the five optional cause methods
/// declared, so the test also covers the "only the materialized
/// ones are wired" half.
/// </summary>
private TestProgramStateMachineState CreateMachine(
out MethodState start,
out MethodState halt)
{
var machine = new TestProgramStateMachineState
{
NodeId = new NodeId("Machine", kNs),
BrowseName = new QualifiedName("Machine", kNs),
DisplayName = new LocalizedText("Machine")
};
machine.Create(
m_context,
machine.NodeId,
machine.BrowseName,
displayName: machine.DisplayName,
assignNodeIds: false);
start = machine.Start;
halt = machine.Halt;
return machine;
}
private static MethodState AddMethod(
ProgramStateMachineState machine,
string browseName,
string nodeIdentifier)
{
// Executable / UserExecutable default to true on a freshly
// constructed node — the very value the fix has to replace.
var method = new MethodState(machine)
{
ReferenceTypeId = ReferenceTypeIds.HasComponent,
NodeId = new NodeId(nodeIdentifier, kNs),
BrowseName = new QualifiedName(browseName, kNs),
DisplayName = new LocalizedText(browseName),
Executable = true,
UserExecutable = true
};
machine.AddChild(method);
return method;
}
/// <summary>
/// Stands in for a generator-emitted subclass whose model
/// declares two of the optional cause methods. They have to be
/// materialized in <see cref="InitializeOptionalChildren"/>
/// because <see cref="NodeState.Create(ISystemContext, NodeId,
/// QualifiedName, LocalizedText, bool)"/> rebuilds the child
/// list from the type template.
/// </summary>
private sealed class TestProgramStateMachineState : ProgramStateMachineState
{
public TestProgramStateMachineState()
: base(parent: null)
{
}
public MethodState Start { get; private set; } = null!;
public MethodState Halt { get; private set; } = null!;
protected override void InitializeOptionalChildren(ISystemContext context)
{
base.InitializeOptionalChildren(context);
Start = AddMethod(this, BrowseNames.Start, "Machine_Start");
Halt = AddMethod(this, BrowseNames.Halt, "Machine_Halt");
}
}
private bool ReadAttribute(MethodState method, uint attributeId)
{
var value = new DataValue();
ServiceResult result = method.ReadAttribute(
m_context, attributeId, default, default, ref value);
Assert.That(ServiceResult.IsGood(result), Is.True,
$"read of {Attributes.GetBrowseName(attributeId)} failed: {result}");
Assert.That(value.WrappedValue.TryGetValue(out bool flag), Is.True,
$"{Attributes.GetBrowseName(attributeId)} must read as a Boolean.");
return flag;
}
private static uint CurrentStateId(ProgramStateMachineState machine)
{
NodeId stateNodeId = machine.CurrentState!.Id!.Value;
return stateNodeId.TryGetValue(out uint id) ? id : 0;
}
}
}