mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 04:59:55 +08:00
# Description Remove stock phrasing and correct misleading or inconsistent technical documentation. The initial two passes covered 367 Markdown files, followed by an interactive review of 169 editorial flags. The U5 interpretation originally deferred in that review has since received the upstream Mantis answer recorded by #4843; remaining server/spec follow-ups stay explicit in the CTT log. - Correct package responsibilities, migration steps, API names, ownership, protocol descriptions and links. Keep bundled migration guides synchronized. Preserve historical conclusions as historical records with separate re-check notes. - Provide at least two rendered TOC levels throughout `docs/`. Convert appropriate architecture figures to Mermaid without changing code examples, transcripts or historical quotations. - Address the October 19 feedback with concrete setup/migration instructions, corrected certificate paths and PubSub names, shorter repeated caveats, consistent XML comments, and a full review of the Concepts guide. Retain #4839's API corrections. - Integrate #4841's runtime/performance guidance and review incoming/recent prose. Preserve dated measurements rather than claiming new benchmark runs; clarify allocation ratios, startup-only processor settings, JIT warm-up and the benchmark commit's scope. Missing raw measurement artifacts and repeat ranges remain tracked by #4842. - Merge master through `e8c5d800a` in `32c6394b7`. Resolve the CTT log conflict using the updated Mantis states and OPC answers, retaining historical framing and re-checks for C28/C32/C43. - Address the latest naming/index feedback in `adb5bf693`: rename the guides to `docs/WotCon.md` and `docs/WotNodeSetConversion.md`; move the provider and DataType-declaration contracts into the conversion guide and remove `docs/WoT.md`. Rename `samples/DI` to `samples/Di` and `samples/Isa95` to `samples/ISA95`. Add content-index READMEs to Di, FluentApi, ISA95, Lds and PubSub; update solution entries, project references, Docker/CI paths, test fixture paths and documentation links with exact casing. **WoT guide scope.** This branch retains the detailed conversion guide that #4758 had replaced with an anchor stub. Conversion limits, verified document sets, preservation rules and provider ownership now live together in `WotNodeSetConversion.md`; binding/runtime guidance remains in `WotBindings.md` and `WotCon.md`. The design-rationale/test-ledger prose was shortened, the oversized argument-table cell moved into its section, and existing anchors preserved. **SDK policy is a separate, explicit user-directed change.** `global.json` sets a stable minimum of `10.0.400`, `rollForward: latestMajor`, and `allowPrerelease: false`. Newer major SDKs are permitted; CI's explicit SDK pins are unchanged. README, GettingStarted, DeveloperGuide and Recycling instructions reflect the possible analyzer differences. The image-contract regression fix accepts compatible stable SDK images instead of requiring exact equality with the floor. The latest four rename/index threads are resolved after publication. Three older threads remain open: universal obsolete-removal timing, unconditional nonce-strength wording, and a blanket Vision NativeAOT claim. Existing implementation/evidence constraints are explained in their inline replies. The two-level TOCs remain as requested. ## Validation - `git diff --check` and staged diff checks: passed. The untouched upstream AutoID NodeSet retains its provenance bytes, including two existing license-header trailing spaces. - `.\.azurepipelines\validate-migration-plugin.ps1`: passed; 15 bundled migration documents and manifests synchronized. - Documentation/path validation: **101** documents retain two rendered TOC levels (**2,228** entries), with idempotent formatting. **52** new relative links and their anchors passed exact-case checks. No tracked references to the old guide/sample paths remain. Both relocated provider-contract sections are preserved in the destination. - `dotnet sln UA.slnx list`: passed; shows the renamed Di/ISA95 projects and the existing FluentApi/Lds/PubSub projects. Updated solution and pump ProjectReference paths also passed exact-case existence checks. - Latest focused commands, run from the repository root: ```powershell # Passed: 61 channel send-order and reconnect tests. dotnet test tests\Opc.Ua.Core.Tests\Opc.Ua.Core.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~UaSCBinaryChannelSendOrderTests|FullyQualifiedName~TcpReconnectKeyAgreementTests' --verbosity minimal # Passed: 5 pump datasheet tests; builds the renamed pump sample. dotnet test tests\Opc.Ua.Di.Tests\Opc.Ua.Di.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~PumpDatasheetConformanceTests' --verbosity minimal # Passed: 4 repository NodeSet path/round-trip tests, including the moved pump models. dotnet test tests\Opc.Ua.Types.Tests\Opc.Ua.Types.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~RepositorySourceSurvivesSerializedLinkedPartitionsAsync' --verbosity minimal # Passed: build, zero warnings/errors. dotnet build samples\ISA95\MinimalIsa95Server\MinimalIsa95Server.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal # Passed: dependent sample-test project build, zero warnings/errors. dotnet build tests\Opc.Ua.WotCon.Samples.Tests\Opc.Ua.WotCon.Samples.Tests.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal ``` Earlier focused integration checks passed 2,620 tests across AutoID, event queues/scheduling, source generation, MCP/package profiles and WoT. Both reviewed Mermaid diagrams rendered locally without network access. These checks are not a full solution run. The full solution has **not** been rerun for this review. Earlier `dotnet test UA.slnx -p:CustomTestTarget=net10.0 --verbosity quiet` did not pass: three AOT projects rejected VSTest and 20 Vision tests failed during graphics initialization with `OutOfMemoryException`. Remaining long-running tests were stopped at the user's request. A focused Vision rerun passed 558 tests and reproduced those 20 failures. The earlier `dotnet test UA.slnx -p:CustomTestTarget=net48 --verbosity quiet` was blocked by the former SDK pin and was not retried after the policy change. The user approved proceeding with those limitations documented; current remote CI is not claimed green. ## Related Issues - Follow-up #4842 tracks the requested 2.0.2+ benchmark/tuning and diagnostic-tool documentation refresh. #4841 supplies documentation and earlier results, not all newly requested measurements. - #4758 explains the conversion guide's earlier consolidation; the current provider contracts are now consolidated into `WotNodeSetConversion.md`. - #4839 supplies the reviewed API corrections; #4843 supplies the updated CTT issue record. - The original prose cleanup and SDK policy were user-requested without a source issue. No new runtime architecture is introduced by these documentation edits. ## Checklist _Put an `x` in the boxes that apply. You can complete these step by step after opening the PR._ - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [ ] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. --------- Co-authored-by: Roman Ettlinger <romanett98@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
212 lines
8.0 KiB
C#
212 lines
8.0 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using BenchmarkDotNet.Attributes;
|
|
using BenchmarkDotNet.Configs;
|
|
using BenchmarkDotNet.Engines;
|
|
using BenchmarkDotNet.Jobs;
|
|
using BenchmarkDotNet.Toolchains.InProcess.Emit;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Client.Subscriptions
|
|
{
|
|
/// <summary>
|
|
/// Microbenchmark for V2 subscription notification pooling.
|
|
/// Compares the unpooled <c>new</c> path against the pooled
|
|
/// <c>CreateInstance() + Reuse()</c> path for each publish-payload
|
|
/// type tagged <c>Poolable="true"</c> in the design XML
|
|
/// (<see cref="MonitoredItemNotification"/>,
|
|
/// <see cref="DataChangeNotification"/>,
|
|
/// <see cref="EventFieldList"/>,
|
|
/// <see cref="EventNotificationList"/>).
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// To run interactively:
|
|
/// <code>
|
|
/// dotnet test tests/Opc.Ua.Subscriptions.Tests --filter "FullyQualifiedName~PooledNotificationBenchmarks"
|
|
/// </code>
|
|
/// To run as a BenchmarkDotNet harness, invoke the test fixture's
|
|
/// <c>[GlobalSetup]</c>/<c>[Benchmark]</c> via the standard BDN
|
|
/// runner. The <c>[Test]</c> attributes also let the suite double
|
|
/// as a smoke test under the unit-test runner.
|
|
/// </remarks>
|
|
[TestFixture]
|
|
[MemoryDiagnoser]
|
|
[Category("PooledNotificationBenchmarks")]
|
|
[NonParallelizable]
|
|
[Config(typeof(InProcessConfig))]
|
|
public class PooledNotificationBenchmarks
|
|
{
|
|
/// <summary>
|
|
/// In-process toolchain config — skips BDN's auto-generated
|
|
/// project rebuild (which times out for a test assembly that
|
|
/// transitively pulls hundreds of references).
|
|
/// </summary>
|
|
[System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes",
|
|
Justification = "Instantiated by BenchmarkDotNet via reflection")]
|
|
private sealed class InProcessConfig : ManualConfig
|
|
{
|
|
public InProcessConfig()
|
|
{
|
|
AddJob(Job.ShortRun
|
|
.WithToolchain(InProcessEmitToolchain.Instance)
|
|
.WithStrategy(RunStrategy.Throughput));
|
|
}
|
|
}
|
|
|
|
private const int Iterations = 1000;
|
|
|
|
[GlobalSetup]
|
|
[OneTimeSetUp]
|
|
public void Setup()
|
|
{
|
|
// Pre-warm the pools so the first benchmark iteration
|
|
// doesn't pay the cost of populating them.
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var m = (MonitoredItemNotification)
|
|
MonitoredItemNotificationActivator.Instance.CreateInstance();
|
|
m.Reuse();
|
|
var d = (DataChangeNotification)
|
|
DataChangeNotificationActivator.Instance.CreateInstance();
|
|
d.Reuse();
|
|
var e = (EventFieldList)
|
|
EventFieldListActivator.Instance.CreateInstance();
|
|
e.Reuse();
|
|
var en = (EventNotificationList)
|
|
EventNotificationListActivator.Instance.CreateInstance();
|
|
en.Reuse();
|
|
}
|
|
}
|
|
|
|
[Benchmark(Baseline = true, Description = "new MonitoredItemNotification()")]
|
|
[Test]
|
|
public void UnpooledMonitoredItemNotification()
|
|
{
|
|
int sum = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var item = new MonitoredItemNotification
|
|
{
|
|
ClientHandle = (uint)i
|
|
};
|
|
sum += (int)item.ClientHandle;
|
|
}
|
|
Assert.That(sum, Is.GreaterThanOrEqualTo(0));
|
|
}
|
|
|
|
[Benchmark(Description = "MonitoredItemNotificationActivator + Reuse")]
|
|
[Test]
|
|
public void PooledMonitoredItemNotification()
|
|
{
|
|
int sum = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var item = (MonitoredItemNotification)
|
|
MonitoredItemNotificationActivator.Instance.CreateInstance();
|
|
item.ClientHandle = (uint)i;
|
|
sum += (int)item.ClientHandle;
|
|
item.Reuse();
|
|
}
|
|
Assert.That(sum, Is.GreaterThanOrEqualTo(0));
|
|
}
|
|
|
|
[Benchmark(Description = "new DataChangeNotification()")]
|
|
[Test]
|
|
public void UnpooledDataChangeNotification()
|
|
{
|
|
int count = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var notification = new DataChangeNotification
|
|
{
|
|
MonitoredItems = new MonitoredItemNotification[]
|
|
{
|
|
new() { ClientHandle = (uint)i }
|
|
}
|
|
};
|
|
count += notification.MonitoredItems.Count;
|
|
}
|
|
Assert.That(count, Is.EqualTo(Iterations));
|
|
}
|
|
|
|
[Benchmark(Description = "DataChangeNotificationActivator + Reuse")]
|
|
[Test]
|
|
public void PooledDataChangeNotification()
|
|
{
|
|
int count = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var notification = (DataChangeNotification)
|
|
DataChangeNotificationActivator.Instance.CreateInstance();
|
|
var item = (MonitoredItemNotification)
|
|
MonitoredItemNotificationActivator.Instance.CreateInstance();
|
|
item.ClientHandle = (uint)i;
|
|
notification.MonitoredItems = new MonitoredItemNotification[] { item };
|
|
count += notification.MonitoredItems.Count;
|
|
item.Reuse();
|
|
notification.Reuse();
|
|
}
|
|
Assert.That(count, Is.EqualTo(Iterations));
|
|
}
|
|
|
|
[Benchmark(Description = "new EventFieldList()")]
|
|
[Test]
|
|
public void UnpooledEventFieldList()
|
|
{
|
|
int sum = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var item = new EventFieldList
|
|
{
|
|
ClientHandle = (uint)i
|
|
};
|
|
sum += (int)item.ClientHandle;
|
|
}
|
|
Assert.That(sum, Is.GreaterThanOrEqualTo(0));
|
|
}
|
|
|
|
[Benchmark(Description = "EventFieldListActivator + Reuse")]
|
|
[Test]
|
|
public void PooledEventFieldList()
|
|
{
|
|
int sum = 0;
|
|
for (int i = 0; i < Iterations; i++)
|
|
{
|
|
var item = (EventFieldList)
|
|
EventFieldListActivator.Instance.CreateInstance();
|
|
item.ClientHandle = (uint)i;
|
|
sum += (int)item.ClientHandle;
|
|
item.Reuse();
|
|
}
|
|
Assert.That(sum, Is.GreaterThanOrEqualTo(0));
|
|
}
|
|
}
|
|
}
|