GithubStar/appium
1
0
Fork 0
mirror of https://github.com/appium/appium.git synced 2026-10-29 04:36:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9 from moizjv/master

Browse Source 
Changing onSettingsUpdate signature
This commit is contained in:
Jonathan Lipps
2015-08-17 22:29:23 -07:00
parent ee8a77f262 a5329d8b83
commit 0c3fbb4fae
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/device-settings.js
+2 -7
View File
@@ -14,15 +14,10 @@ class DeviceSettings {
}
for (let prop of _.keys(newSettings)) {
if(this._settings[prop] !== newSettings[prop]) {
let updatePayload = {
key: prop,
value: newSettings[prop],
oldValue: this._settings[prop],
};
this._settings[prop] = newSettings[prop];
// update setting only when there is updateSettings defined.
if (this.onSettingsUpdate) {
await this.onSettingsUpdate(updatePayload);
await this.onSettingsUpdate(prop, newSettings[prop], this._settings[prop]);
this._settings[prop] = newSettings[prop];
} else {
log.errorAndThrow("Unable to update settings; onSettingsUpdate method not found");
}