GithubStar/docsify
1
0
Fork 0
mirror of https://github.com/docsifyjs/docsify.git synced 2026-10-22 23:39:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix emoji image alt attribute

Browse Source
This commit is contained in:
John Hildenbiddle
2022-02-04 02:12:00 -06:00
parent 1fa45e5776
commit 8252f3a18b
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/render/emojify.js
+1 -1
View File
@@ -1892,7 +1892,7 @@ function replaceEmojiShorthand(m, $1, useNativeEmoji) {
.concat('︎');
result = `<span class="emoji">${emojiUnicode}</span>`;
} else {
result = `<img class="emoji" src="https://github.githubassets.com/images/icons/emoji/${emojiMatch}.png" alt="${1}">`;
result = `<img class="emoji" src="https://github.githubassets.com/images/icons/emoji/${emojiMatch}.png" alt="${$1}">`;
}
}
test/integration/__snapshots__/docs.test.js.snap
+1 -1
View File
@@ -7,6 +7,6 @@ exports[`Docs Site coverpage renders and is unchanged 1`] = `
<a href=\\"#/?id=docsify\\">Getting Started</a></p></div></section>"
`;
exports[`Docs Site navbar renders and is unchanged 1`] = `"<nav class=\\"app-nav no-badge\\"><ul><li>Translations<ul><li><a href=\\"#/\\" title=\\"undefined\\" class=\\"active\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/uk.png\\" alt=\\"uk\\"> English</a></li><li><a href=\\"#/zh-cn/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/cn.png\\" alt=\\"cn\\"> 中文</a></li><li><a href=\\"#/de-de/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/de.png\\" alt=\\"de\\"> Deutsch</a></li><li><a href=\\"#/es/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/es.png\\" alt=\\"es\\"> Español</a></li><li><a href=\\"#/ru-ru/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/ru.png\\" alt=\\"ru\\"> Русский</a></li></ul></li></ul></nav>"`;
exports[`Docs Site navbar renders and is unchanged 1`] = `"<nav class=\\"app-nav no-badge\\"><ul><li>Translations<ul><li><a href=\\"#/\\" title=\\"undefined\\" class=\\"active\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1ec-1f1e7.png\\" alt=\\"uk\\"> English</a></li><li><a href=\\"#/zh-cn/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1e8-1f1f3.png\\" alt=\\"cn\\"> 中文</a></li><li><a href=\\"#/de-de/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1e9-1f1ea.png\\" alt=\\"de\\"> Deutsch</a></li><li><a href=\\"#/es/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1ea-1f1f8.png\\" alt=\\"es\\"> Español</a></li><li><a href=\\"#/ru-ru/\\" title=\\"undefined\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1f7-1f1fa.png\\" alt=\\"ru\\"> Русский</a></li></ul></li></ul></nav>"`;
exports[`Docs Site sidebar renders and is unchanged 1`] = `"<aside class=\\"sidebar\\"><div class=\\"sidebar-nav\\"><ul><li><p>Getting started</p><ul><li><a href=\\"#/quickstart\\" title=\\"undefined\\">Quick start</a></li><li><a href=\\"#/more-pages\\" title=\\"undefined\\">Writing more pages</a></li><li><a href=\\"#/custom-navbar\\" title=\\"undefined\\">Custom navbar</a></li><li><a href=\\"#/cover\\" title=\\"undefined\\">Cover page</a></li></ul></li><li><p>Customization</p><ul><li><a href=\\"#/configuration\\" title=\\"undefined\\">Configuration</a></li><li><a href=\\"#/themes\\" title=\\"undefined\\">Themes</a></li><li><a href=\\"#/plugins\\" title=\\"undefined\\">List of Plugins</a></li><li><a href=\\"#/write-a-plugin\\" title=\\"undefined\\">Write a Plugin</a></li><li><a href=\\"#/markdown\\" title=\\"undefined\\">Markdown configuration</a></li><li><a href=\\"#/language-highlight\\" title=\\"undefined\\">Language highlighting</a></li></ul></li><li><p>Guide</p><ul><li><a href=\\"#/deploy\\" title=\\"undefined\\">Deploy</a></li><li><a href=\\"#/helpers\\" title=\\"undefined\\">Helpers</a></li><li><a href=\\"#/vue\\" title=\\"undefined\\">Vue compatibility</a></li><li><a href=\\"#/cdn\\" title=\\"undefined\\">CDN</a></li><li><a href=\\"#/pwa\\" title=\\"undefined\\">Offline Mode (PWA)</a></li><li><a href=\\"#/ssr\\" title=\\"undefined\\">Server-Side Rendering (SSR)</a></li><li><a href=\\"#/embed-files\\" title=\\"undefined\\">Embed Files</a></li></ul></li><li><p><a href=\\"#/awesome\\" title=\\"undefined\\">Awesome docsify</a></p></li><li><p><a href=\\"#/changelog\\" title=\\"undefined\\">Changelog</a></p></li></ul></div></aside>"`;
test/integration/__snapshots__/emoji.test.js.snap
+1 -1
View File
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Emoji Fallback emoji (images) 1`] = `"<p>hh:mm</p><p>hh:mm:</p><p>hh:mm:ss</p><p>:mm:s</p><p>Namespace::SubNameSpace</p><p>Namespace::SubNameSpace::Class</p><p>2014-12-29T16:11:20+00:00</p><p>2020-12-03T15:05:57+00:00 (extended)</p><p>2020-12-03T15:05:57Z (extended)</p><p>:01:</p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"></p><p>1<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\">1</p><p>1<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\">1</p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"1\\"></p>"`;
exports[`Emoji Fallback emoji (images) 1`] = `"<p>hh:mm</p><p>hh:mm:</p><p>hh:mm:ss</p><p>:mm:s</p><p>Namespace::SubNameSpace</p><p>Namespace::SubNameSpace::Class</p><p>2014-12-29T16:11:20+00:00</p><p>2020-12-03T15:05:57+00:00 (extended)</p><p>2020-12-03T15:05:57Z (extended)</p><p>:01:</p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p>1<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\">1</p><p>1<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\">1</p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p>"`;
exports[`Emoji Native emoji 1`] = `"<p>hh:mm</p><p>hh:mm:</p><p>hh:mm:ss</p><p>:mm:s</p><p>Namespace::SubNameSpace</p><p>Namespace::SubNameSpace::Class</p><p>2014-12-29T16:11:20+00:00</p><p>2020-12-03T15:05:57+00:00 (extended)</p><p>2020-12-03T15:05:57Z (extended)</p><p>:01:</p><p><span class=\\"emoji\\">😄︎</span></p><p>1<span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span>1</p><p>1<span class=\\"emoji\\">😄︎</span>1</p><p><span class=\\"emoji\\">😄︎</span><span class=\\"emoji\\">😄︎</span><span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span> <span class=\\"emoji\\">😄︎</span> <span class=\\"emoji\\">😄︎</span></p>"`;