GithubStar/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv.git synced 2026-10-26 04:59:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

demux_timeline: don't close segments during demuxing

Browse Source 
add_tl() when creating virtual_stream list is referencing sh->codec
which is owned by the demuxer. Don't close it to avoid dangling
pointers. The comment is right, but this happens regardless of
delay_open as we can clearly see in the add_tl() function.
This commit is contained in:
Kacper Michajłow
2025-03-07 20:32:37 +01:00
parent 533a684381
commit 91f80b5948
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
demux/demux_timeline.c
+1 -3
View File
@@ -210,11 +210,9 @@ static void reopen_lazy_segments(struct demuxer *demuxer,
if (src->current->d)
return;
// Note: in delay_open mode, we must _not_ close segments during demuxing,
// Note: we must _not_ close segments during demuxing,
// because demuxed packets have demux_packet.codec set to objects owned
// by the segments. Closing them would create dangling pointers.
if (!src->delay_open)
close_lazy_segments(demuxer, src);
struct demuxer_params params = {
.init_fragment = src->tl->init_fragment,