GithubStar/neuron
1
0
Fork 0
mirror of https://github.com/emqx/neuron.git synced 2026-10-25 11:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #615 from eeff/eeff/fix

Browse Source 
ci: remove cppcheck errors
This commit is contained in:
fengzeroz
2022-07-05 09:39:33 +08:00
committed by GitHub
parent 3299eab989 282ca37050
commit cf417049cf
10 changed files with 27 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/ekuiper/json_rw.c
+2 -4
View File
@@ -141,7 +141,7 @@ int json_encode_read_resp_tags(void *json_object, void *param)
return -1;
}
errors_object = neu_json_encode_new();
if (NULL == values_object) {
if (NULL == errors_object) {
plog_error(plugin, "ekuiper cannot allocate json object");
json_decref(values_object);
return -1;
@@ -260,9 +260,7 @@ int json_decode_write_req(char *buf, size_t len, json_write_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
plugins/restful/http.c
+4 -3
View File
@@ -62,8 +62,9 @@ static int response(nng_aio *aio, char *content, enum nng_http_status status)
ssize_t url_decode(const char *s, size_t len, char *buf, size_t size)
{
size_t i = 0, j = 0;
int c = 0, n = 0;
size_t i = 0, j = 0;
int n = 0;
unsigned int c;
while (i < len && j < size) {
c = s[i++];
if ('+' == c) {
@@ -92,7 +93,7 @@ int http_get_body(nng_aio *aio, void **data, size_t *data_size)
nng_http_req *req = nng_aio_get_input(aio, 0);
nng_http_req_get_data(req, data, data_size);
if (*data_size <= 0) {
if (*data_size == 0) {
return -1;
} else {
char *buf = calloc(*data_size + 1, sizeof(char));
src/parser/neu_json_group_config.c
+5 -15
View File
@@ -68,9 +68,7 @@ int neu_json_decode_add_group_config_req(
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -123,9 +121,7 @@ int neu_json_decode_del_group_config_req(
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -260,9 +256,7 @@ int neu_json_decode_subscribe_req(char *buf, neu_json_subscribe_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -320,9 +314,7 @@ int neu_json_decode_unsubscribe_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -381,9 +373,7 @@ int neu_json_decode_update_group_config_req(
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
src/parser/neu_json_license.c
+4 -3
View File
@@ -101,6 +101,9 @@ int neu_json_decode_set_license_req(char * buf,
int ret = 0;
neu_json_set_license_req_t *req =
calloc(1, sizeof(neu_json_set_license_req_t));
if (NULL == req) {
return -1;
}
neu_json_elem_t req_elems[] = { {
.name = "license",
@@ -117,9 +120,7 @@ int neu_json_decode_set_license_req(char * buf,
return ret;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
return -1;
}
src/parser/neu_json_login.c
+1 -3
View File
@@ -54,9 +54,7 @@ int neu_json_decode_login_req(char *buf, neu_json_login_req_t **result)
return ret;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
return -1;
}
src/parser/neu_json_node.c
+5 -15
View File
@@ -61,9 +61,7 @@ int neu_json_decode_add_node_req(char *buf, neu_json_add_node_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -109,9 +107,7 @@ int neu_json_decode_del_node_req(char *buf, neu_json_del_node_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -219,9 +215,7 @@ int neu_json_decode_update_node_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -271,9 +265,7 @@ int neu_json_decode_node_ctl_req(char *buf, neu_json_node_ctl_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -318,9 +310,7 @@ int neu_json_decode_node_setting_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
src/parser/neu_json_plugin.c
+2 -6
View File
@@ -58,9 +58,7 @@ int neu_json_decode_add_plugin_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -107,9 +105,7 @@ int neu_json_decode_del_plugin_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
src/parser/neu_json_rw.c
+2 -6
View File
@@ -157,9 +157,7 @@ int neu_json_decode_write_req(char *buf, neu_json_write_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
@@ -213,9 +211,7 @@ int neu_json_decode_read_req(char *buf, neu_json_read_req_t **result)
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
src/persist/json/persist_json_group_configs.c
+1 -3
View File
@@ -68,9 +68,7 @@ int neu_json_decode_group_configs_req(char * buf,
goto decode_exit;
decode_fail:
if (req != NULL) {
free(req);
}
free(req);
ret = -1;
decode_exit:
src/persist/persist.c
+1 -1
View File
@@ -103,7 +103,7 @@ const char *neu_persister_get_plugins_fname(neu_persister_t *persister)
static int path_escape(char *buf, size_t size, const char *path)
{
size_t i = 0;
char c = '\0';
char c;
if (NULL != buf) {
for (const char *s = path; (c = *s++) && i < size; ++i) {