GithubStar/neuron
1
0
Fork 0
mirror of https://github.com/emqx/neuron.git synced 2026-10-17 04:40:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2908 from fengzeroz/main

Browse Source 
#2095 fix allock fail, memory leak
This commit is contained in:
fengzeroz
2026-07-16 17:17:08 +08:00
committed by GitHub
parent 709250b056 4d488bca7c
commit d43def9dab
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/mqtt/mqtt_handle.c
+19 -1
View File
@@ -1748,12 +1748,14 @@ int handle_nodes_state(neu_plugin_t *plugin, neu_reqresp_nodes_state_t *states)
goto end;
}
bool alloc_fail = false;
utarray_foreach(states->states, neu_nodes_state_t *, state)
{
Model__NodeState *ns = calloc(1, sizeof(Model__NodeState));
if (NULL == ns) {
plog_error(plugin, "malloc fail");
goto end;
alloc_fail = true;
break;
}
model__node_state__init(ns);
ns->node = state->node;
@@ -1763,9 +1765,25 @@ int handle_nodes_state(neu_plugin_t *plugin, neu_reqresp_nodes_state_t *states)
node_states[utarray_eltidx(states->states, state)] = ns;
}
if (alloc_fail) {
for (size_t i = 0; i < nsr.n_nodes; i++) {
free(node_states[i]);
}
free(node_states);
goto end;
}
nsr.nodes = node_states;
size = model__node_state_report__get_packed_size(&nsr);
json_str = malloc(size);
if (NULL == json_str) {
plog_error(plugin, "malloc fail");
for (size_t i = 0; i < nsr.n_nodes; i++) {
free(node_states[i]);
}
free(node_states);
goto end;
}
model__node_state_report__pack(&nsr, (uint8_t *) json_str);
for (size_t i = 0; i < nsr.n_nodes; i++) {