GithubStar/open62541
1
0
Fork 0
mirror of https://github.com/open62541/open62541.git synced 2026-10-16 20:33:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugin): Disable padding by OpenSSL (is done internally)

Browse Source 
This lead to OpenSSL mistakenly writing behind the buffer length in some
cases.
This commit is contained in:
Julius Pfrommer
2022-11-13 23:23:02 +01:00
parent fdf7729d81
commit 33f954aad0
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/crypto/openssl/securitypolicy_openssl_common.c
+16 -4
View File
@@ -646,16 +646,28 @@ UA_OpenSSL_Encrypt (const UA_ByteString * iv,
ret = UA_STATUSCODE_BADINTERNALERROR;
goto errout;
}
/* Disable padding. Padding is done in the stack before calling encryption.
* Ensure that we have a multiple of the block size */
if(data->length % (size_t)EVP_CIPHER_CTX_block_size(ctx)) {
ret = UA_STATUSCODE_BADINTERNALERROR;
goto errout;
}
opensslRet = EVP_CIPHER_CTX_set_padding(ctx, 0);
if (opensslRet != 1) {
ret = UA_STATUSCODE_BADINTERNALERROR;
goto errout;
}
/* Encrypt the data */
opensslRet = EVP_EncryptUpdate (ctx, data->data, &outLen,
plainTxt.data, (int) plainTxt.length);
if (opensslRet != 1) {
ret = UA_STATUSCODE_BADINTERNALERROR;
goto errout;
}
/*
* Buffer passed to EVP_EncryptFinal() must be after data just
* encrypted to avoid overwriting it.
*/
/* Encrypt-final does nothing as padding is disabled */
opensslRet = EVP_EncryptFinal_ex(ctx, data->data + outLen, &tmpLen);
if (opensslRet != 1) {
ret = UA_STATUSCODE_BADINTERNALERROR;