GithubStar/playwright-dotnet
1
0
Fork 0
mirror of https://github.com/microsoft/playwright-dotnet.git synced 2026-10-29 14:11:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix .NET SDK warning (#1669)

Browse Source 
Fix NETSDK1174 warning with the .NET 6 SDK.
This commit is contained in:
Martin Costello
2021-08-12 11:52:45 +02:00
committed by GitHub
parent 9440246c66
commit cc45dad9ae
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.build/azure-pipeline-nuget.yml
+1 -1
View File
@@ -44,7 +44,7 @@ stages:
displayName: Download the browsers
inputs:
command: 'run'
arguments: '-p $(Build.SourcesDirectory)/src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath $(Build.SourcesDirectory)'
arguments: '--project $(Build.SourcesDirectory)/src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath $(Build.SourcesDirectory)'
- task: DotNetCoreCLI@2
displayName: Build Playwright CLI
.github/workflows/tests.yml
+4 -4
View File
@@ -39,8 +39,8 @@ jobs:
- name: Installing Browsers and dependencies...
shell: pwsh
run: |
dotnet run -p .\src\Playwright\Playwright.csproj -f net5.0 -- install
dotnet run -p .\src\Playwright\Playwright.csproj -f net5.0 -- install-deps
dotnet run --project .\src\Playwright\Playwright.csproj -f net5.0 -- install
dotnet run --project .\src\Playwright\Playwright.csproj -f net5.0 -- install-deps
- name: Running tests...
if: ${{ matrix.os != 'ubuntu-latest' }}
shell: pwsh
@@ -86,8 +86,8 @@ jobs:
- name: Installing Browsers and dependencies...
shell: pwsh
run: |
dotnet run -p .\src\Playwright\Playwright.csproj -f net5.0 -- install
dotnet run -p .\src\Playwright\Playwright.csproj -f net5.0 -- install-deps
dotnet run --project .\src\Playwright\Playwright.csproj -f net5.0 -- install
dotnet run --project .\src\Playwright\Playwright.csproj -f net5.0 -- install-deps
- name: Running tests...
shell: bash
env:
CONTRIBUTING.md
+2 -2
View File
@@ -87,7 +87,7 @@ This will run the following commands:
```ps
git submodule update --init
dotnet tool install --global dotnet-format
dotnet run -p ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
```
#### Dotnet Format
@@ -141,5 +141,5 @@ cd playwright
git checkout commitsha
cd ..
node "playwright/utils/doclint/generateDotnetApi.js" "src/Playwright"
dotnet run -p ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
```
build.ps1
+1 -1
View File
@@ -51,7 +51,7 @@ function Invoke-DownloadDriver() {
Invoke-InitializeSubmodule $false
if ($prereqs) { Invoke-InstallRequirements }
Write-Host "🚀 Downloading drivers..." -NoNewline
dotnet run -p ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .
}
function Invoke-Roll() {
src/Playwright/Playwright.csproj
+1 -1
View File
@@ -75,6 +75,6 @@
</PackageReference>
</ItemGroup>
<Target Name="EnsurePrerequisitsRan" BeforeTargets="DedupeDriver">
<Error Text="Playwright prerequisites are missing. Ensure you've ran `dotnet run -p ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .`" Condition="!Exists('$(MSBuildProjectDirectory)\.drivers')" />
<Error Text="Playwright prerequisites are missing. Ensure you've ran `dotnet run --project ./src/tools/Playwright.Tooling/Playwright.Tooling.csproj -- download-drivers --basepath .`" Condition="!Exists('$(MSBuildProjectDirectory)\.drivers')" />
</Target>
</Project>